From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Thu, 25 Sep 2025 21:33:22 GMT
Subject: Re: [PATCH v7 2/9] Makefile: reorder sources after includes
Message-ID: <06de5ccc-98e5-4bb6-bb09-e67be906ff6d@ramsayjones.plus.com>
In-Reply-To: <20250925-b4-pks-rust-breaking-change-v7-2-4e49dcb904d5@pks.im>



On 25/09/2025 7:30 am, Patrick Steinhardt wrote:
> In an upcoming change we'll make some of the sources compile
> conditionally based on whether or not `WITH_RUST` is defined. To let
> developers specify that flag in their "config.mak" we'll thus have to
> reorder our sources so that they come after the include of that file.
> 
> Do so.

Yep, I have a very similar patch which I used recently on cygwin so that
I could just 'make' git - having to remember to type 'make WITH_RUST=false'
all the time (and always forgetting) was somewhat annoying! :)

So, thanks for that!

ATB,
Ramsay Jones