From: Derrick Stolee <derrickstolee@github.com>
Date: Tue, 20 Dec 2022 13:30:11 GMT
Subject: Re: [PATCH] Revert "builtin/bundle.c: let parse-options parse subcommands"
Message-ID: <0609575c-68ad-5392-0631-3563c179f177@github.com>
In-Reply-To: <20221220123142.812965-1-hubertj@stmcyber.pl>

On 12/20/22 7:31 AM, Hubert Jasudowicz wrote:
> This reverts commit aef7d75e5809eda765bbe407c7f8e0f8617f0fd0.
> 
> The change breaks git bundle command. Running any subcommand
> results with:
> 
> $ git bundle create
> Segmentation fault (core dumped)

Could you be more specific? We have tests that verify that
these commands work without a segfault. There must be something
different about your environment that makes the segfault occur.

One thing that I could believe is that you are running 'git
bundle create' outside of a Git repository, and I doubt we have
tests covering that scenario.

Before reverting this change that has been out in two releases,
I recommend adding a test that demonstrates your failure and
then doing a specific update to fix that scenario.

Thanks,
-Stolee