From: Michael Montalbo via GitGitGadget Date: Tue, 05 May 2026 23:02:24 GMT Subject: [PATCH 4/4] parse-options: clarify PARSE_OPT_NONEG does not reject negative numbers Message-ID: <05ff821e6ffec02a3bfc5aef542592de6a7add76.1778022144.git.gitgitgadget@gmail.com> In-Reply-To: From: Michael Montalbo The name "NONEG" can be misread as "no negative [values]" when it actually means "no [boolean] negation" (the --no-* form). When --inter-hunk-context and -U/--unified were converted from a custom parser to OPT_INTEGER_F with PARSE_OPT_NONEG in d473e2e0e8 and 16ed6c97cc, the implicit rejection of negative values (via isdigit() in the old opt_arg() parser) was silently lost. The previous commits in this series fix the resulting bugs. Add a clarifying note to the flag documentation. Signed-off-by: Michael Montalbo --- parse-options.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/parse-options.h b/parse-options.h index 706de9729f..c0a3a3dcae 100644 --- a/parse-options.h +++ b/parse-options.h @@ -116,7 +116,10 @@ typedef int parse_opt_subcommand_fn(int argc, const char **argv, * mask of parse_opt_option_flags. * PARSE_OPT_OPTARG: says that the argument is optional (not for BOOLEANs) * PARSE_OPT_NOARG: says that this option does not take an argument - * PARSE_OPT_NONEG: says that this option cannot be negated + * PARSE_OPT_NONEG: says that this option cannot be negated (i.e. + * prevents --no-