From: Philip Oakley <philipoakley@iee.org>
Date: Wed, 05 Nov 2014 22:58:21 GMT
Subject: Re: [PATCH] use child_process_init() to initialize struct child_process variables
Message-ID: <05777A2415DD49F78B81EEA886A98F48@PhilipOakley>
In-Reply-To: <20141105193557.GA12620@peff.net>

From: "Jeff King" <peff@peff.net>
> On Wed, Nov 05, 2014 at 01:35:21PM -0000, Philip Oakley wrote:
>
>> >>  2. Including two lines, like:
>> [...]
>> I believe that the 'two HEADs' mechanism would also fall foul of the
>> 'duplicate refs' warning (untested).
>
> It didn't in my very brief testing of what I posted above, but maybe
> there is some other case that triggers it that I didn't exercise.

I'd been testing the inclusion of a duplicate of the ref that matched 
the HEAD symref (rather than HEAD itself), and had hit that message a 
few times, hence my concern.
>
> I grepped through the code and the only "duplicate ref" warning I see
> comes from the refs.c code, which comes from commit_packed_refs().

I had it from is_dup_ref(), also in refs.c, though I may have followed 
the call stack incorrectly back to the bundle effects.

> If
> the duplicate line is HEAD, I think it shouldn't trigger that, as it 
> is
> not a regular ref. That would explain why I didn't see it in my 
> testing.

I've now also done a test and found the same (no warning/error) when 
there are two HEADs listed in the bundle preamble. Sorry for the 
confusion.

--
Philip