From: rsbecker@nexbridge.com Date: Mon, 06 May 2024 20:38:59 GMT Subject: RE: [PATCH v5 00/14] builtin/config: introduce subcommands Message-ID: <04ef01da9ff5$700fab90$502f02b0$@nexbridge.com> In-Reply-To: On Monday, May 6, 2024 4:22 PM, Taylor Blau wrote: >On Mon, May 06, 2024 at 10:55:51AM +0200, Patrick Steinhardt wrote: >> Hi, >> >> this is the fifth and hopefully last version of my patch sthat >> introduces subcommands into git-config(1). >> >> The only changes compared to v4 are some fixes to commit messages. >> Otherwise I'm not aware of any other feedback that would need to be >> addressed. > >Thanks for the new round. I took a close look through the series, and couldn't see >any remaining issues. I appreciate the translation guide you included in the >documentation to indicate "git config --add" is replaced by things like "git config set >--append". Please make sure that there is a compatibility mode available for some large period. There are huge numbers of scripts in the customer base I deal with that use config extensively. Changing the CLI for this will be dire consequences.