From: Tian Yuchen Date: Sat, 27 Jun 2026 16:10:49 GMT Subject: Re: [PATCH v4 1/1] environment: move excludes_file into repo_config_values Message-ID: <04d1a7d5-ef83-4728-b816-5cdf1cb4aa25@malon.dev> In-Reply-To: <20260627160813.1074201-2-cat@malon.dev> Hi all, Apologies again for the duplicate... On 6/28/26 00:08, Tian Yuchen wrote: > +const char *repo_excludes_file(struct repository *repo) > +{ > + if (!repo || !repo->initialized) > + return NULL; > + > + if (!repo_config_values(repo)->excludes_file) > + repo_config_values(repo)->excludes_file = xdg_config_home("ignore"); > + > + return repo_config_values(repo)->excludes_file; > +} One more thing: I deliberately didn't write a comment for the getter because it will probably be merged with comments from the previous several patches in some form in the near future... I'm not sure if it would be more appropriate to write a separate patch to add the corresponding comments then. Regards, yuchen