From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Tue, 30 Sep 2025 13:34:01 GMT
Subject: Re: [PATCH v7 5/9] varint: use explicit width for integers
Message-ID: <037d8685-6521-4ac1-8251-d93e8a1d7081@app.fastmail.com>
In-Reply-To: <20250925-b4-pks-rust-breaking-change-v7-5-4e49dcb904d5@pks.im>

On Thu, Sep 25, 2025, at 08:30, Patrick Steinhardt wrote:
> The varint subsystem currently uses implcit widths for integers. On the

s/implcit/implicit/

> one hand we use `uintmax_t` for the actual value. On the other hand, we
> use `int` for the length of the encoded varint.
>
> Both of these have known maximum vaules, as we only support at most 16

s/vaules/values/

> bytes when encoding varints. Thus, we know that we won't ever exceed
> `uint64_t` for the actual value and `uint8_t` for the prefix length.
>[snip]