From: Mark C. Chu-Carroll Date: Tue, 27 Oct 2026 16:02:11 GMT Subject: Re: [PATCH] pack-objects: handle missing objects kkkjwhen excluding promisor objects Message-ID: <03704f3590183aadc16d5d81bdc64e9a@fastmail.com> In-Reply-To: <20261027-b4-pks-pack-objects-repack-links-with-missing-objects-v1-1-f50f90651274@pks.im> On Tue, 27 Oct 2026 08:00:28 +0100, Patrick Steinhardt wrote: > In a partial clone Git tries to maintain two different sets of objects: > promisor objects should be those that we have received from the remote, > and any such object may not be fully connected. Locally created objects > on the other hand should be stored as non-promisor objects. The goal is > that promisor objects should never reference non-promisor objects as the > "promisor" property is contagious, where a promisor implicitly means > that any of its referenced objects are promisor objects, too. Wordsmithing nitpick: this reads awkwardly. You start by saying there are two different kinds of things, and then introduce one of them, followed by a comma, followed by something which _isn't_ the second type of thing. Maybe: In a partial clone, Git tries to maintain two different sets of objects: promisor objects (which are those we have recieved from a remote, and may not be fully connected), and non-promisor objects (including any locally created objects). The goal is that ....