From: Derrick Stolee <derrickstolee@github.com>
Date: Thu, 24 Feb 2022 16:05:59 GMT
Subject: Re: [PATCH 18/23] fsm-health-win32: add framework to monitor daemon health
Message-ID: <0367bce8-3744-5835-aa26-6c1f9f359fdb@github.com>
In-Reply-To: <a398cdb8a04228ff94e2f5467c010f4917b27042.1644940774.git.gitgitgadget@gmail.com>

On 2/15/2022 10:59 AM, Jeff Hostetler via GitGitGadget wrote:
> From: Jeff Hostetler <jeffhost@microsoft.com>
> 
> Create framework in Win32 version of the "health" thread to
> periodically inspect the system and shutdown if warranted.

This specific step makes sense to not be included in the
previous step.

> +/*
> + * Every minute wake up and test our health.
> + */
> +#define WAIT_FREQ_MS (60 * 1000)
> +
> +enum interval_fn_ctx { CTX_INIT = 0, CTX_TERM, CTX_TIMER };

Please split out the values into their own lines.

Thanks,
-Stolee