From: Lars Schneider <larsxschneider@gmail.com>
Date: Mon, 12 Sep 2016 09:22:24 GMT
Subject: Re: [PATCH v7 03/10] pkt-line: add packet_write_fmt_gently()
Message-ID: <0365589B-7733-4C97-A566-957BACC67B29@gmail.com>
In-Reply-To: <CAGZ79kZaRdJqbjfacdxT5eqOaK-RObJo+AddZ8heaU-KzWCOwQ@mail.gmail.com>


> On 11 Sep 2016, at 18:01, Stefan Beller <sbeller@google.com> wrote:
> 
> On Sun, Sep 11, 2016 at 4:36 AM, Lars Schneider
> <larsxschneider@gmail.com> wrote:
> 
>>> 
>>>   call check_pipe from write_or_die here instead of
>>>   reproducing that function?
>> [...]
> 
>> Maybe it would be more suitable to move check_pipe to
>> run-command.h/c?
> 
> That's certainly possible.
> I don't have a strong opinion, where the code actually
> resides, but I do have a strong-ish opinion on code
> duplication. ;)

OK, then I will move check_pipe() to run-command.

Thanks,
Lars