From: Johannes Schindelin Date: Fri, 28 Apr 2017 13:49:27 GMT Subject: [PATCH v2 01/25] mingw: avoid memory leak when splitting PATH Message-ID: <0359bddb6fe5fd74ce2571f9933c18dfeb2a8f7e.1493387231.git.johannes.schindelin@gmx.de> In-Reply-To: In the (admittedly, concocted) case that PATH consists only of colons, we would leak the duplicated string. Signed-off-by: Johannes Schindelin --- compat/mingw.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/compat/mingw.c b/compat/mingw.c index 3fbfda5978b..fe0e3ccd248 100644 --- a/compat/mingw.c +++ b/compat/mingw.c @@ -961,8 +961,10 @@ static char **get_path_split(void) ++n; } } - if (!n) + if (!n) { + free(envpath); return NULL; + } ALLOC_ARRAY(path, n + 1); p = envpath; -- 2.12.2.windows.2.800.gede8f145e06