From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 07 Sep 2023 10:24:04 GMT
Subject: Re: [PATCH v4 11/15] replay: use standard revision ranges
Message-ID: <03460733-0219-c648-5757-db1958f8042e@gmx.de>
In-Reply-To: <20230907092521.733746-12-christian.couder@gmail.com>

Hi Christian,

It is a bit surprising to see the manual page added in _this_ patch, in
the middle of the series... I can live with it, though.

On Thu, 7 Sep 2023, Christian Couder wrote:

> diff --git a/Documentation/git-replay.txt b/Documentation/git-replay.txt
> new file mode 100644
> index 0000000000..9a2087b01a
> --- /dev/null
> +++ b/Documentation/git-replay.txt
> @@ -0,0 +1,90 @@
> +git-replay(1)
> +=============
> +
> +NAME
> +----
> +git-replay - Replay commits on a different base, without touching working tree
> +
> +
> +SYNOPSIS
> +--------
> +[verse]
> +'git replay' --onto <newbase> <revision-range>...

We need to make it clear here, already in the SYNOPSIS, that this is
experimental. Let's add an `(EXPERIMENTAL!)` prefix here.

> [...]
> diff --git a/t/t3650-replay-basics.sh b/t/t3650-replay-basics.sh
> new file mode 100755

Just like the manual page, I would have expected this test to be
introduced earlier, and not piggy-backed onto one of the handful "let's
turn fast-rebase into replay" patches.

Ciao,
Johannes