From: Keller, Jacob E <jacob.e.keller@intel.com>
Date: Wed, 03 Sep 2014 00:17:03 GMT
Subject: RE: [PATCH 1/9] git-compat-util.h: Add missing semicolon after struct itimerval
Message-ID: <02874ECE860811409154E81DA85FBB5857255DDC@ORSMSX115.amr.corp.intel.com>
In-Reply-To: <5400D7E5.8090606@Maxsi.org>

> -----Original Message-----
> From: git-owner@vger.kernel.org [mailto:git-owner@vger.kernel.org] On
> Behalf Of Jonas 'Sortie' Termansen
> Sent: Friday, August 29, 2014 12:44 PM
> To: Junio C Hamano
> Cc: git@vger.kernel.org; Keller, Jacob E; Johannes Sixt
> Subject: Re: [PATCH 1/9] git-compat-util.h: Add missing semicolon after
> struct itimerval
> 
> On 08/29/2014 09:07 PM, Junio C Hamano wrote:
> > Jonas 'Sortie' Termansen <Sortie@Maxsi.org> writes:
> > That is easy to fix, isn't it?
> >
> > Where you said "If you have timer_settimer(), set this makefile
> > variable", you start the sentence with "If you have a working
> > timer_settimer()" instead.
> 
> That's mostly right. I care about cross-compilation, so that is also
> something to keep in mind. It would be best if this could be
> automatically and robustly determined (even when cross-compiling),
> rather than relying on the user setting magic make variables.
> 
> Jonas

Couldn't this be solved by making our configure script smart enough to tell when it's at least the "known" broken OpenBSD implementation?

Regards,
Jake