From: Michael Haggerty Date: Sat, 22 Apr 2017 08:14:01 GMT Subject: Re: [PATCH v3 00/12] Fix git-gc losing objects in multi worktree Message-ID: <024e7bbd-16ad-04e1-a565-ac7b150c11e4@alum.mit.edu> In-Reply-To: <20170419110145.5086-1-pclouds@gmail.com> On 04/19/2017 01:01 PM, Nguyễn Thái Ngọc Duy wrote: > Changes since v2 [1] is relatively small. It still needs > nd/worktree-kill-parse-ref of course. I read the whole series. Aside from the comments I made, it looks good to me. This will be able to be cleaned up once we have a cleaner distinction between "logical" and "physical" ref_stores. But given the current state of the code, your implementation is reasonable. Michael