From: Lars Schneider <larsxschneider@gmail.com>
Date: Sun, 11 Sep 2016 12:34:49 GMT
Subject: Re: [PATCH v7 08/10] convert: modernize tests
Message-ID: <02449FE2-5997-4BDB-A3F4-2276470F27B9@gmail.com>
In-Reply-To: <CAGZ79kbG3Zza0e_kKhz5sBZcippwjewEBasYCioJF9drEov_Aw@mail.gmail.com>


> On 09 Sep 2016, at 00:05, Stefan Beller <sbeller@google.com> wrote:
> 
> On Thu, Sep 8, 2016 at 11:21 AM,  <larsxschneider@gmail.com> wrote:
>> From: Lars Schneider <larsxschneider@gmail.com>
>> 
>> Use `test_config` to set the config, check that files are empty with
>> `test_must_be_empty`, compare files with `test_cmp`, and remove spaces
>> after ">" and "<".
>> 
>> Please note that the "rot13" filter configured in "setup" keeps using
>> `git config` instead of `test_config` because subsequent tests might
>> depend on it.
>> 
>> Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
>> ---
> 
> Makes sense & Reviewed-by "Stefan Beller <sbeller@google.com>"

Thank you,
Lars