From: rsbecker@nexbridge.com Date: Wed, 17 May 2023 19:30:32 GMT Subject: RE: [PATCH 1/1] imap-send: include strbuf.h Message-ID: <017301d988f6$0fe7eb90$2fb7c2b0$@nexbridge.com> In-Reply-To: On Wednesday, May 17, 2023 2:12 PM, Junio C Hamano wrote: > writes: > >>>Oof, yes, you are right: >>> >>> diff -u \ >>> <(gcc -I . -E imap-send.c) \ >>> <(gcc -DNO_CURL=1 -I . -E imap-send.c) >>> >>>How *should* we test this? >> >> I hope not by using gcc, which is not currently a dependency. Using >> the C preprocessor directly might help in a more general sense, but >> you probably will need a knob for some compilers to work. > >I am not going to suggest trying all permutations of CPP macros to make sure we >cover all the #ifdef'ed sections, but -E to show CPP output is pretty common feature >not limited to "gcc", so if we were to do that, we'd very likely use the usual $(CC) >Makefile macro to invoke such a test. -E would work for me, but I do recall other platforms that would not (but can't place them at the moment). No objection from me, but it still might be useful to have a variable, like CPPFLAGS=-E (by default), that might help others, in config.mak.uname.