From: Olga Telezhnaya Date: Wed, 21 Feb 2018 06:59:01 GMT Subject: [PATCH 2/2] ref-filter: get rid of goto Message-ID: <01020161b7288324-d478f224-7a37-4341-993f-3c82a9941b7f-000000@eu-west-1.amazonses.com> In-Reply-To: <01020161b728823f-daec904e-44ff-45f9-9c89-d447b89c7802-000000@eu-west-1.amazonses.com> Get rid of goto command in ref-filter for better readability. Signed-off-by: Olga Telezhnaia Mentored-by: Christian Couder Mentored by: Jeff King --- ref-filter.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ref-filter.c b/ref-filter.c index 83ffd84affe52..28df6e21fb996 100644 --- a/ref-filter.c +++ b/ref-filter.c @@ -1494,11 +1494,11 @@ static void populate_value(struct ref_array_item *ref) for (i = 0; i < used_atom_cnt; i++) { struct atom_value *v = &ref->value[i]; if (v->s == NULL) - goto need_obj; + break; } - return; + if (used_atom_cnt <= i) + return; - need_obj: get_object(ref, &ref->objectname, 0, &obj); /* -- https://github.com/git/git/pull/460