From: Olga Telezhnaya Date: Mon, 05 Feb 2018 11:27:38 GMT Subject: [PATCH RFC v2 01/25] ref-filter: get rid of goto Message-ID: <0102016165b8b3c4-54efe4c4-6d19-435d-b5b9-6c727771353b-000000@eu-west-1.amazonses.com> In-Reply-To: <0102016133ff3a86-44d354ec-13c6-4c38-bc75-1ba4422db5a7-000000@eu-west-1.amazonses.com> Get rid of goto command in ref-filter for better readability. Signed-off-by: Olga Telezhnaia Mentored-by: Christian Couder Mentored by: Jeff King --- ref-filter.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/ref-filter.c b/ref-filter.c index f9e25aea7a97e..d04295e33448e 100644 --- a/ref-filter.c +++ b/ref-filter.c @@ -1477,12 +1477,13 @@ static void populate_value(struct ref_array_item *ref) for (i = 0; i < used_atom_cnt; i++) { struct atom_value *v = &ref->value[i]; - if (v->s == NULL) - goto need_obj; + if (v->s == NULL) { + break; + } } - return; + if (used_atom_cnt <= i) + return; - need_obj: buf = get_obj(&ref->objectname, &obj, &size, &eaten); if (!buf) die(_("missing object %s for %s"), -- https://github.com/git/git/pull/452