From: Ben Peart <peartben@gmail.com>
Date: Tue, 16 May 2017 01:15:13 GMT
Subject: Re: [PATCH v1 2/5] Teach git to optionally utilize a file system monitor to speed up detecting new or changed files.
Message-ID: <00db0fd9-e873-79f4-0497-0fec6c98d937@gmail.com>
In-Reply-To: <d195af80f27e4fea85a96d6435b36139@exmbdft7.ad.twosigma.com>


On 5/15/2017 5:21 PM, David Turner wrote:
>
>> -----Original Message-----
>> From: Ben Peart [mailto:peartben@gmail.com]
>> Sent: Monday, May 15, 2017 3:14 PM
>> To: git@vger.kernel.org
>> Cc: gitster@pobox.com; benpeart@microsoft.com; pclouds@gmail.com;
>> johannes.schindelin@gmx.de; David Turner <David.Turner@twosigma.com>;
>> peff@peff.net
>> Subject: [PATCH v1 2/5] Teach git to optionally utilize a file system monitor to
>> speed up detecting new or changed files.
>
>> @@ -342,6 +344,8 @@ struct index_state {
>>  	struct hashmap dir_hash;
>>  	unsigned char sha1[20];
>>  	struct untracked_cache *untracked;
>> +	time_t last_update;
>> +	struct ewah_bitmap *bitmap;
>
> The name 'bitmap' doesn't tell the reader much about what it used for.
>
>> +static int update_istate(const char *name, void *is) {
>
> Rename to mark_file_dirty?  Also why does it take a void pointer?  Or return int (rather than void)?
>

Thanks for the feedback.  I'll do some renaming and change the types passed.


>> +void refresh_by_fsmonitor(struct index_state *istate) {
>> +	static has_run_once = FALSE;
>> +	struct strbuf buffer = STRBUF_INIT;
>
> Rename to query_result? Also I think you're leaking it.
>

Good catch!  I missed the leak there.  Fixed for the next roll.