From: Joachim Schmitz Date: Wed, 22 Aug 2012 18:18:14 GMT Subject: RE: Porting git to HP NonStop Message-ID: <004001cd8092$7f9e6540$7edb2fc0$@schmitz-digital.de> In-Reply-To: <50352053.609@kdbg.org> > -----Original Message----- > From: Johannes Sixt [mailto:j6t@kdbg.org] > Sent: Wednesday, August 22, 2012 8:09 PM > To: Joachim Schmitz > Cc: 'Brandon Casey'; 'Junio C Hamano'; 'Shawn Pearce'; git@vger.kernel.org; > rsbecker@nexbridge.com > Subject: Re: Porting git to HP NonStop > > Am 22.08.2012 20:02, schrieb Joachim Schmitz: > >> From: Johannes Sixt [mailto:j6t@kdbg.org] Don't use x* wrappers in > >> the compat layer, at least not those that allocate > >> memory: They behave unpredictably due to try_to_free_routine and may > >> lead to recursive invocations. > > > > I was just following orders ;-) > > What about the other proposal, xmemdupz? Same story I guess? > > xmemdupz calls xmalloc, so, yes, same story. So back to my original patch, using strdup, check the return value, etc. Bye, Jojo