From: Joachim Schmitz Date: Wed, 22 Aug 2012 17:28:58 GMT Subject: RE: [PATCH] Don't use curl_easy_strerror prior to curl-7.12.0 Message-ID: <003001cd808b$9d505730$d7f10590$@schmitz-digital.de> In-Reply-To: <7v8vd6alqe.fsf@alter.siamese.dyndns.org> > From: Junio C Hamano [mailto:gitster@pobox.com] > Sent: Wednesday, August 22, 2012 7:19 PM > To: Joachim Schmitz > Cc: git@vger.kernel.org > Subject: Re: [PATCH] Don't use curl_easy_strerror prior to curl-7.12.0 > > "Joachim Schmitz" writes: > > > Signed-off-by: Joachim Schmitz > > At the very least, please mention that this reverts be22d92 (http: > avoid empty error messages for some curl errors, 2011-09-05) on platforms > with older versions of libcURL. a) Of course I didn't know that, thanks for telling me. b) How and where to add that? In the Subject of an email, in the body, right at the front? Like this: ---- This reverts be22d92 (http: avoid empty error messages for some curl errors, 2011-09-05) on platforms with older versions of libcURL. Signed-off-by: Joachim Schmitz --- http.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/http.c b/http.c index b61ac85..18bc6bf 100644 --- a/http.c +++ b/http.c @@ -806,10 +806,12 @@ static int http_request(const char *url, void *result, int target, int options) ret = HTTP_REAUTH; } } else { +#if LIBCURL_VERSION_NUM >= 0x070c00 if (!curl_errorstr[0]) strlcpy(curl_errorstr, curl_easy_strerror(results.curl_result), sizeof(curl_errorstr)); +#endif ret = HTTP_ERROR; } } else { -- 1.7.12 Bye, Jojo