From: Philip Oakley <philipoakley@iee.email>
Date: Sun, 05 Jul 2020 10:52:32 GMT
Subject: Re: [PATCH 1/4] submodule: amend extra line feed between callback struct and macro
Message-ID: <0028d1be-9479-b761-8617-cc73c4bb3858@iee.email>
In-Reply-To: <20200704153917.GD4087@danh.dev>

On 04/07/2020 16:39, Đoàn Trần Công Danh wrote:
> On 2020-07-04 20:51:04+0530, Shourya Shukla <shouryashukla.oo@gmail.com> wrote:
>> On 03/07 04:37, Philip Oakley wrote:
>>> Suggestion...
>>>
>>> On 03/07/2020 15:57, Johannes Schindelin wrote:
>>>> Maybe a native reader can suggest something that flows a bit easier? I am
>>>> not a native English speaker, but I'd prefer something along those lines:
>>>>
>>>> 	Many `submodule--helper` subcommands follow the convention a
>>> s/convention a/convention that a/    feels nicer for me
>> I did not get this one. Are you asking to replace "convention" with "a"
>> only?
> He probably meant put "that" between "convention" and "a"
> Pull ed/vi/sed out and that try this command on that line :)
>
> 	s/convention a/convention that a/
>
>
Correct.

Philip