From: miwilliams@google.com Date: Mon, 11 Apr 2016 19:04:23 GMT Subject: (unknown) Message-ID: <001a11492f107354a305303a369a@google.com> From 7201fe08ede76e502211a781250c9a0b702a78b2 Mon Sep 17 00:00:00 2001 From: Mike Williams Date: Mon, 11 Apr 2016 14:18:39 -0400 Subject: [PATCH 1/1] wt-status: Remove '!!' from wt_status_collect_changed_cb The wt_status_collect_changed_cb function uses an extraneous double negation (!!) when determining whether or not a submodule has new commits. Signed-off-by: Mike Williams --- wt-status.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wt-status.c b/wt-status.c index ef74864..b955179 100644 --- a/wt-status.c +++ b/wt-status.c @@ -431,7 +431,7 @@ static void wt_status_collect_changed_cb(struct diff_queue_struct *q, d->worktree_status = p->status; d->dirty_submodule = p->two->dirty_submodule; if (S_ISGITLINK(p->two->mode)) - d->new_submodule_commits = !!hashcmp(p->one->sha1, p->two->sha1); + d->new_submodule_commits = hashcmp(p->one->sha1, p->two->sha1); } } -- 2.8.0