From: Phillip Wood <phillip.wood@talktalk.net>
Date: Mon, 19 Jun 2017 09:52:33 GMT
Subject: Re: [PATCH v2 0/3] Add regression tests for rectent rebase -i fixes
Message-ID: <0013aa76-d743-e002-72b6-68e1a567fdbc@talktalk.net>
In-Reply-To: <xmqqfuf0ygmu.fsf@gitster.mtv.corp.google.com>

On 16/06/17 00:29, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
> 
>> Junio C Hamano <gitster@pobox.com> writes:
>>
>>> Phillip Wood <phillip.wood@talktalk.net> writes:
>>>
>>>> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>>>>
>>>> I've revised the second two tests as Johannes suggested to drop the
>>>> sed script. The first one is unchanged.
>>>>
>>>> Phillip Wood (3):
>>>>   rebase -i: Add test for reflog message
>>>>   rebase: Add regression tests for console output
>>>>   rebase: Add more regression tests for console output
>>>>
>>>>  t/t3404-rebase-interactive.sh |   7 +++
>>>>  t/t3420-rebase-autostash.sh   | 138 ++++++++++++++++++++++++++++++++++++++++--
>>>>  2 files changed, 141 insertions(+), 4 deletions(-)
>>>
>>> Thanks (and thanks for Dscho for reading it over).
>>>
>>> Unfortunately this breaks unless your shell is bash (I didn't have
>>> time to look further into it), i.e. "make SHELL_PATH=/bin/dash test"
>>
>> This is the bash-ism that broke it, I think.
>>
>>     create_expected_success_interactive() {
>>             cr=$'\r' &&
>>             cat >expected <<-EOF

Sorry about that, for some reason I thought $' was in the posix shell
standard but it's not. I'll redo the patches with the changes Johannes
suggested.