From: Randall S. Becker Date: Sat, 09 Feb 2019 16:53:19 GMT Subject: RE: [Breakage] Git v2.21.0-rc0 - t5318 (NonStop) Message-ID: <000201d4c097$f91c4080$eb54c180$@nexbridge.com> In-Reply-To: <20190209042456.GB18286@sigill.intra.peff.net> On February 8, 2019 23:25, Jeff King wrote: > On Fri, Feb 08, 2019 at 05:53:53PM -0500, Randall S. Becker wrote: > > > > diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh index > > > 92cf8f812c..4afab14431 100644 > > > --- a/t/test-lib-functions.sh > > > +++ b/t/test-lib-functions.sh > > > @@ -1302,3 +1302,8 @@ test_set_port () { > > > port=$(($port + ${GIT_TEST_STRESS_JOB_NR:-0})) > > > eval $var=$port > > > } > > > + > > > +# Generate an output of $1 bytes of all zeroes (NULs, not ASCII zeroes). > > > +gen_zero_bytes () { > > > + perl -e 'print "\0" x $ARGV[0]' "$@" > > > +} > > > > This function does work on platform, so it's good. > > Great. Since it sounds like you're preparing some patches to deal with > /dev/zero elsewhere, do you want to wrap it up in a patch as part of that? That's the plan. 😊 We're currently running a full test, so that takes time (32 hours on this box). Cheers, Randall