{"thread":{"id":"9982","subject":"git-send-email is omitting author and date lines","startedAt":"2007-09-23T22:13:53Z","lastAt":"2007-09-24T18:43:29Z","messageCount":9,"participants":["Hanspeter Kunz","Junio C Hamano","Johannes Schindelin","martin f krafft"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"53860","messageId":"1190585633.29937.44.camel@localhost","threadId":"9982","inReplyTo":null,"subject":"git-send-email is omitting author and date lines","fromName":"Hanspeter Kunz","fromEmail":"hp@edelkunz.ch","sentAt":"2007-09-23T22:13:53Z","receivedAt":"2007-09-23T22:13:53Z","isPatch":false,"sender":{"key":"hp@edelkunz.ch","avatar":null},"body":"Hi,\n\nsorry if this is a stupid question, but I'm new to git.\n\nWhen sending a patch to myself using `git-send-email` I realized that\nthe lines containing the author and the date (lines 5 and 6 in the patch\nfile) were not in the sent email.\n\nIs this on purpose? And if so, why?\n\nThanks,\nHp.\n"},{"id":"53871","messageId":"7v4phlc668.fsf@gitster.siamese.dyndns.org","threadId":"9982","inReplyTo":"1190585633.29937.44.camel@localhost","subject":"Re: git-send-email is omitting author and date lines","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-09-23T23:29:03Z","receivedAt":"2007-09-23T23:29:03Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Hanspeter Kunz writes:\n\n> When sending a patch to myself using `git-send-email` I realized that\n> the lines containing the author and the date (lines 5 and 6 in the patch\n> file) were not in the sent email.\n\nWas the commit authored by yourself?\n"},{"id":"53872","messageId":"1190590538.12557.1.camel@localhost","threadId":"9982","inReplyTo":"7v4phlc668.fsf@gitster.siamese.dyndns.org","subject":"Re: git-send-email is omitting author and date lines","fromName":"Hanspeter Kunz","fromEmail":"hp@edelkunz.ch","sentAt":"2007-09-23T23:35:38Z","receivedAt":"2007-09-23T23:35:38Z","isPatch":false,"sender":{"key":"hp@edelkunz.ch","avatar":null},"body":"On Sun, 2007-09-23 at 16:29 -0700, Junio C Hamano wrote:\n> Hanspeter Kunz writes:\n> \n> > When sending a patch to myself using `git-send-email` I realized that\n> > the lines containing the author and the date (lines 5 and 6 in the patch\n> > file) were not in the sent email.\n> \n> Was the commit authored by yourself?\n\nyes. does this make a difference?\n"},{"id":"53880","messageId":"Pine.LNX.4.64.0709240129450.28395@racer.site","threadId":"9982","inReplyTo":"1190590538.12557.1.camel@localhost","subject":"Re: git-send-email is omitting author and date lines","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-09-24T00:30:46Z","receivedAt":"2007-09-24T00:30:46Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 24 Sep 2007, Hanspeter Kunz wrote:\n\n> On Sun, 2007-09-23 at 16:29 -0700, Junio C Hamano wrote:\n> > Hanspeter Kunz writes:\n> > \n> > > When sending a patch to myself using `git-send-email` I realized that\n> > > the lines containing the author and the date (lines 5 and 6 in the patch\n> > > file) were not in the sent email.\n> > \n> > Was the commit authored by yourself?\n> \n> yes. does this make a difference?\n\nYes, it does. The author is usually inferred from the sender of the mail, \nand therefore git-send-email strips that information from the message \n(IIRC).\n\nHth,\nDscho\n"},{"id":"53895","messageId":"1190618182.6916.1.camel@localhost","threadId":"9982","inReplyTo":"Pine.LNX.4.64.0709240129450.28395@racer.site","subject":"Re: git-send-email is omitting author and date lines","fromName":"Hanspeter Kunz","fromEmail":"hp@edelkunz.ch","sentAt":"2007-09-24T07:16:22Z","receivedAt":"2007-09-24T07:16:22Z","isPatch":false,"sender":{"key":"hp@edelkunz.ch","avatar":null},"body":"On Mon, 2007-09-24 at 01:30 +0100, Johannes Schindelin wrote:\n> Hi,\n> \n> On Mon, 24 Sep 2007, Hanspeter Kunz wrote:\n> \n> > On Sun, 2007-09-23 at 16:29 -0700, Junio C Hamano wrote:\n> > > Hanspeter Kunz writes:\n> > > \n> > > > When sending a patch to myself using `git-send-email` I realized that\n> > > > the lines containing the author and the date (lines 5 and 6 in the patch\n> > > > file) were not in the sent email.\n> > > \n> > > Was the commit authored by yourself?\n> > \n> > yes. does this make a difference?\n> \n> Yes, it does. The author is usually inferred from the sender of the mail, \n> and therefore git-send-email strips that information from the message \n> (IIRC).\n\nAh, I see. And this applies also to the date, I guess.\n\nMany thanks,\nHp.\n"},{"id":"53908","messageId":"20070924110817.GA15797@lapse.madduck.net","threadId":"9982","inReplyTo":"7v4phlc668.fsf@gitster.siamese.dyndns.org","subject":"Re: git-send-email is omitting author and date lines","fromName":"martin f krafft","fromEmail":"madduck@madduck.net","sentAt":"2007-09-24T11:08:17Z","receivedAt":"2007-09-24T11:08:17Z","isPatch":false,"sender":{"key":"madduck@madduck.net","avatar":null},"body":"also sprach Junio C Hamano [2007.09.24.0029 +0100]:\n> Was the commit authored by yourself?\n\nSorry for barking in here, but Hanspeter tried to submit a patch to\nme and that's when this issue arose.\n\nYes, he is the author of the commit, as in: user.name and user.email\nare the same for the commit and for the email, and this seems to be\nthe reason the commit header is left out of the email, causing\ngit-am to use the RFC822 From header instead:\n\n - patch by Jane, email sent From Jane: no separate From header\n - patch by Jane, email sent From Joe: separate From Jane header \n\nBut information *does* get lost, namely the date. If I send a patch\nby email and it gets merged by the recipient, the date of the commit\nwill be the date of the email, not the date of original commit, or\nwhen it was merged.\n\nTo be honest, I have no real preference on this, but it just seems\nstrange that out of three dates:\n\n - original commit\n - email sent\n - commit merged\n\ngit-send-email/git-am cause the second to be used, which is the\none that makes the *least* sense IMHO.\n\n-- \nmartin; (greetings from the heart of the sun.)\n \\____ echo mailto: !#^.\"<*>\"|tr \"<*> mailto:\" net@madduck\n \n\"i dislike arguments of any kind. they are always vulgar, and often\n convincing.\"\n -- oscar wilde\n \nspamtraps: madduck.bogus@madduck.net\n"},{"id":"53909","messageId":"Pine.LNX.4.64.0709241209470.28395@racer.site","threadId":"9982","inReplyTo":"20070924110817.GA15797@lapse.madduck.net","subject":"Re: git-send-email is omitting author and date lines","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-09-24T11:10:20Z","receivedAt":"2007-09-24T11:10:20Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 24 Sep 2007, martin f krafft wrote:\n\n> But information *does* get lost, namely the date. If I send a patch\n> by email and it gets merged by the recipient, the date of the commit\n> will be the date of the email, not the date of original commit, or\n> when it was merged.\n\nAnd that is perfectly okay, since as far as the public is concerned, this \nis the date of the patch.\n\nCiao,\nDscho\n"},{"id":"53936","messageId":"20070924173014.GB27816@lapse.madduck.net","threadId":"9982","inReplyTo":"Pine.LNX.4.64.0709241209470.28395@racer.site","subject":"Re: git-send-email is omitting author and date lines","fromName":"martin f krafft","fromEmail":"madduck@madduck.net","sentAt":"2007-09-24T17:30:14Z","receivedAt":"2007-09-24T17:30:14Z","isPatch":false,"sender":{"key":"madduck@madduck.net","avatar":null},"body":"also sprach Johannes Schindelin [2007.09.24.1210 +0100]:\n> And that is perfectly okay, since as far as the public is\n> concerned, this is the date of the patch.\n\nIf you say so. I don't find this at all convincing.\n\n-- \nmartin; (greetings from the heart of the sun.)\n \\____ echo mailto: !#^.\"<*>\"|tr \"<*> mailto:\" net@madduck\n \n\"if i am occasionally a little overdressed, i make up for it by being\n always immensely over-educated.\"\n -- oscar wilde\n \nspamtraps: madduck.bogus@madduck.net\n"},{"id":"53941","messageId":"7vodfraoq6.fsf@gitster.siamese.dyndns.org","threadId":"9982","inReplyTo":"20070924173014.GB27816@lapse.madduck.net","subject":"Re: git-send-email is omitting author and date lines","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-09-24T18:43:29Z","receivedAt":"2007-09-24T18:43:29Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"martin f krafft writes:\n\n> also sprach Johannes Schindelin [2007.09.24.1210 +0100]:\n>> And that is perfectly okay, since as far as the public is\n>> concerned, this is the date of the patch.\n>\n> If you say so. I don't find this at all convincing.\n\nI think that is the reasoning for the current behaviour of\nsend-email, but it is not unreasonable to have an option to\nalways add in-body From: and Date: headers to send-email, with a\nblessing from a recent post from Linus to the kernel mailing\nlist:\n\n\thttp://article.gmane.org/gmane.linux.kernel/582450\n\nNotice the part he says he appreciates Andrew's practice and\ntalks about message being further forwarded by somebody else.\n"}]}