{"thread":{"id":"9972","subject":"GIT_PAGER=cat git-svn log --> Illegal seek","startedAt":"2007-09-21T23:40:39Z","lastAt":"2007-09-22T01:48:45Z","messageCount":2,"participants":["Chris Moore","Eric Wong"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"53762","messageId":"a9691ee20709211640q63881718k75ebf416bf5e217f@mail.gmail.com","threadId":"9972","inReplyTo":null,"subject":"GIT_PAGER=cat git-svn log --> Illegal seek","fromName":"Chris Moore","fromEmail":"christopher.ian.moore@gmail.com","sentAt":"2007-09-21T23:40:39Z","receivedAt":"2007-09-21T23:40:39Z","isPatch":false,"sender":{"key":"christopher.ian.moore@gmail.com","avatar":null},"body":"I run my git commands inside an Emacs *shell* buffer, so I don't want\nit running 'less' all the time.  I export GIT_PAGER=cat to stop it.\n\nI just tried a \"git-svn log\" and it failed:\n\n$ GIT_PAGER=cat git-svn log\nUse of uninitialized value in exec at /usr/bin/git-svn line 3451.\nUse of uninitialized value in concatenation (.) or string at\n/usr/bin/git-svn line 3451.\nCan't run pager: Illegal seek ()\n\nI don't get a shell prompt back.  It just hangs.\n\nThis is on ubuntu feisty with the ubuntu-backport repositories enabled:\n\nii  git-core                                     1.5.2.5-2~feisty1\nii  git-svn                                      1.5.2.5-2~feisty1\n"},{"id":"53780","messageId":"20070922014845.GA8087@mayonaise","threadId":"9972","inReplyTo":"a9691ee20709211640q63881718k75ebf416bf5e217f@mail.gmail.com","subject":"[PATCH] git-svn: don't attempt to spawn pager if we don't want one","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2007-09-22T01:48:45Z","receivedAt":"2007-09-22T01:48:45Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Even though config_pager() unset the $pager variable, we were\nblindly calling exec() on it through run_pager().\n\nNoticed-by: Chris Moore <christopher.ian.moore@gmail.com>\nSigned-off-by: Eric Wong <normalperson@yhbt.net>\n---\n\n  Chris Moore <christopher.ian.moore@gmail.com> wrote:\n  > I run my git commands inside an Emacs *shell* buffer, so I don't want\n  > it running 'less' all the time.  I export GIT_PAGER=cat to stop it.\n  > \n  > I just tried a \"git-svn log\" and it failed:\n  > \n  > $ GIT_PAGER=cat git-svn log\n  > Use of uninitialized value in exec at /usr/bin/git-svn line 3451.\n  > Use of uninitialized value in concatenation (.) or string at\n  > /usr/bin/git-svn line 3451.\n  > Can't run pager: Illegal seek ()\n  > \n  > I don't get a shell prompt back.  It just hangs.\n  > \n  > This is on ubuntu feisty with the ubuntu-backport repositories enabled:\n  > \n  > ii  git-core                                     1.5.2.5-2~feisty1\n  > ii  git-svn                                      1.5.2.5-2~feisty1\n\n git-svn.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-svn.perl b/git-svn.perl\nindex 288d32c..484b057 100755\n--- a/git-svn.perl\n+++ b/git-svn.perl\n@@ -3578,7 +3578,7 @@ sub config_pager {\n }\n \n sub run_pager {\n-\treturn unless -t *STDOUT;\n+\treturn unless -t *STDOUT && defined $pager;\n \tpipe my $rfd, my $wfd or return;\n \tdefined(my $pid = fork) or ::fatal \"Can't fork: $!\\n\";\n \tif (!$pid) {\n-- \nEric Wong\n"}]}