{"thread":{"id":"9965","subject":"[PATCH 0/5] gitweb: Fixes and improvements related to diffs","startedAt":"2007-09-21T21:31:14Z","lastAt":"2007-09-25T22:21:20Z","messageCount":3,"participants":["Jakub Narebski","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":5},"messages":[{"id":"53753","messageId":"8fe92b430709211431m7a93a11cp915988a57801edd6@mail.gmail.com","threadId":"9965","inReplyTo":null,"subject":"[PATCH 0/5] gitweb: Fixes and improvements related to diffs","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-09-21T21:31:14Z","receivedAt":"2007-09-21T21:31:14Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"This series of patches adds fixes, simplifications and improvements\nrelated to diff handling in gitweb ('commit', 'commitdiff' views).\n\nBecaus I didn't have access to Internet, this series is based\non 1e61b7640d09015213dbcae3564fa27ac6a8c151 (v1.5.3.1-1-g1e61b76).\nAs I am sending it via GMail WWW interface, patches are send as\nattachements.\n\nI send this series now, even without good Internet access,\nbecause it contains two bugfixes, and one code fix. I'll try to\nresend it rebase on top of current master later...\n\nShortlog:\n=========\nJakub Narebski (5):\n      gitweb: Remove parse_from_to_diffinfo code from git_patchset_body\n      gitweb: No difftree output for trivial merge\n      gitweb: Fix and simplify \"split patch\" detection\n      gitweb: Always set 'from_file' and 'to_file' in parse_difftree_raw_line\n      gitweb: Add 'status_str' to parse_difftree_raw_line output\n\nDiffstat:\n=========\n gitweb/gitweb.perl |  208 ++++++++++++++++++++--------------------------------\n 1 files changed, 80 insertions(+), 128 deletions(-)\n\n-- \nJakub Narebski\nPoland\n"},{"id":"54049","messageId":"7vodfq4ch0.fsf@gitster.siamese.dyndns.org","threadId":"9965","inReplyTo":"8fe92b430709211431m7a93a11cp915988a57801edd6@mail.gmail.com","subject":"Re: [PATCH 0/5] gitweb: Fixes and improvements related to diffs","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-09-25T22:16:59Z","receivedAt":"2007-09-25T22:16:59Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Jakub Narebski\" <jnareb@gmail.com> writes:\n\n> This series of patches adds fixes, simplifications and improvements\n> related to diff handling in gitweb ('commit', 'commitdiff' views).\n>\n> Becaus I didn't have access to Internet, this series is based\n> on 1e61b7640d09015213dbcae3564fa27ac6a8c151 (v1.5.3.1-1-g1e61b76).\n> As I am sending it via GMail WWW interface, patches are send as\n> attachements.\n>\n> I send this series now, even without good Internet access,\n> because it contains two bugfixes, and one code fix. I'll try to\n> resend it rebase on top of current master later...\n\nI've parked the first two in 'master' and was hoping to roll\nthem into 'maint'.  I haven't taken a look at the other three as\nI was waiting for a resend.  If you think some of them are\nbugfix material for 'maint', please mark them as such.\n\nThanks.\n"},{"id":"54050","messageId":"8fe92b430709251521j2b596016l186bdbb08c6cf816@mail.gmail.com","threadId":"9965","inReplyTo":"7vodfq4ch0.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH 0/5] gitweb: Fixes and improvements related to diffs","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-09-25T22:21:20Z","receivedAt":"2007-09-25T22:21:20Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"On 9/26/07, Junio C Hamano <gitster@pobox.com> wrote:\n> \"Jakub Narebski\" <jnareb@gmail.com> writes:\n>\n> > This series of patches adds fixes, simplifications and improvements\n> > related to diff handling in gitweb ('commit', 'commitdiff' views).\n> >\n> > Becaus I didn't have access to Internet, this series is based\n> > on 1e61b7640d09015213dbcae3564fa27ac6a8c151 (v1.5.3.1-1-g1e61b76).\n> > As I am sending it via GMail WWW interface, patches are send as\n> > attachements.\n> >\n> > I send this series now, even without good Internet access,\n> > because it contains two bugfixes, and one code fix. I'll try to\n> > resend it rebase on top of current master later...\n>\n> I've parked the first two in 'master' and was hoping to roll\n> them into 'maint'.  I haven't taken a look at the other three as\n> I was waiting for a resend.  If you think some of them are\n> bugfix material for 'maint', please mark them as such.\n\nThird fixes a rare bug when gitweb screwed up names of files\nin the patchset part of commitdiff view. This took place only\n(diagnosed by pasky) when there were different files which\nhad the same preimage and the same postimage.\n\n-- \nJakub Narebski\n"}]}