{"thread":{"id":"9919","subject":"git-fsck/lost-found's speed vs git-prune's","startedAt":"2007-09-18T09:09:26Z","lastAt":"2007-09-18T11:13:14Z","messageCount":5,"participants":["Mike Hommey","Sam Vilain","Junio C Hamano","Johannes Schindelin"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"53427","messageId":"20070918090926.GA8927@glandium.org","threadId":"9919","inReplyTo":null,"subject":"git-fsck/lost-found's speed vs git-prune's","fromName":"Mike Hommey","fromEmail":"mh@glandium.org","sentAt":"2007-09-18T09:09:26Z","receivedAt":"2007-09-18T09:09:26Z","isPatch":false,"sender":{"key":"mh@glandium.org","avatar":"https://avatars.githubusercontent.com/u/1038527?v=4"},"body":"Hi,\n\nI was wondering if that was to be expected for git-fsck to be\nsignificantly slower than git-prune (by several orders of magnitude) ?\n\n$ time git-lost-found\n\nreal    8m22.167s\nuser    6m44.153s\nsys     1m16.613s\n\n$ time git-prune\n\nreal    0m0.376s\nuser    0m0.304s\nsys     0m0.000s\n\nMike\n"},{"id":"53429","messageId":"46EF96FD.1050602@vilain.net","threadId":"9919","inReplyTo":"20070918090926.GA8927@glandium.org","subject":"Re: git-fsck/lost-found's speed vs git-prune's","fromName":"Sam Vilain","fromEmail":"sam@vilain.net","sentAt":"2007-09-18T09:14:37Z","receivedAt":"2007-09-18T09:14:37Z","isPatch":false,"sender":{"key":"sam@vilain.net","avatar":"https://gravatar.com/avatar/8fc840ca854dbf6f7065b4335e3b934951c1dca3b11db688e95e471901f8f4a8?d=mp&s=160"},"body":"Mike Hommey wrote:\n> Hi,\n>\n> I was wondering if that was to be expected for git-fsck to be\n> significantly slower than git-prune (by several orders of magnitude) ?\n>\n> $ time git-lost-found\n>\n> real    8m22.167s\n> user    6m44.153s\n> sys     1m16.613s\n>\n> $ time git-prune\n>\n> real    0m0.376s\n> user    0m0.304s\n> sys     0m0.000s\n>   \n\nYou're probably already packed. I'd expect a similar speed difference\nbetween git-fsck and git-fsck --full.\n\nSam.\n"},{"id":"53432","messageId":"7v4phswcuj.fsf@gitster.siamese.dyndns.org","threadId":"9919","inReplyTo":"20070918090926.GA8927@glandium.org","subject":"Re: git-fsck/lost-found's speed vs git-prune's","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-09-18T09:18:44Z","receivedAt":"2007-09-18T09:18:44Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Mike Hommey <mh@glandium.org> writes:\n\n> I was wondering if that was to be expected for git-fsck to be\n> significantly slower than git-prune (by several orders of magnitude) ?\n\nfsck validates objects are correct and sane.  prune only looks\nat reachability.\n"},{"id":"53435","messageId":"20070918095049.GA9388@glandium.org","threadId":"9919","inReplyTo":"7v4phswcuj.fsf@gitster.siamese.dyndns.org","subject":"Re: git-fsck/lost-found's speed vs git-prune's","fromName":"Mike Hommey","fromEmail":"mh@glandium.org","sentAt":"2007-09-18T09:50:49Z","receivedAt":"2007-09-18T09:50:49Z","isPatch":false,"sender":{"key":"mh@glandium.org","avatar":"https://avatars.githubusercontent.com/u/1038527?v=4"},"body":"On Tue, Sep 18, 2007 at 02:18:44AM -0700, Junio C Hamano <gitster@pobox.com> wrote:\n> Mike Hommey <mh@glandium.org> writes:\n> \n> > I was wondering if that was to be expected for git-fsck to be\n> > significantly slower than git-prune (by several orders of magnitude) ?\n> \n> fsck validates objects are correct and sane.  prune only looks\n> at reachability.\n\nNow, the speed difference makes sense, but I wouldn't expect lost-found\nto actually bother validating objects...\n\nMike\n"},{"id":"53447","messageId":"Pine.LNX.4.64.0709181211560.28586@racer.site","threadId":"9919","inReplyTo":"20070918095049.GA9388@glandium.org","subject":"Re: git-fsck/lost-found's speed vs git-prune's","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-09-18T11:13:14Z","receivedAt":"2007-09-18T11:13:14Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Tue, 18 Sep 2007, Mike Hommey wrote:\n\n> On Tue, Sep 18, 2007 at 02:18:44AM -0700, Junio C Hamano <gitster@pobox.com> wrote:\n> > Mike Hommey <mh@glandium.org> writes:\n> > \n> > > I was wondering if that was to be expected for git-fsck to be\n> > > significantly slower than git-prune (by several orders of magnitude) ?\n> > \n> > fsck validates objects are correct and sane.  prune only looks\n> > at reachability.\n> \n> Now, the speed difference makes sense, but I wouldn't expect lost-found\n> to actually bother validating objects...\n\nThat's why we should get rid of lost-found, and only keep the --lost-found \noption to git-fsck, to make it clear.\n\nAnd I think that it is too rare that you lost objects and want to find \nthem, to warrant a fast version of it.\n\nCiao,\nDscho\n"}]}