{"thread":{"id":"9898","subject":"[EGIT PATCH] Add feature and plugin.","startedAt":"2007-09-17T18:53:11Z","lastAt":"2007-09-18T21:20:16Z","messageCount":4,"participants":["Ben Konrath","Andreas Ericsson","Robin Rosenberg"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"53338","messageId":"20070917185310.GA6042@toast.toronto.redhat.com","threadId":"9898","inReplyTo":null,"subject":"[EGIT PATCH] Add feature and plugin.","fromName":"Ben Konrath","fromEmail":"bkonrath@redhat.com","sentAt":"2007-09-17T18:53:11Z","receivedAt":"2007-09-17T18:53:11Z","isPatch":true,"sender":{"key":"bkonrath@redhat.com","avatar":null},"body":"Hi,\n\nI made a feature and associated branding plugin for Egit. Including\nthese two plugins allows us to build Egit for Fedora but it also makes\nit easy to create an update site for Egit. These two plugins also add an\nentry for Egit in Help -> About Eclipse -> Feature Details. \n\nThis is an updated version of the patch that I originally sent privately to \nRobin Rosenberg. Comments are appreciated.\n\nCheers, Ben\n\nSigned-off-by: Ben Konrath \n\n---\n org.spearce.egit-feature/.project | 17 +++++++++\n org.spearce.egit-feature/build.properties | 1 +\n org.spearce.egit-feature/feature.xml | 51 +++++++++++++++++++++++++++++\n org.spearce.egit/.classpath | 6 +++\n org.spearce.egit/.project | 28 ++++++++++++++++\n org.spearce.egit/META-INF/MANIFEST.MF | 7 ++++\n org.spearce.egit/about.ini | 28 ++++++++++++++++\n org.spearce.egit/build.properties | 3 ++\n org.spearce.egit/egit.png | Bin 0 -> 226 bytes\n 9 files changed, 141 insertions(+), 0 deletions(-)\n create mode 100644 org.spearce.egit-feature/.project\n create mode 100644 org.spearce.egit-feature/build.properties\n create mode 100644 org.spearce.egit-feature/feature.xml\n create mode 100644 org.spearce.egit/.classpath\n create mode 100644 org.spearce.egit/.project\n create mode 100644 org.spearce.egit/META-INF/MANIFEST.MF\n create mode 100644 org.spearce.egit/about.ini\n create mode 100644 org.spearce.egit/build.properties\n create mode 100644 org.spearce.egit/egit.png\n\ndiff --git a/org.spearce.egit-feature/.project b/org.spearce.egit-feature/.project\nnew file mode 100644\nindex 0000000..dac8f65\n--- /dev/null\n+++ b/org.spearce.egit-feature/.project\n@@ -0,0 +1,17 @@\n+\n+\n+\torg.spearce.egit-feature\n+\t\n+\t\n+\t\n+\t\n+\t\t\n+\t\t\torg.eclipse.pde.FeatureBuilder\n+\t\t\t\n+\t\t\t\n+\t\t\n+\t\n+\t\n+\t\torg.eclipse.pde.FeatureNature\n+\t\n+\ndiff --git a/org.spearce.egit-feature/build.properties b/org.spearce.egit-feature/build.properties\nnew file mode 100644\nindex 0000000..64f93a9\n--- /dev/null\n+++ b/org.spearce.egit-feature/build.properties\n@@ -0,0 +1 @@\n+bin.includes = feature.xml\ndiff --git a/org.spearce.egit-feature/feature.xml b/org.spearce.egit-feature/feature.xml\nnew file mode 100644\nindex 0000000..8c98143\n--- /dev/null\n+++ b/org.spearce.egit-feature/feature.xml\n@@ -0,0 +1,51 @@\n+\n+\n+\n+ \n+ \n+ \n+ \n+ \n+ \n+ \n+ \n+ \n+ \n+ \n+ \n+ \n+\n+ \n+\n+ \n+\n+ \n+\n+ \n+\n+\ndiff --git a/org.spearce.egit/.classpath b/org.spearce.egit/.classpath\nnew file mode 100644\nindex 0000000..acad1c2\n--- /dev/null\n+++ b/org.spearce.egit/.classpath\n@@ -0,0 +1,6 @@\n+\n+\n+\t\n+\t\n+\t\n+\ndiff --git a/org.spearce.egit/.project b/org.spearce.egit/.project\nnew file mode 100644\nindex 0000000..bbdc4e3\n--- /dev/null\n+++ b/org.spearce.egit/.project\n@@ -0,0 +1,28 @@\n+\n+\n+\torg.spearce.egit\n+\t\n+\t\n+\t\n+\t\n+\t\t\n+\t\t\torg.eclipse.jdt.core.javabuilder\n+\t\t\t\n+\t\t\t\n+\t\t\n+\t\t\n+\t\t\torg.eclipse.pde.ManifestBuilder\n+\t\t\t\n+\t\t\t\n+\t\t\n+\t\t\n+\t\t\torg.eclipse.pde.SchemaBuilder\n+\t\t\t\n+\t\t\t\n+\t\t\n+\t\n+\t\n+\t\torg.eclipse.pde.PluginNature\n+\t\torg.eclipse.jdt.core.javanature\n+\t\n+\ndiff --git a/org.spearce.egit/META-INF/MANIFEST.MF b/org.spearce.egit/META-INF/MANIFEST.MF\nnew file mode 100644\nindex 0000000..40da4e0\n--- /dev/null\n+++ b/org.spearce.egit/META-INF/MANIFEST.MF\n@@ -0,0 +1,7 @@\n+Manifest-Version: 1.0\n+Bundle-ManifestVersion: 2\n+Bundle-Name: Java Git / Eclipse Git\n+Bundle-SymbolicName: org.spearce.egit\n+Bundle-Version: 0.2.2\n+Bundle-Vendor: spearce.org\n+Bundle-RequiredExecutionEnvironment: J2SE-1.5\ndiff --git a/org.spearce.egit/about.ini b/org.spearce.egit/about.ini\nnew file mode 100644\nindex 0000000..dcab31a\n--- /dev/null\n+++ b/org.spearce.egit/about.ini\n@@ -0,0 +1,28 @@\n+# about.ini\n+# contains information about a feature\n+# java.io.Properties file (ISO 8859-1 with \"\\\" escapes)\n+# \"%key\" are externalized strings defined in about.properties\n+# This file does not need to be translated.\n+\n+# Property \"aboutText\" contains blurb for \"About\" dialog (translated)\n+aboutText=Java Git / Eclipse Git (by Shawn Pearce) is a Java Git library and plugin for the Eclipse IDE.\n+\n+# Property \"windowImage\" contains path to window icon (16x16)\n+# needed for primary features only\n+\n+# Property \"featureImage\" contains path to feature image (32x32)\n+featureImage=egit.png\n+\n+# Property \"aboutImage\" contains path to product image (500x330 or 115x164)\n+# needed for primary features only\n+\n+# Property \"appName\" contains name of the application (not translated)\n+# needed for primary features only\n+\n+# Property \"welcomePerspective\" contains the id of the perspective in which the\n+# welcome page is to be opened.\n+# optional\n+\n+# Property \"tipsAndTricksHref\" contains the Help topic href to a tips and tricks page \n+# optional\n+# tipsAndTricksHref=/org.eclipse.jdt.doc.user/tips/jdt_tips.html\n\\ No newline at end of file\ndiff --git a/org.spearce.egit/build.properties b/org.spearce.egit/build.properties\nnew file mode 100644\nindex 0000000..22d4e45\n--- /dev/null\n+++ b/org.spearce.egit/build.properties\n@@ -0,0 +1,3 @@\n+bin.includes = META-INF/,\\\n+ egit.png,\\\n+ about.ini\ndiff --git a/org.spearce.egit/egit.png b/org.spearce.egit/egit.png\nnew file mode 100644\nindex 0000000000000000000000000000000000000000..6782d4ab9b757aaa2c3d5edad42215ea02456836\nGIT binary patch\nliteral 226\nzc%17D@N?(olHy`uVBq!ia0vp^3LwnE1SJ1Ryj={WI14-?iy0XB6G519h5hnOpdfpR\nzr>`sfbxuJ+YqhJ4<#s?J*%H@?66gHf+|;}h2Ir#G#FEq$h4Rdj426)4R0VfW-+=ci\nzs(C<#5uPrNAs)xyPT9%JpuoeNd?c=?O``XtkE8f5g?WeG?ReJX!Qg2@=JYD@<);T3K0RS$@N4)?5\n\nliteral 0\nHc$@ Hi,\n> \n> I made a feature and associated branding plugin for Egit. Including\n> these two plugins allows us to build Egit for Fedora but it also makes\n> it easy to create an update site for Egit.\n\n\n\n> These two plugins also add an\n> entry for Egit in Help -> About Eclipse -> Feature Details. \n> \n\nWhen you start writing \"also\" in your commit messages, it's a pretty good\nsign that you should have made many smaller commits rathern than one large.\n\nAside from that, I don't know enough about eclipse, java or xml to be of\nany assistance, although I appreciate the efforts put into this.\n\n-- \nAndreas Ericsson andreas.ericsson@op5.se\nOP5 AB www.op5.se\nTel: +46 8-230225 Fax: +46 8-230231\n"},{"id":"53499","messageId":"200709182106.46649.robin.rosenberg.lists@dewire.com","threadId":"9898","inReplyTo":"46EF81BD.7010609@op5.se","subject":"Re: [EGIT PATCH] Add feature and plugin.","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg.lists@dewire.com","sentAt":"2007-09-18T19:06:46Z","receivedAt":"2007-09-18T19:06:46Z","isPatch":true,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"tisdag 18 september 2007 skrev Andreas Ericsson:\n> Ben Konrath wrote:\n> > Hi,\n> > \n> > I made a feature and associated branding plugin for Egit. Including\n> > these two plugins allows us to build Egit for Fedora but it also makes\n> > it easy to create an update site for Egit.\n> \n> \n> \n> > These two plugins also add an\n> > entry for Egit in Help -> About Eclipse -> Feature Details. \n> > \n> \n> When you start writing \"also\" in your commit messages, it's a pretty good\n> sign that you should have made many smaller commits rathern than one large.\n\nSeems it is a hint about what can be done later. That's generally something to\nput in cover messages. \n\nThe ability to create an update site encouraged me to create one too. It makes\nupdating all my eclipses much easier. Thanks Ben.\n\nI've merged and pushed the earlier version before receiving this version whose\ncontent comes as a follow up commit.\n\n-- robin\n"},{"id":"53504","messageId":"1190150416.21540.0.camel@plug","threadId":"9898","inReplyTo":"46EF81BD.7010609@op5.se","subject":"Re: [EGIT PATCH] Add feature and plugin.","fromName":"Ben Konrath","fromEmail":"bkonrath@redhat.com","sentAt":"2007-09-18T21:20:16Z","receivedAt":"2007-09-18T21:20:16Z","isPatch":true,"sender":{"key":"bkonrath@redhat.com","avatar":null},"body":"On Tue, 2007-09-18 at 09:43 +0200, Andreas Ericsson wrote:\n> Ben Konrath wrote:\n> > Hi,\n> > \n> > I made a feature and associated branding plugin for Egit. Including\n> > these two plugins allows us to build Egit for Fedora but it also makes\n> > it easy to create an update site for Egit.\n> \n> \n> \n> > These two plugins also add an\n> > entry for Egit in Help -> About Eclipse -> Feature Details. \n> > \n> \n> When you start writing \"also\" in your commit messages, it's a pretty good\n> sign that you should have made many smaller commits rathern than one large.\n\nOk thanks. I think that I could have split this up into two commits.\nI'll take that into consideration for future work.\n\nCheers, Ben\n"}]}