{"thread":{"id":"9789","subject":"[PATCH 3/3] Makefile: Add cache-tree.h to the public headers list","startedAt":"2007-09-05T23:22:51Z","lastAt":"2007-09-06T00:37:29Z","messageCount":3,"participants":["Dmitry V. Levin","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":3},"messages":[{"id":"52647","messageId":"20070905232251.GC331@nomad.office.altlinux.org","threadId":"9789","inReplyTo":null,"subject":"[PATCH 3/3] Makefile: Add cache-tree.h to the public headers list","fromName":"Dmitry V. Levin","fromEmail":"ldv@altlinux.org","sentAt":"2007-09-05T23:22:51Z","receivedAt":"2007-09-05T23:22:51Z","isPatch":true,"sender":{"key":"ldv@altlinux.org","avatar":"https://avatars.githubusercontent.com/u/5281408?v=4"},"body":"Some external projects (e.g. parsecvs) need cache-tree.h file.\n\nSigned-off-by: Dmitry V. Levin <ldv@altlinux.org>\n---\n Makefile |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex d50e30b..2b04829 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -283,7 +283,7 @@ LIB_FILE=libgit.a\n XDIFF_LIB=xdiff/lib.a\n \n LIB_H = \\\n-\tarchive.h blob.h cache.h commit.h csum-file.h delta.h grep.h \\\n+\tarchive.h blob.h cache.h cache-tree.h commit.h csum-file.h delta.h grep.h \\\n \tdiff.h object.h pack.h pkt-line.h quote.h refs.h list-objects.h sideband.h \\\n \trun-command.h strbuf.h tag.h tree.h git-compat-util.h revision.h \\\n \ttree-walk.h log-tree.h dir.h path-list.h unpack-trees.h builtin.h \\\n-- \nldv\n"},{"id":"52651","messageId":"7vy7fkfy1c.fsf@gitster.siamese.dyndns.org","threadId":"9789","inReplyTo":"20070905232251.GC331@nomad.office.altlinux.org","subject":"Re: [PATCH 3/3] Makefile: Add cache-tree.h to the public headers list","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-09-06T00:16:47Z","receivedAt":"2007-09-06T00:16:47Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Dmitry V. Levin\" <ldv@altlinux.org> writes:\n\n> Some external projects (e.g. parsecvs) need cache-tree.h file.\n\nYour patch shows that our Makefile has been lacking a necessary\ndependency for a long time.  LIB_H is not \"public headers list\",\nbut more like \"the headers everybody depends on\", and the header\nfile should have been on that list.  Thanks.\n\nI am however not convinced it is a good idea to treat libgit.a\nas if it is a library.  It is not a library in the usual sense\nof the word.  Originally we did libgit.a primarily so that we do\nnot have to list all the *.o dependencies in the Makefile out of\nlaziness ;-)\n"},{"id":"52662","messageId":"20070906003729.GB23887@basalt.office.altlinux.org","threadId":"9789","inReplyTo":"7vy7fkfy1c.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH 3/3] Makefile: Add cache-tree.h to the public headers list","fromName":"Dmitry V. Levin","fromEmail":"ldv@altlinux.org","sentAt":"2007-09-06T00:37:29Z","receivedAt":"2007-09-06T00:37:29Z","isPatch":true,"sender":{"key":"ldv@altlinux.org","avatar":"https://avatars.githubusercontent.com/u/5281408?v=4"},"body":"On Wed, Sep 05, 2007 at 05:16:47PM -0700, Junio C Hamano wrote:\n[...]\n> I am however not convinced it is a good idea to treat libgit.a\n> as if it is a library.\n> It is not a library in the usual sense of the word.\n\nI'd certainly prefer libgit.so with stable interface instead, but\nparsecvs needs -lgit now, it cannot wait for \"good library\".\n\n\n-- \nldv\n"}]}