{"thread":{"id":"9752","subject":"gitk fails to parse git log output in 1.5.3","startedAt":"2007-09-02T22:31:28Z","lastAt":"2007-09-03T01:25:27Z","messageCount":3,"participants":["Jing Xue","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"52267","messageId":"20070902223128.GA19198@falcon.digizenstudio.com","threadId":"9752","inReplyTo":null,"subject":"gitk fails to parse git log output in 1.5.3","fromName":"Jing Xue","fromEmail":"jingxue@digizenstudio.com","sentAt":"2007-09-02T22:31:28Z","receivedAt":"2007-09-02T22:31:28Z","isPatch":false,"sender":{"key":"jingxue@digizenstudio.com","avatar":null},"body":"gitk shows an error \"Can't parse git log output: {\\x1b[33commit...\" at\nstartup and quits.\n\nObviously it's because my git-log outputs in color mode. But the same\nhappens (and git-log still outputs in colors) after I set color.pager=false. \n\nWhat am I missing?\n\nThanks.\n-- \nJing Xue\n"},{"id":"52272","messageId":"7vzm04odze.fsf@gitster.siamese.dyndns.org","threadId":"9752","inReplyTo":"20070902223128.GA19198@falcon.digizenstudio.com","subject":"Re: gitk fails to parse git log output in 1.5.3","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-09-02T23:16:05Z","receivedAt":"2007-09-02T23:16:05Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jing Xue <jingxue@digizenstudio.com> writes:\n\n> gitk shows an error \"Can't parse git log output: {\\x1b[33commit...\" at\n> startup and quits.\n>\n> Obviously it's because my git-log outputs in color mode. But the same\n> happens (and git-log still outputs in colors) after I set color.pager=false. \n>\n> What am I missing?\n\nThis will quickly turn into an FAQ.\n\nPlease see:\n\n\thttp://thread.gmane.org/gmane.comp.version-control.git/57204\n\nfor details and a possible future plans.  Making \"diff.color =\ntrue\" to always color was a mistake, and if you have such a\nconfiguration, it would break any script that reads from \"git\nlog\".  In the meantime, do not do \"diff.color = true\" (or\n\"color.diff = true\") in your configuration; say \"auto\" instead\nof \"true\", and/or apply this patch.\n\n---\n\n gitk |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/gitk b/gitk\nindex 300fdce..9c21eff 100755\n--- a/gitk\n+++ b/gitk\n@@ -93,6 +93,7 @@ proc start_rev_list {view} {\n     }\n     if {[catch {\n \tset fd [open [concat | git log -z --pretty=raw $order --parents \\\n+\t\t\t --no-color \\\n \t\t\t --boundary $viewargs($view) \"--\" $viewfiles($view)] r]\n     } err]} {\n \terror_popup \"Error executing git rev-list: $err\"\n"},{"id":"52293","messageId":"20070903012527.GB19198@falcon.digizenstudio.com","threadId":"9752","inReplyTo":"7vzm04odze.fsf@gitster.siamese.dyndns.org","subject":"Re: gitk fails to parse git log output in 1.5.3","fromName":"Jing Xue","fromEmail":"jingxue@digizenstudio.com","sentAt":"2007-09-03T01:25:27Z","receivedAt":"2007-09-03T01:25:27Z","isPatch":false,"sender":{"key":"jingxue@digizenstudio.com","avatar":null},"body":"\nOn Sun, Sep 02, 2007 at 04:16:05PM -0700, Junio C Hamano wrote:\n> \n> This will quickly turn into an FAQ.\n\nIndeed. I went and added it to the Wiki/FAQ.\n\nAlso I noticed that git-log was missing the descriptions for '--color'\nand '--no-color'.\n\n\nSigned-off-by: Jing Xue <jingxue@digizenstudio.com>\n---\n Documentation/git-log.txt |    8 ++++++++\n 1 files changed, 8 insertions(+), 0 deletions(-)\n\ndiff --git a/Documentation/git-log.txt b/Documentation/git-log.txt\nindex 5ec547c..c42ca89 100644\n--- a/Documentation/git-log.txt\n+++ b/Documentation/git-log.txt\n@@ -72,6 +72,14 @@ include::pretty-options.txt[]\n \tNote that only message is considered, if also a diff is shown\n \tits size is not included.\n \n+--color::\n+\tShow colored log entries. Same as if `color.diff` were set to\n+    \"true\".\n+\n+--no-color::\n+\tTurn off colored log entries, even when `color.diff` sets the\n+    default to color output.\n+\n <paths>...::\n \tShow only commits that affect the specified paths.\n \n-- \n1.5.3\n"}]}