{"thread":{"id":"9713","subject":"[ANNOUNCE] git/gitweb.git repository","startedAt":"2007-08-31T00:01:49Z","lastAt":"2007-09-07T06:39:46Z","messageCount":24,"participants":["Petr Baudis","David Symonds","Luben Tuikov","Johannes Schindelin","Junio C Hamano","Jon Smirl","Jakub Narebski","Adam Roben","Shawn O. Pearce","Andreas Ericsson"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"51967","messageId":"20070831000149.GK1219@pasky.or.cz","threadId":"9713","inReplyTo":null,"subject":"[ANNOUNCE] git/gitweb.git repository","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2007-08-31T00:01:49Z","receivedAt":"2007-08-31T00:01:49Z","isPatch":false,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":" Hi,\n\n due to popular (Junio's) demand, I have set up a gitweb-oriented fork\nof git at repo.or.cz:\n\n\thttp://repo.or.cz/w/git/gitweb.git\n\n It is meant as a hub for various gitweb-related patches and\ndevelopment efforts. So far it is pre-seeded by the patches repo.or.cz's\ngitweb uses. It is divided to three main branches (StGIT patchstacks in\nreality), where master is what Junio is gonna pull to git's master.\n\n Please feel encouraged to make random forks for your development\nefforts, or push your random patches (preferrably just bugfixes,\nsomething possibly controversial should be kept in safe containment like\na fork or separate branch) to the mob branch.\n\n Have fun,\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nEarly to rise and early to bed makes a male healthy and wealthy and dead.\n -- James Thurber\n"},{"id":"51969","messageId":"ee77f5c20708301756k60b4d295j907da463af477982@mail.gmail.com","threadId":"9713","inReplyTo":"20070831000149.GK1219@pasky.or.cz","subject":"Re: [ANNOUNCE] git/gitweb.git repository","fromName":"David Symonds","fromEmail":"dsymonds@gmail.com","sentAt":"2007-08-31T00:56:32Z","receivedAt":"2007-08-31T00:56:32Z","isPatch":false,"sender":{"key":"dsymonds@gmail.com","avatar":"https://gravatar.com/avatar/b22f5051cbfc11836e36cf7a690e6cde4e225d835e13295ff98d15c7a9ee3c0f?d=mp&s=160"},"body":"On 31/08/2007, Petr Baudis wrote:\n> Please feel encouraged to make random forks for your development\n> efforts, or push your random patches (preferrably just bugfixes,\n> something possibly controversial should be kept in safe containment like\n> a fork or separate branch) to the mob branch.\n\nSorry, I'm still relatively new to git, and couldn't work out how to\npush to the mob branch, so it's inline below. It's fairly minor, just\nadding .. around author names when they get\nabbreviated.\n\n\nDave.\n\n\n>From 37c85462393d3e83d83dbdc9362cd9ff7587574c Mon Sep 17 00:00:00 2001\nFrom: David Symonds \nDate: Fri, 31 Aug 2007 10:49:53 +1000\nSubject: [PATCH] gitweb: Provide title attributes for abbreviated author names.\n\nSigned-off-by: David Symonds \n---\n gitweb/gitweb.perl | 34 +++++++++++++++++++++++++++++-----\n 1 files changed, 29 insertions(+), 5 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex b2bae1b..3112fd4 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -3461,9 +3461,15 @@ sub git_shortlog_body {\n \t\t\tprint \"\\n\";\n \t\t}\n \t\t$alternate ^= 1;\n+\t\tmy $author = chop_str($co{'author_name'}, 10);\n+\t\tif ($author ne $co{'author_name'}) {\n+\t\t\t$author = \"\" .\nesc_html($author) . \"\";\n+\t\t} else {\n+\t\t\t$author = esc_html($author);\n+\t\t}\n \t\t# git_summary() used print \"$co{'age_string'}\\n\" .\n \t\tprint \"$co{'age_string_date'}\\n\"\n.\n-\t\t \"\" . esc_html(chop_str($co{'author_name'}, 10)) .\n\"\\n\" .\n+\t\t \"\" . $author . \"\\n\" .\n \t\t \"\";\n \t\tprint format_subject_html($co{'title'}, $co{'title_short'},\n \t\t href(action=>\"commit\", hash=>$commit), $ref);\n@@ -3511,9 +3517,15 @@ sub git_history_body {\n \t\t\tprint \"\\n\";\n \t\t}\n \t\t$alternate ^= 1;\n+\t# shortlog uses chop_str($co{'author_name'}, 10)\n+\t\tmy $author = chop_str($co{'author_name'}, 15, 3);\n+\t\tif ($author ne $co{'author_name'}) {\n+\t\t\t\"\" . esc_html($author) . \"\";\n+\t\t} else {\n+\t\t\t$author = esc_html($author);\n+\t\t}\n \t\tprint \"$co{'age_string_date'}\\n\"\n.\n-\t\t # shortlog uses chop_str($co{'author_name'}, 10)\n-\t\t \"\" . esc_html(chop_str($co{'author_name'}, 15, 3)) .\n\"\\n\" .\n+\t\t \"\" . $author . \"\\n\" .\n \t\t \"\";\n \t\t# originally git_history used chop_str($co{'title'}, 50)\n \t\tprint format_subject_html($co{'title'}, $co{'title_short'},\n@@ -3667,8 +3679,14 @@ sub git_search_grep_body {\n \t\t\tprint \"\\n\";\n \t\t}\n \t\t$alternate ^= 1;\n+\t\tmy $author = chop_str($co{'author_name'}, 15, 5);\n+\t\tif ($author ne $co{'author_name'}) {\n+\t\t\t$author = \"\" .\nesc_html($author) . \"\";\n+\t\t} else {\n+\t\t\t$author = esc_html($author);\n+\t\t}\n \t\tprint \"$co{'age_string_date'}\\n\"\n.\n-\t\t \"\" . esc_html(chop_str($co{'author_name'}, 15, 5)) .\n\"\\n\" .\n+\t\t \"\" . $author . \"\\n\" .\n \t\t \"\" .\n \t\t $cgi->a({-href => href(action=>\"commit\", hash=>$co{'id'}),\n-class => \"list subject\"},\n \t\t\t esc_html(chop_str($co{'title'}, 50)) . \"
\");\n@@ -5181,8 +5199,14 @@ sub git_search {\n \t\t\t\t\t\tprint \"\\n\";\n \t\t\t\t\t}\n \t\t\t\t\t$alternate ^= 1;\n+\t\t\t\t\tmy $author = chop_str($co{'author_name'}, 15, 5);\n+\t\t\t\t\tif ($author ne $co{'author_name'}) {\n+\t\t\t\t\t\t$author = \"\" .\nesc_html($author) . \"\";\n+\t\t\t\t\t} else {\n+\t\t\t\t\t\t$author = esc_html($author);\n+\t\t\t\t\t}\n \t\t\t\t\tprint \"$co{'age_string_date'}\\n\"\n.\n-\t\t\t\t\t \"\" . esc_html(chop_str($co{'author_name'}, 15, 5))\n. \"\\n\" .\n+\t\t\t\t\t \"\" . $author . \"\\n\" .\n \t\t\t\t\t \"\" .\n \t\t\t\t\t $cgi->a({-href => href(action=>\"commit\", hash=>$co{'id'}),\n \t\t\t\t\t -class => \"list subject\"},\n-- \n1.5.2.4\n"},{"id":"51970","messageId":"ee77f5c20708301800s7fbaec17sa9a58b40826ff8a2@mail.gmail.com","threadId":"9713","inReplyTo":"ee77f5c20708301756k60b4d295j907da463af477982@mail.gmail.com","subject":"Re: [ANNOUNCE] git/gitweb.git repository","fromName":"David Symonds","fromEmail":"dsymonds@gmail.com","sentAt":"2007-08-31T01:00:02Z","receivedAt":"2007-08-31T01:00:02Z","isPatch":false,"sender":{"key":"dsymonds@gmail.com","avatar":"https://gravatar.com/avatar/b22f5051cbfc11836e36cf7a690e6cde4e225d835e13295ff98d15c7a9ee3c0f?d=mp&s=160"},"body":"On 31/08/2007, David Symonds wrote:\n> On 31/08/2007, Petr Baudis wrote:\n> > Please feel encouraged to make random forks for your development\n> > efforts, or push your random patches (preferrably just bugfixes,\n> > something possibly controversial should be kept in safe containment like\n> > a fork or separate branch) to the mob branch.\n>\n> Sorry, I'm still relatively new to git, and couldn't work out how to\n> push to the mob branch, so it's inline below. It's fairly minor, just\n> adding .. around author names when they get\n> abbreviated.\n\nDarn, looks like I suck at copy-n-paste, too. Here's an unwrapped patch:\n\n\n>From 37c85462393d3e83d83dbdc9362cd9ff7587574c Mon Sep 17 00:00:00 2001\nFrom: David Symonds \nDate: Fri, 31 Aug 2007 10:49:53 +1000\nSubject: [PATCH] gitweb: Provide title attributes for abbreviated author names.\n\nSigned-off-by: David Symonds \n---\n gitweb/gitweb.perl | 34 +++++++++++++++++++++++++++++-----\n 1 files changed, 29 insertions(+), 5 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex b2bae1b..3112fd4 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -3461,9 +3461,15 @@ sub git_shortlog_body {\n \t\t\tprint \"\\n\";\n \t\t}\n \t\t$alternate ^= 1;\n+\t\tmy $author = chop_str($co{'author_name'}, 10);\n+\t\tif ($author ne $co{'author_name'}) {\n+\t\t\t$author = \"\" .\nesc_html($author) . \"\";\n+\t\t} else {\n+\t\t\t$author = esc_html($author);\n+\t\t}\n \t\t# git_summary() used print \"$co{'age_string'}\\n\" .\n \t\tprint \"$co{'age_string_date'}\\n\"\n.\n-\t\t \"\" . esc_html(chop_str($co{'author_name'}, 10)) .\n\"\\n\" .\n+\t\t \"\" . $author . \"\\n\" .\n \t\t \"\";\n \t\tprint format_subject_html($co{'title'}, $co{'title_short'},\n \t\t href(action=>\"commit\", hash=>$commit), $ref);\n@@ -3511,9 +3517,15 @@ sub git_history_body {\n \t\t\tprint \"\\n\";\n \t\t}\n \t\t$alternate ^= 1;\n+\t# shortlog uses chop_str($co{'author_name'}, 10)\n+\t\tmy $author = chop_str($co{'author_name'}, 15, 3);\n+\t\tif ($author ne $co{'author_name'}) {\n+\t\t\t\"\" . esc_html($author) . \"\";\n+\t\t} else {\n+\t\t\t$author = esc_html($author);\n+\t\t}\n \t\tprint \"$co{'age_string_date'}\\n\"\n.\n-\t\t # shortlog uses chop_str($co{'author_name'}, 10)\n-\t\t \"\" . esc_html(chop_str($co{'author_name'}, 15, 3)) .\n\"\\n\" .\n+\t\t \"\" . $author . \"\\n\" .\n \t\t \"\";\n \t\t# originally git_history used chop_str($co{'title'}, 50)\n \t\tprint format_subject_html($co{'title'}, $co{'title_short'},\n@@ -3667,8 +3679,14 @@ sub git_search_grep_body {\n \t\t\tprint \"\\n\";\n \t\t}\n \t\t$alternate ^= 1;\n+\t\tmy $author = chop_str($co{'author_name'}, 15, 5);\n+\t\tif ($author ne $co{'author_name'}) {\n+\t\t\t$author = \"\" .\nesc_html($author) . \"\";\n+\t\t} else {\n+\t\t\t$author = esc_html($author);\n+\t\t}\n \t\tprint \"$co{'age_string_date'}\\n\"\n.\n-\t\t \"\" . esc_html(chop_str($co{'author_name'}, 15, 5)) .\n\"\\n\" .\n+\t\t \"\" . $author . \"\\n\" .\n \t\t \"\" .\n \t\t $cgi->a({-href => href(action=>\"commit\", hash=>$co{'id'}),\n-class => \"list subject\"},\n \t\t\t esc_html(chop_str($co{'title'}, 50)) . \"
\");\n@@ -5181,8 +5199,14 @@ sub git_search {\n \t\t\t\t\t\tprint \"\\n\";\n \t\t\t\t\t}\n \t\t\t\t\t$alternate ^= 1;\n+\t\t\t\t\tmy $author = chop_str($co{'author_name'}, 15, 5);\n+\t\t\t\t\tif ($author ne $co{'author_name'}) {\n+\t\t\t\t\t\t$author = \"\" .\nesc_html($author) . \"\";\n+\t\t\t\t\t} else {\n+\t\t\t\t\t\t$author = esc_html($author);\n+\t\t\t\t\t}\n \t\t\t\t\tprint \"$co{'age_string_date'}\\n\"\n.\n-\t\t\t\t\t \"\" . esc_html(chop_str($co{'author_name'}, 15, 5))\n. \"\\n\" .\n+\t\t\t\t\t \"\" . $author . \"\\n\" .\n \t\t\t\t\t \"\" .\n \t\t\t\t\t $cgi->a({-href => href(action=>\"commit\", hash=>$co{'id'}),\n \t\t\t\t\t -class => \"list subject\"},\n-- \n1.5.2.4\n"},{"id":"52107","messageId":"767502.77573.qm@web31812.mail.mud.yahoo.com","threadId":"9713","inReplyTo":"20070831000149.GK1219@pasky.or.cz","subject":"Re: [ANNOUNCE] git/gitweb.git repository","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2007-09-01T01:06:02Z","receivedAt":"2007-09-01T01:06:02Z","isPatch":false,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"--- Petr Baudis wrote:\n> Hi,\n> \n> due to popular (Junio's) demand, I have set up a gitweb-oriented fork\n> of git at repo.or.cz:\n> \n> \thttp://repo.or.cz/w/git/gitweb.git\n> \n> It is meant as a hub for various gitweb-related patches and\n> development efforts. So far it is pre-seeded by the patches repo.or.cz's\n> gitweb uses.\n\nIs this right?\n\nSo what's the review process now? \"Because it is part of repo.or.cz's\ngitweb\" seems to be a weak argument.\n\n Luben\n\n> It is divided to three main branches (StGIT patchstacks in\n> reality), where master is what Junio is gonna pull to git's master.\n> \n> Please feel encouraged to make random forks for your development\n> efforts, or push your random patches (preferrably just bugfixes,\n> something possibly controversial should be kept in safe containment like\n> a fork or separate branch) to the mob branch.\n> \n> Have fun,\n> \n> -- \n> \t\t\t\tPetr \"Pasky\" Baudis\n> Early to rise and early to bed makes a male healthy and wealthy and dead.\n> -- James Thurber\n> \n"},{"id":"52108","messageId":"20070901011608.GC10749@pasky.or.cz","threadId":"9713","inReplyTo":"767502.77573.qm@web31812.mail.mud.yahoo.com","subject":"Re: [ANNOUNCE] git/gitweb.git repository","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2007-09-01T01:16:08Z","receivedAt":"2007-09-01T01:16:08Z","isPatch":false,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"On Sat, Sep 01, 2007 at 03:06:02AM CEST, Luben Tuikov wrote:\n> --- Petr Baudis wrote:\n> > Hi,\n> > \n> > due to popular (Junio's) demand, I have set up a gitweb-oriented fork\n> > of git at repo.or.cz:\n> > \n> > \thttp://repo.or.cz/w/git/gitweb.git\n> > \n> > It is meant as a hub for various gitweb-related patches and\n> > development efforts. So far it is pre-seeded by the patches repo.or.cz's\n> > gitweb uses.\n> \n> Is this right?\n> \n> So what's the review process now? \"Because it is part of repo.or.cz's\n> gitweb\" seems to be a weak argument.\n\nHave you even looked at the page I linked? I tried to explain how are\nthe patches organized to branches there. Please ask if something is\nstill unclear.\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nEarly to rise and early to bed makes a male healthy and wealthy and dead.\n -- James Thurber\n"},{"id":"52110","messageId":"156525.53603.qm@web31809.mail.mud.yahoo.com","threadId":"9713","inReplyTo":"20070901011608.GC10749@pasky.or.cz","subject":"Re: [ANNOUNCE] git/gitweb.git repository","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2007-09-01T01:23:33Z","receivedAt":"2007-09-01T01:23:33Z","isPatch":false,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"--- Petr Baudis wrote:\n> On Sat, Sep 01, 2007 at 03:06:02AM CEST, Luben Tuikov wrote:\n> > --- Petr Baudis wrote:\n> > > Hi,\n> > > \n> > > due to popular (Junio's) demand, I have set up a gitweb-oriented fork\n> > > of git at repo.or.cz:\n> > > \n> > > \thttp://repo.or.cz/w/git/gitweb.git\n> > > \n> > > It is meant as a hub for various gitweb-related patches and\n> > > development efforts. So far it is pre-seeded by the patches repo.or.cz's\n> > > gitweb uses.\n> > \n> > Is this right?\n> > \n> > So what's the review process now? \"Because it is part of repo.or.cz's\n> > gitweb\" seems to be a weak argument.\n> \n> Have you even looked at the page I linked? I tried to explain how are\n> the patches organized to branches there. Please ask if something is\n> still unclear.\n\nYes, I did. I saw that gitweb::master is identical to Junio's, but\nfor safety measure I decided to ask. Thanks for your reply.\n\n Luben\n"},{"id":"52111","messageId":"Pine.LNX.4.64.0709010224410.28586@racer.site","threadId":"9713","inReplyTo":"767502.77573.qm@web31812.mail.mud.yahoo.com","subject":"Re: [ANNOUNCE] git/gitweb.git repository","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-09-01T01:25:16Z","receivedAt":"2007-09-01T01:25:16Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Fri, 31 Aug 2007, Luben Tuikov wrote:\n\n> --- Petr Baudis wrote:\n> > Hi,\n> > \n> > due to popular (Junio's) demand, I have set up a gitweb-oriented fork\n> > of git at repo.or.cz:\n> > \n> > \thttp://repo.or.cz/w/git/gitweb.git\n> > \n> > It is meant as a hub for various gitweb-related patches and\n> > development efforts. So far it is pre-seeded by the patches repo.or.cz's\n> > gitweb uses.\n> \n> Is this right?\n> \n> So what's the review process now?\n\nUmm. Pasky set it up, so it's Pasky who decides what goes in and what \nnot. What exactly is your problem?\n\nCiao,\nDscho\n"},{"id":"52113","messageId":"20070901013159.GP1219@pasky.or.cz","threadId":"9713","inReplyTo":"Pine.LNX.4.64.0709010224410.28586@racer.site","subject":"Re: [ANNOUNCE] git/gitweb.git repository","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2007-09-01T01:31:59Z","receivedAt":"2007-09-01T01:31:59Z","isPatch":false,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":" Hi,\n\nOn Sat, Sep 01, 2007 at 03:25:16AM CEST, Johannes Schindelin wrote:\n> On Fri, 31 Aug 2007, Luben Tuikov wrote:\n> \n> > --- Petr Baudis wrote:\n> > > Hi,\n> > > \n> > > due to popular (Junio's) demand, I have set up a gitweb-oriented fork\n> > > of git at repo.or.cz:\n> > > \n> > > \thttp://repo.or.cz/w/git/gitweb.git\n> > > \n> > > It is meant as a hub for various gitweb-related patches and\n> > > development efforts. So far it is pre-seeded by the patches repo.or.cz's\n> > > gitweb uses.\n> > \n> > Is this right?\n> > \n> > So what's the review process now?\n> \n> Umm. Pasky set it up, so it's Pasky who decides what goes in and what \n> not. What exactly is your problem?\n\n Junio will pull from it, so he has full right to ask. :-) As I wrote\nin the web README, to enter #next your patch should see some git@ review;\nthat holds for repo.or.cz patches as well as for any other patches. I\nsuppose we will sort out the exact distinction between #next and #master\non the fly; the general idea is that patches that go on #master have\nmore or less approached perfectness. ;-)\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nEarly to rise and early to bed makes a male healthy and wealthy and dead.\n -- James Thurber\n"},{"id":"52115","messageId":"7v4pifw45n.fsf@gitster.siamese.dyndns.org","threadId":"9713","inReplyTo":"20070901013159.GP1219@pasky.or.cz","subject":"Re: [ANNOUNCE] git/gitweb.git repository","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-09-01T01:44:20Z","receivedAt":"2007-09-01T01:44:20Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Petr Baudis writes:\n\n> On Sat, Sep 01, 2007 at 03:25:16AM CEST, Johannes Schindelin wrote:\n>> On Fri, 31 Aug 2007, Luben Tuikov wrote:\n>> \n>> > So what's the review process now?\n>> \n>> Umm. Pasky set it up, so it's Pasky who decides what goes in and what \n>> not. What exactly is your problem?\n>\n> Junio will pull from it, so he has full right to ask. :-)\n\nWell, I won't blindly pull from it, but honestly when it comes\nto gitweb I trust Pasky's judgement as much as I trust myself,\nif not even more. And I think the review process Pasky\ndescribed is good --- people will see both the patches on the\nlist and code in action at repo.or.cz/.\n\nI am a bit worried about the 'master' being a \"StGIT stack\",\nthough. Playgrounds to be cherry-picked from (aka 'pu') would\nmake *perfect* sense to be managed that way (and the topics that\ngo only 'pu' of git.git itself are managed the same except that\nI do not do so using StGIT), but I think we need a stable\nhistory for the branch git.git will eventually pull from.\n"},{"id":"52116","messageId":"233630.70682.qm@web31809.mail.mud.yahoo.com","threadId":"9713","inReplyTo":"Pine.LNX.4.64.0709010224410.28586@racer.site","subject":"Re: [ANNOUNCE] git/gitweb.git repository","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2007-09-01T02:06:40Z","receivedAt":"2007-09-01T02:06:40Z","isPatch":false,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"--- Johannes Schindelin wrote:\n\n> Hi,\n> \n> On Fri, 31 Aug 2007, Luben Tuikov wrote:\n> \n> > --- Petr Baudis wrote:\n> > > Hi,\n> > > \n> > > due to popular (Junio's) demand, I have set up a gitweb-oriented fork\n> > > of git at repo.or.cz:\n> > > \n> > > \thttp://repo.or.cz/w/git/gitweb.git\n> > > \n> > > It is meant as a hub for various gitweb-related patches and\n> > > development efforts. So far it is pre-seeded by the patches repo.or.cz's\n> > > gitweb uses.\n> > \n> > Is this right?\n> > \n> > So what's the review process now?\n> \n> Umm. Pasky set it up, so it's Pasky who decides what goes in and what \n> not. What exactly is your problem?\n\nThat's perfectly fine as long as Junio doesn't pull from it ever.\n\nNow since Junio is going to pull from it, there needs to be some\nsort of accountability.\n\n Luben\n"},{"id":"52117","messageId":"400762.26134.qm@web31810.mail.mud.yahoo.com","threadId":"9713","inReplyTo":"7v4pifw45n.fsf@gitster.siamese.dyndns.org","subject":"Re: [ANNOUNCE] git/gitweb.git repository","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2007-09-01T02:15:23Z","receivedAt":"2007-09-01T02:15:23Z","isPatch":false,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"--- Junio C Hamano wrote:\n> Petr Baudis writes:\n> \n> > On Sat, Sep 01, 2007 at 03:25:16AM CEST, Johannes Schindelin wrote:\n> >> On Fri, 31 Aug 2007, Luben Tuikov wrote:\n> >> \n> >> > So what's the review process now?\n> >> \n> >> Umm. Pasky set it up, so it's Pasky who decides what goes in and what \n> >> not. What exactly is your problem?\n> >\n> > Junio will pull from it, so he has full right to ask. :-)\n> \n> Well, I won't blindly pull from it, but honestly when it comes\n> to gitweb I trust Pasky's judgement as much as I trust myself,\n> if not even more. And I think the review process Pasky\n> described is good --- people will see both the patches on the\n> list and code in action at repo.or.cz/.\n> \n> I am a bit worried about the 'master' being a \"StGIT stack\",\n> though. Playgrounds to be cherry-picked from (aka 'pu') would\n> make *perfect* sense to be managed that way (and the topics that\n> go only 'pu' of git.git itself are managed the same except that\n> I do not do so using StGIT), but I think we need a stable\n> history for the branch git.git will eventually pull from.\n\nThat was my concern too, but seeing the immediate hostility\nI got about asking about the review process I decided not\nto mention it.\n\nI'd be interesting to see how gitweb support pans out\ngiven this initial hostility to inquiry of accountability.\n\nOver the years I've seen that the best support and accountability\nhas been had when the maintainer is not the main contributor/developer,\nespecially for shared development. Otherwise personal preferences over\nfeature X and Y come into play and then things get ugly. This is\nwhy you were such a good maintainer of gitweb.\n\n Luben\n"},{"id":"52122","messageId":"7vhcmfugnm.fsf@gitster.siamese.dyndns.org","threadId":"9713","inReplyTo":"400762.26134.qm@web31810.mail.mud.yahoo.com","subject":"Re: [ANNOUNCE] git/gitweb.git repository","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-09-01T04:57:17Z","receivedAt":"2007-09-01T04:57:17Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Luben Tuikov writes:\n\n> --- Junio C Hamano wrote:\n> ...\n>> I am a bit worried about the 'master' being a \"StGIT stack\",\n>> though. Playgrounds to be cherry-picked from (aka 'pu') would\n>> make *perfect* sense to be managed that way (and the topics that\n>> go only 'pu' of git.git itself are managed the same except that\n>> I do not do so using StGIT), but I think we need a stable\n>> history for the branch git.git will eventually pull from.\n>\n> That was my concern too, but seeing the immediate hostility\n> I got about asking about the review process I decided not\n> to mention it.\n\nI do not think Johannes meant any hostility against you by\nmentioning the obvious \"person A sets up a repository, he gets\nto decide rule for _his_ repository\", implication of which is\nthat anobody else can do the same.\n\nIt is a completely different matter how the bits of the results\nare decided to be good and bad and merged as part of git.git,\nand that will be done with community input as always.\n\nI asked Pasky to host series of patches for various reasons.\n\n (1) I know I am less qualified than Pasky, you nor Jakub (the\n three people I publicly said I consider more interested in\n and have experience with gitweb than I am). If I were to\n sift through the patches, I am sure many patches will rot\n because of indecision. I wanted to make sure people more\n interested in gitweb than myself play more active role in\n its development and maintenance.\n\n (2) It would make it easier to view and judge the impact of\n pending patches if the code is used on to show various real\n repositories to the public. repo.or.cz is an ideal place,\n and Pasky has shown competence managing that service to the\n community. A change to gitweb may look obviously correct\n with just minor performance impact while code inspection,\n but may have scaling issues in the real world --- he will\n have the first hand experience to catch that. Anybody\n could set something like that up, but I trust the three\n gitweb gang more or less equally, so why not utilize the\n infrastructure we already have, especially Pasky agreed to\n help?\n\n (3) I have disagreed on a handful technical issues with Pasky,\n you and Jakub, but I do not expect all of us to always\n agree something is good or bad unanimously, nor I expect it\n would satisfy everybody in the community even if we agree\n on something unanimously, if we acted as a Cabal. One\n thing that is important is that the process is transparent.\n\n I trust Pasky to be open-minded as any of us would be. I\n do not expect him to start acting as a dictator on gitweb\n issues and force bad technical decisions without listening\n to others. I trust him at least that much. I would\n probably trust you or Jakub the same way, but I do not have\n to pick one single person that I trust _most_. As long as\n the person who maintains the gitweb patch queue is trusted\n and respected _enough_ by the community, I think that is\n good enough. And this is all volunteer work. Good\n maintainers are hard to find.\n\n> I'd be interesting to see how gitweb support pans out\n> given this initial hostility to inquiry of accountability.\n>\n> Over the years I've seen that the best support and accountability\n> has been had when the maintainer is not the main contributor/developer,\n> especially for shared development. Otherwise personal preferences over\n> feature X and Y come into play and then things get ugly.\n\nI understand your concern, and I think that is where you can\nhelp the most. If you see questionable patches queued, spot\nthem and raise issues. We've been a friendly community, and\nluckily we haven't had too many burnt bridges over personality\ndifferences.\n\nWe have a _LOT_ of work ahead of us in gitweb area. You may\nremember that there was a call-for-help from k.org gitweb master\n(J. H. \"warthog9\", with comments from HPA) some time ago. The\ninstallation there is heavily modified to support a large and\nheavily-hit site better than the stock gitweb, but the codebase\nhas diverged quite a bit. We need to fold that effort back so\nthat (1) they do not have to keep maintaining their fork, and\n(2) everybody else will benefit from their scalability work.\n"},{"id":"52127","messageId":"ee77f5c20708312246u37f9c1bahe2211117abd05790@mail.gmail.com","threadId":"9713","inReplyTo":"ee77f5c20708301756k60b4d295j907da463af477982@mail.gmail.com","subject":"Re: [ANNOUNCE] git/gitweb.git repository","fromName":"David Symonds","fromEmail":"dsymonds@gmail.com","sentAt":"2007-09-01T05:46:51Z","receivedAt":"2007-09-01T05:46:51Z","isPatch":false,"sender":{"key":"dsymonds@gmail.com","avatar":"https://gravatar.com/avatar/b22f5051cbfc11836e36cf7a690e6cde4e225d835e13295ff98d15c7a9ee3c0f?d=mp&s=160"},"body":"On 31/08/07, David Symonds wrote:\n> On 31/08/2007, Petr Baudis wrote:\n> > Please feel encouraged to make random forks for your development\n> > efforts, or push your random patches (preferrably just bugfixes,\n> > something possibly controversial should be kept in safe containment like\n> > a fork or separate branch) to the mob branch.\n>\n> Sorry, I'm still relatively new to git, and couldn't work out how to\n> push to the mob branch, so it's inline below. It's fairly minor, just\n> adding .. around author names when they get\n> abbreviated.\n\nOkay, I worked out how to push to the mob branch: it's commit 37c8546.\nI can refactor this somewhat if that's an issue.\n\n\nDave.\n"},{"id":"52148","messageId":"9e4733910709010815t23849056j9039a9d92eae15ee@mail.gmail.com","threadId":"9713","inReplyTo":"20070831000149.GK1219@pasky.or.cz","subject":"Re: [ANNOUNCE] git/gitweb.git repository","fromName":"Jon Smirl","fromEmail":"jonsmirl@gmail.com","sentAt":"2007-09-01T15:15:58Z","receivedAt":"2007-09-01T15:15:58Z","isPatch":false,"sender":{"key":"jonsmirl@gmail.com","avatar":"https://gravatar.com/avatar/cff3bf5bfdfa6708b905712ff91f0f9b8aaca161659f38c02b787920d5d28b7e?d=mp&s=160"},"body":"On 8/30/07, Petr Baudis wrote:\n> Hi,\n>\n> due to popular (Junio's) demand, I have set up a gitweb-oriented fork\n> of git at repo.or.cz:\n>\n> http://repo.or.cz/w/git/gitweb.git\n>\n> It is meant as a hub for various gitweb-related patches and\n> development efforts. So far it is pre-seeded by the patches repo.or.cz's\n> gitweb uses. It is divided to three main branches (StGIT patchstacks in\n> reality), where master is what Junio is gonna pull to git's master.\n\nUsing gitweb....\nSince this is a patch stack, how do I get the summary log messages for\njust the commits on the branch without getting the log messages for\nthe master repository mixed in? Would that give me a nice list of the\npending patches?\n\nI can get the tree diffs without problem.\n\n\n>\n> Please feel encouraged to make random forks for your development\n> efforts, or push your random patches (preferrably just bugfixes,\n> something possibly controversial should be kept in safe containment like\n> a fork or separate branch) to the mob branch.\n>\n> Have fun,\n>\n> --\n> Petr \"Pasky\" Baudis\n> Early to rise and early to bed makes a male healthy and wealthy and dead.\n> -- James Thurber\n> -\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n>\n\n\n-- \nJon Smirl\njonsmirl@gmail.com\n"},{"id":"52149","messageId":"7vwsvas24j.fsf@gitster.siamese.dyndns.org","threadId":"9713","inReplyTo":"9e4733910709010815t23849056j9039a9d92eae15ee@mail.gmail.com","subject":"Re: [ANNOUNCE] git/gitweb.git repository","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-09-01T17:54:04Z","receivedAt":"2007-09-01T17:54:04Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Jon Smirl\" writes:\n\n> On 8/30/07, Petr Baudis wrote:\n>>\n>> due to popular (Junio's) demand, I have set up a gitweb-oriented fork\n>> of git at repo.or.cz:\n>>\n>> http://repo.or.cz/w/git/gitweb.git\n>>\n>> It is meant as a hub for various gitweb-related patches and\n>> development efforts. So far it is pre-seeded by the patches repo.or.cz's\n>> gitweb uses. It is divided to three main branches (StGIT patchstacks in\n>> reality), where master is what Junio is gonna pull to git's master.\n>\n> Using gitweb....\n> Since this is a patch stack, how do I get the summary log messages for\n> just the commits on the branch without getting the log messages for\n> the master repository mixed in? Would that give me a nice list of the\n> pending patches?\n\nThat's an excellent suggestion. I'd love to see \"fork\" aware\ngitweb myself.\n\nIf a project A is \"forked\" repo.or.cz style to a project B, what\noften is interesting to see is what changes B has relative to A.\n\nIn other words, you would want to view all of B except what are\nin A, something like:\n\n$ gitk --all --not $(git for-each-ref --format='%(objectname)' refs/remotes/A)\n"},{"id":"52177","messageId":"200709011954.23771.jnareb@gmail.com","threadId":"9713","inReplyTo":"20070831000149.GK1219@pasky.or.cz","subject":"Re: [ANNOUNCE] git/gitweb.git repository","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-09-01T17:54:23Z","receivedAt":"2007-09-01T17:54:23Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"On Friday, 31 August 2007, Petr Baudis wrote:\n\n> Please feel encouraged to make random forks for your development\n> efforts, or push your random patches (preferrably just bugfixes,\n> something possibly controversial should be kept in safe containment\n> like a fork or separate branch) to the mob branch.\n\nWhat are the rules of pushing to the mob branch? Fetch, rebase, push?\nDoes mob branch allows non fast-forward pushes?\n\n-- \nJakub Narebski\nPoland\n"},{"id":"52393","messageId":"7v8x7n7zqn.fsf@gitster.siamese.dyndns.org","threadId":"9713","inReplyTo":"20070831000149.GK1219@pasky.or.cz","subject":"Re: [ANNOUNCE] git/gitweb.git repository","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-09-04T05:42:40Z","receivedAt":"2007-09-04T05:42:40Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Here is my impressions on patches in:\n\n\tgit://repo.or.cz/git/gitweb.git/ next\n\n* Removal of git_blame\n\n I think this makes sense; we do not need two not-so-different\n implementations, and the other one has been the default for\n quite some time.\n\n* Extra columns in blame\n\n I can see why some people especially with wide screen would\n want this, and toggling the display for extra columns is also\n a good idea. But this makes me wonder if the single button at\n the very top is easy to locate (maybe explain what [+] does?)\n and easy to access (maybe have it at the top and at least at\n the bottom as well?).\n\n* Incremental blame\n\n It does not seem to break the blame, but at least from where I\n sit accessing repo.or.cz this does not look incremental to me.\n The entire browser session freezes until the blame page\n displays in full. My local installation behaves the same way.\n\n\n\n \n"},{"id":"52395","messageId":"EFDB3AF7-E250-4816-AD4A-B580E3C902C1@apple.com","threadId":"9713","inReplyTo":"7v8x7n7zqn.fsf@gitster.siamese.dyndns.org","subject":"Re: [ANNOUNCE] git/gitweb.git repository","fromName":"Adam Roben","fromEmail":"aroben@apple.com","sentAt":"2007-09-04T05:47:54Z","receivedAt":"2007-09-04T05:47:54Z","isPatch":false,"sender":{"key":"aroben@apple.com","avatar":"https://gravatar.com/avatar/9d3697e1de53890adf241331f4b970bdd2b18962b2ff0b8028ebb00e085807f8?d=mp&s=160"},"body":"\nOn Sep 3, 2007, at 10:42 PM, Junio C Hamano wrote:\n\n> * Incremental blame\n>\n> It does not seem to break the blame, but at least from where I\n> sit accessing repo.or.cz this does not look incremental to me.\n> The entire browser session freezes until the blame page\n> displays in full. My local installation behaves the same way.\n\n For me, [1] loads incrementally as expected in Safari 3.0.3 on OS X.\n\n-Adam\n\n[1] http://repo.or.cz/w/alt-git.git?a=blame_incremental;f=git-svn.perl;h=d3c8cd0b8e3cfb97c6deb2453097c6f2e16e3bcf;hb=1e61b7640d09015213dbcae3564fa27ac6a8c151\n"},{"id":"52397","messageId":"20070904055048.GW18160@spearce.org","threadId":"9713","inReplyTo":"7v8x7n7zqn.fsf@gitster.siamese.dyndns.org","subject":"Re: [ANNOUNCE] git/gitweb.git repository","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-09-04T05:50:48Z","receivedAt":"2007-09-04T05:50:48Z","isPatch":false,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Junio C Hamano wrote:\n> * Incremental blame\n> \n> It does not seem to break the blame, but at least from where I\n> sit accessing repo.or.cz this does not look incremental to me.\n> The entire browser session freezes until the blame page\n> displays in full. My local installation behaves the same way.\n\nWhat kind of repo are you trying that on?\n\nI haven't myself tried the gitweb incremental blame but I do know\nthat one of my day-job repositories can take *ages* for git-gui's\n`git blame --incremental -C -C -w` pass. Most of the revisions\nfor some of the blobs are far back in history, and there's a lot of\nfiles to look at for copy/movement. Plus some of that history is\ndownright *messy* (I posted gitk screenshots of it not too long ago).\n\nI'll try to give the gitweb incremental blame a try on that repo\ntomorrow.\n\n-- \nShawn.\n"},{"id":"52401","messageId":"46DCF41D.2070905@op5.se","threadId":"9713","inReplyTo":"7v8x7n7zqn.fsf@gitster.siamese.dyndns.org","subject":"Re: [ANNOUNCE] git/gitweb.git repository","fromName":"Andreas Ericsson","fromEmail":"ae@op5.se","sentAt":"2007-09-04T05:58:53Z","receivedAt":"2007-09-04T05:58:53Z","isPatch":false,"sender":{"key":"ae@op5.se","avatar":"https://gravatar.com/avatar/426e89595c75a8f5252dd0c989e5fabe5bcac616e68557427ad9aef6b0ca342a?d=mp&s=160"},"body":"Junio C Hamano wrote:\n> * Incremental blame\n> \n> It does not seem to break the blame, but at least from where I\n> sit accessing repo.or.cz this does not look incremental to me.\n> The entire browser session freezes until the blame page\n> displays in full. My local installation behaves the same way.\n> \n\nThis is most likely due to what browser you're using. Some don't\nstart rendering until they've read the entire output of an URL.\n\n-- \nAndreas Ericsson andreas.ericsson@op5.se\nOP5 AB www.op5.se\nTel: +46 8-230225 Fax: +46 8-230231\n"},{"id":"52409","messageId":"670495.22199.qm@web31807.mail.mud.yahoo.com","threadId":"9713","inReplyTo":"7v8x7n7zqn.fsf@gitster.siamese.dyndns.org","subject":"Re: [ANNOUNCE] git/gitweb.git repository","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2007-09-04T07:56:15Z","receivedAt":"2007-09-04T07:56:15Z","isPatch":false,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"--- Junio C Hamano wrote:\n> Here is my impressions on patches in:\n> \n> \tgit://repo.or.cz/git/gitweb.git/ next\n> \n> * Removal of git_blame\n> \n> I think this makes sense; we do not need two not-so-different\n> implementations, and the other one has been the default for\n> quite some time.\n\nMy impression of the running gitweb installation at said site\nis that it doesn't implement 244a70e608204a515c214a11c43f3ecf7642533a.\nIt is very easy to verify that it is not supported.\n\nThis is a data mining feature that I use regularly.\n\n Luben\n\n\n> \n> * Extra columns in blame\n> \n> I can see why some people especially with wide screen would\n> want this, and toggling the display for extra columns is also\n> a good idea. But this makes me wonder if the single button at\n> the very top is easy to locate (maybe explain what [+] does?)\n> and easy to access (maybe have it at the top and at least at\n> the bottom as well?).\n> \n> * Incremental blame\n> \n> It does not seem to break the blame, but at least from where I\n> sit accessing repo.or.cz this does not look incremental to me.\n> The entire browser session freezes until the blame page\n> displays in full. My local installation behaves the same way.\n> \n> \n> \n> \n> \n"},{"id":"52410","messageId":"7vejhe7she.fsf@gitster.siamese.dyndns.org","threadId":"9713","inReplyTo":"20070904055048.GW18160@spearce.org","subject":"Re: [ANNOUNCE] git/gitweb.git repository","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-09-04T08:19:25Z","receivedAt":"2007-09-04T08:19:25Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Shawn O. Pearce\" writes:\n\n> Junio C Hamano wrote:\n>> * Incremental blame\n>> \n>> It does not seem to break the blame, but at least from where I\n>> sit accessing repo.or.cz this does not look incremental to me.\n>> The entire browser session freezes until the blame page\n>> displays in full. My local installation behaves the same way.\n>\n> What kind of repo are you trying that on?\n\nlinux-2.6.git (block/ll_rw_blk.c).\n\nBut I think I figured it out. With firebug disabled, I can see\nit is trying incremental.\n"},{"id":"52415","messageId":"20070904093807.GW10749@pasky.or.cz","threadId":"9713","inReplyTo":"46DCF41D.2070905@op5.se","subject":"Re: [ANNOUNCE] git/gitweb.git repository","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2007-09-04T09:38:07Z","receivedAt":"2007-09-04T09:38:07Z","isPatch":false,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"On Tue, Sep 04, 2007 at 07:58:53AM CEST, Andreas Ericsson wrote:\n> Junio C Hamano wrote:\n>> * Incremental blame\n>> It does not seem to break the blame, but at least from where I\n>> sit accessing repo.or.cz this does not look incremental to me.\n>> The entire browser session freezes until the blame page\n>> displays in full. My local installation behaves the same way.\n>\n> This is most likely due to what browser you're using. Some don't\n> start rendering until they've read the entire output of an URL.\n\nThe incremental blame uses AJAX, so this shouldn't be an issue. But for\nsome browsers it seems to take long time to actually render the new ids\nor something; I was reluctant about moving this particular one from next\nto master because I have also seen problems with it and wanted to do\nmore tests. The benefit is mostly on files with long history buried deep\nin the past.\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nEarly to rise and early to bed makes a male healthy and wealthy and dead.\n -- James Thurber\n"},{"id":"52859","messageId":"ee77f5c20709062339l54bbafc7ufaafdacc9da74ced@mail.gmail.com","threadId":"9713","inReplyTo":"ee77f5c20708312246u37f9c1bahe2211117abd05790@mail.gmail.com","subject":"Re: [ANNOUNCE] git/gitweb.git repository","fromName":"David Symonds","fromEmail":"dsymonds@gmail.com","sentAt":"2007-09-07T06:39:46Z","receivedAt":"2007-09-07T06:39:46Z","isPatch":false,"sender":{"key":"dsymonds@gmail.com","avatar":"https://gravatar.com/avatar/b22f5051cbfc11836e36cf7a690e6cde4e225d835e13295ff98d15c7a9ee3c0f?d=mp&s=160"},"body":"On 01/09/2007, David Symonds wrote:\n> On 31/08/07, David Symonds wrote:\n> > On 31/08/2007, Petr Baudis wrote:\n> > > Please feel encouraged to make random forks for your development\n> > > efforts, or push your random patches (preferrably just bugfixes,\n> > > something possibly controversial should be kept in safe containment like\n> > > a fork or separate branch) to the mob branch.\n> >\n> > Sorry, I'm still relatively new to git, and couldn't work out how to\n> > push to the mob branch, so it's inline below. It's fairly minor, just\n> > adding .. around author names when they get\n> > abbreviated.\n>\n> Okay, I worked out how to push to the mob branch: it's commit 37c8546.\n> I can refactor this somewhat if that's an issue.\n\nHas anyone taken a look at this? If it's bad/unwanted, just tell me\nand I'll drop it.\n\n\nDave.\n"}]}