{"thread":{"id":"9626","subject":"[BUG] git-gui: \"Stage Hunk For Commit\" doesn't work at all anymore","startedAt":"2007-08-23T20:30:24Z","lastAt":"2007-08-24T03:08:08Z","messageCount":3,"participants":["Brian Downing","Shawn O. Pearce"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"51396","messageId":"20070823203024.GF21692@lavos.net","threadId":"9626","inReplyTo":null,"subject":"[BUG] git-gui: \"Stage Hunk For Commit\" doesn't work at all anymore","fromName":"Brian Downing","fromEmail":"bdowning@lavos.net","sentAt":"2007-08-23T20:30:24Z","receivedAt":"2007-08-23T20:30:24Z","isPatch":false,"sender":{"key":"bdowning@lavos.net","avatar":"https://avatars.githubusercontent.com/u/366426?v=4"},"body":"This commit:\n\ncommit a13ee29b975d3a9a012983309e842d942b2bbd44\nAuthor: Shawn O. Pearce <spearce@spearce.org>\nDate:   Thu Aug 2 22:55:22 2007 -0400\n\n    git-gui: Avoid Tcl error in popup menu on diff viewer\n\n    If there is no path currently shown in the diff viewer then we\n    were getting Tcl errors anytime the user right-clicked on the\n    diff viewer to bring up its popup menu.  The bug here is caused\n    by trying to get the file_state for the empty string; this path\n    is never seen so we never have file_state for it.  In such cases\n    we now disable the Stage Hunk For Commit option.\n\n    Signed-off-by: Shawn O. Pearce <spearce@spearce.org>\n\nseems to have broken the \"Stage Hunk For Commit\" option entirely for me\n-- it is now disabled whether or not there is a patch in the viewer.\n\n-bcd\n"},{"id":"51399","messageId":"20070823203818.GG21692@lavos.net","threadId":"9626","inReplyTo":"20070823203024.GF21692@lavos.net","subject":"Re: [BUG] git-gui: \"Stage Hunk For Commit\" doesn't work at all anymore","fromName":"Brian Downing","fromEmail":"bdowning@lavos.net","sentAt":"2007-08-23T20:38:18Z","receivedAt":"2007-08-23T20:38:18Z","isPatch":false,"sender":{"key":"bdowning@lavos.net","avatar":"https://avatars.githubusercontent.com/u/366426?v=4"},"body":"On Thu, Aug 23, 2007 at 03:30:24PM -0500, Brian Downing wrote:\n> This commit:\n> \n> commit a13ee29b975d3a9a012983309e842d942b2bbd44\n> \n> seems to have broken the \"Stage Hunk For Commit\" option entirely for me\n> -- it is now disabled whether or not there is a patch in the viewer.\n\nSorry, I just saw the following commit in the git-gui tree:\n\nce015c213fbef39140b6192db28110bc666dc6c8 \ngit-gui: Paper bag fix \"Stage Hunk For Commit\" in diff context menu\n\nSo it appears this issue is known.  Sorry about the noise.\n\n(Though this will be merged before 1.5.3, right?)\n\n-bcd\n"},{"id":"51417","messageId":"20070824030808.GT27913@spearce.org","threadId":"9626","inReplyTo":"20070823203818.GG21692@lavos.net","subject":"Re: [BUG] git-gui: \"Stage Hunk For Commit\" doesn't work at all anymore","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-08-24T03:08:08Z","receivedAt":"2007-08-24T03:08:08Z","isPatch":false,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Brian Downing <bdowning@lavos.net> wrote:\n> On Thu, Aug 23, 2007 at 03:30:24PM -0500, Brian Downing wrote:\n> > This commit:\n> > \n> > commit a13ee29b975d3a9a012983309e842d942b2bbd44\n> > \n> > seems to have broken the \"Stage Hunk For Commit\" option entirely for me\n> > -- it is now disabled whether or not there is a patch in the viewer.\n\nYea, that commit was a dud.  I noticed it myself a few days ago\nand fixed the dang thing.  I don't know what I was thinking when\nI made that commit...\n \n> Sorry, I just saw the following commit in the git-gui tree:\n> \n> ce015c213fbef39140b6192db28110bc666dc6c8 \n> git-gui: Paper bag fix \"Stage Hunk For Commit\" in diff context menu\n> \n> So it appears this issue is known.  Sorry about the noise.\n\nNo problem.  Better that someone raises an issue than just pretend\nlike its not there...\n \n> (Though this will be merged before 1.5.3, right?)\n\nYes.  It will be in git-gui 0.8.2, which Junio has agreed to merge\ninto 1.5.3 before it goes final.  I'll likely tag git-gui 0.8.2\ntomorrow, then ask him to pull when he has the chance.\n\n-- \nShawn.\n"}]}