{"thread":{"id":"9592","subject":"Suprising error message from \"git clone\"","startedAt":"2007-08-20T14:45:31Z","lastAt":"2007-08-20T21:25:40Z","messageCount":4,"participants":["Matthieu Moy","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"51091","messageId":"vpqwsvqmfhw.fsf@bauges.imag.fr","threadId":"9592","inReplyTo":null,"subject":"Suprising error message from \"git clone\"","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@imag.fr","sentAt":"2007-08-20T14:45:31Z","receivedAt":"2007-08-20T14:45:31Z","isPatch":false,"sender":{"key":"git@matthieu-moy.fr","avatar":"https://avatars.githubusercontent.com/u/14709?v=4"},"body":"Hi,\n\nI got a suprising error message:\n\n$ cd /tmp/\n$ git clone ~/some/repository\nInitialized empty Git repository in /tmp/repository/.git/\nWarning: -l asked but cannot hardlink to /home/moy/some/repository/.git\n114 blocks\n$ \n\nI understand that git found the path to be local, and tried to\nhardlink, but it shouldn't say \"-l asked\", since I didn't ask for it.\n\nEither the message should be changed to stg like \"Warning: cannot\nhardlink to %s\" or it should just be skipped if -l was not actually\nprovided.\n\n-- \nMatthieu\n"},{"id":"51125","messageId":"7vr6lyrlbb.fsf@gitster.siamese.dyndns.org","threadId":"9592","inReplyTo":"vpqwsvqmfhw.fsf@bauges.imag.fr","subject":"Re: Suprising error message from \"git clone\"","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-08-20T20:40:56Z","receivedAt":"2007-08-20T20:40:56Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Matthieu Moy writes:\n\n> I got a suprising error message:\n>\n> $ cd /tmp/\n> $ git clone ~/some/repository\n> Initialized empty Git repository in /tmp/repository/.git/\n> Warning: -l asked but cannot hardlink to /home/moy/some/repository/.git\n\nYup, we already discussed when we switched to defaulting to -l,\nbut nobody cared enough to get around to patch the warning.\n\nUntested but something like this should suffice...\n\nBy the way, could you possibly drop Mail-Followup-To: please?\n\n git-clone.sh | 5 ++++-\n 1 files changed, 4 insertions(+), 1 deletions(-)\n\ndiff --git a/git-clone.sh b/git-clone.sh\nindex e4a9ac4..18003ab 100755\n--- a/git-clone.sh\n+++ b/git-clone.sh\n@@ -99,6 +99,7 @@ origin_override=\n use_separate_remote=t\n depth=\n no_progress=\n+local_explicitly_asked_for=\n test -t 1 || no_progress=--no-progress\n while\n \tcase \"$#,$1\" in\n@@ -109,6 +110,7 @@ while\n \t*,--na|*,--nak|*,--nake|*,--naked|\\\n \t*,-b|*,--b|*,--ba|*,--bar|*,--bare) bare=yes ;;\n \t*,-l|*,--l|*,--lo|*,--loc|*,--loca|*,--local)\n+\t local_explicitly_asked_for=yes\n \t use_local_hardlink=yes ;;\n \t*,--no-h|*,--no-ha|*,--no-har|*,--no-hard|*,--no-hardl|\\\n \t*,--no-hardli|*,--no-hardlin|*,--no-hardlink|*,--no-hardlinks)\n@@ -281,7 +283,8 @@ yes)\n \t\t\tthen\n \t\t\t\trm -f \"$GIT_DIR/objects/sample\"\n \t\t\t\tl=l\n-\t\t\telse\n+\t\t\telif test -n \"$local_explicitly_asked_for\"\n+\t\t\tthen\n \t\t\t\techo >&2 \"Warning: -l asked but cannot hardlink to $repo\"\n \t\t\tfi\n \t\tfi &&\n"},{"id":"51133","messageId":"vpqy7g5zz7h.fsf@bauges.imag.fr","threadId":"9592","inReplyTo":"7vr6lyrlbb.fsf@gitster.siamese.dyndns.org","subject":"Re: Suprising error message from \"git clone\"","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@imag.fr","sentAt":"2007-08-20T21:13:38Z","receivedAt":"2007-08-20T21:13:38Z","isPatch":false,"sender":{"key":"git@matthieu-moy.fr","avatar":"https://avatars.githubusercontent.com/u/14709?v=4"},"body":"Junio C Hamano writes:\n\n> Untested but something like this should suffice...\n\nJest tested, it works fine.\n\n> By the way, could you possibly drop Mail-Followup-To: please?\n\nErr, what's the problem with it? I don't wish to receive duplicate,\nand I ask your mailer not to do so. I don't care too much if the\nheader is not honnored, but what you have to do is just to followup\nwithout bothering about it.\n\n> git-clone.sh | 5 ++++-\n> 1 files changed, 4 insertions(+), 1 deletions(-)\n>\n> diff --git a/git-clone.sh b/git-clone.sh\n> index e4a9ac4..18003ab 100755\n> --- a/git-clone.sh\n> +++ b/git-clone.sh\n> @@ -99,6 +99,7 @@ origin_override=\n> use_separate_remote=t\n> depth=\n> no_progress=\n> +local_explicitly_asked_for=\n> test -t 1 || no_progress=--no-progress\n> while\n> \tcase \"$#,$1\" in\n> @@ -109,6 +110,7 @@ while\n> \t*,--na|*,--nak|*,--nake|*,--naked|\\\n> \t*,-b|*,--b|*,--ba|*,--bar|*,--bare) bare=yes ;;\n> \t*,-l|*,--l|*,--lo|*,--loc|*,--loca|*,--local)\n> +\t local_explicitly_asked_for=yes\n> \t use_local_hardlink=yes ;;\n> \t*,--no-h|*,--no-ha|*,--no-har|*,--no-hard|*,--no-hardl|\\\n> \t*,--no-hardli|*,--no-hardlin|*,--no-hardlink|*,--no-hardlinks)\n> @@ -281,7 +283,8 @@ yes)\n> \t\t\tthen\n> \t\t\t\trm -f \"$GIT_DIR/objects/sample\"\n> \t\t\t\tl=l\n> -\t\t\telse\n> +\t\t\telif test -n \"$local_explicitly_asked_for\"\n> +\t\t\tthen\n> \t\t\t\techo >&2 \"Warning: -l asked but cannot hardlink to $repo\"\n> \t\t\tfi\n> \t\tfi &&\n>\n>\n\n-- \nMatthieu\n"},{"id":"51135","messageId":"7v8x85sxt7.fsf@gitster.siamese.dyndns.org","threadId":"9592","inReplyTo":"vpqy7g5zz7h.fsf@bauges.imag.fr","subject":"Re: Suprising error message from \"git clone\"","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-08-20T21:25:40Z","receivedAt":"2007-08-20T21:25:40Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Matthieu Moy writes:\n\n> Junio C Hamano writes:\n>\n>> Untested but something like this should suffice...\n>\n> Jest tested, it works fine.\n\nThanks.\n\n>> By the way, could you possibly drop Mail-Followup-To: please?\n>\n> Err, what's the problem with it? I don't wish to receive duplicate,\n> and I ask your mailer not to do so. I don't care too much if the\n> header is not honnored, but what you have to do is just to followup\n> without bothering about it.\n\nFor example, your response had this:\n\n Mail-Followup-To: Junio C Hamano ,\n\t git \n\nSuppose somebody else who read your message on the git list has\nsomething to say to _YOU_. Maybe he is pointing out some of the\nproblems in _your_ thinking. He may not mind me hearing what he\ntells you, but he is primarily talking to you.\n\nAlthough in practice I tend to pay attention to whatever is said\non the git mailing list, I certainly do not want _my_ address on\nthe To: header of such a response. He wants to talk to _you_,\nnot me, and I process mails addressed \"To: \" me, and then only\nwhen I have enough time to do so move on to other messages.\n\nYou either (1) stole time from me by forcing his message\naddressed \"To: \" me, or (2) if the person who responded to your\nmessage were kind and careful enough to \"fix\" the header so that\nthe message is addressed to you and demoting me to the Cc: list,\nthen you stole time from him.\n\nWith (1) you are being rude against me, and with (2) you are\nbeing rude against whoever responds to you.\n\nPlease don't.\n\nFiltering duplicates on the receiving end in your mailbox should\nnot be too much of a hassle, either.\n"}]}