{"thread":{"id":"948","subject":"[PATCH 1/1] Fix to bug introduced into rev-list.c by [PATCH 5/7] Move...","startedAt":"2005-06-15T10:34:38Z","lastAt":"2005-06-15T10:34:38Z","messageCount":1,"participants":["Jon Seymour"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"4970","messageId":"20050615103438.16891.qmail@blackcubes.dyndns.org","threadId":"948","inReplyTo":null,"subject":"[PATCH 1/1] Fix to bug introduced into rev-list.c by [PATCH 5/7] Move...","fromName":"Jon Seymour","fromEmail":"jon.seymour@gmail.com","sentAt":"2005-06-15T10:34:38Z","receivedAt":"2005-06-15T10:34:38Z","isPatch":true,"sender":{"key":"jon.seymour@gmail.com","avatar":"https://avatars.githubusercontent.com/u/207131?v=4"},"body":"\nThis fixes a problem introduced in the following patch:\n\t[PATCH 5/7] Move knowledge of UNINTERESTING flag into rev-list.c\n\nI have also included a unit test that would detect this kind of error\nin future.\n\nSigned-off-by: Jon Seymour <jon.seymour@gmail.com>\n\n---\n\nNote: as of the time of writing, this patch had not yet been\nmerged with Linus' head.\n\nFor ease of reference, the set of pending changes still to be\napplied (in application orderevese order of app;lication) \n\n[PATCH] Fix to bug introduced into rev-list.c by [PATCH 5/7] Move...\n[PATCH 7/7] Move traversal parts of epoch.[ch] into traversal.[ch]\n[PATCH 6/7] Remove DUPCHECK, UNINTERESTING flags from epoch.h\n[PATCH 5/7] Move knowledge of UNINTERESTING flag into rev-list.c\n[PATCH 4/7] Move two general purpose commit-related functions into commit.[ch]\n[PATCH 3/7] Rename epoch.c entry points as traverse_* methods/stuctures\n[PATCH 2/7] Introduce new methods into the epoch_methods structure.\n[PATCH 1/7] Additional --merge-order tests and general cleanup of t/t6001-rev-list-merge-order.sh\n[PATCH 2/2] Add support for author-oriented git-rev-list switches [rev 11]\n[PATCH 1/2] Changes to non-epoch.c code required for author-oriented git-rev-list changes\n---\n\n rev-list.c                      |    2 +-\n t/t6001-rev-list-merge-order.sh |   26 ++++++++++++++++++++++++++\n 2 files changed, 27 insertions(+), 1 deletions(-)\n\ndiff --git a/rev-list.c b/rev-list.c\n--- a/rev-list.c\n+++ b/rev-list.c\n@@ -91,7 +91,7 @@ static int process_commit(struct commit \n \tif (commit->object.flags & UNINTERESTING)\n \t\tstop_traversal = 1;\n \n-\tif (action & STOP) {\n+\tif (action == STOP) {\n \t\treturn STOP;\n \t}\n \ndiff --git a/t/t6001-rev-list-merge-order.sh b/t/t6001-rev-list-merge-order.sh\n--- a/t/t6001-rev-list-merge-order.sh\n+++ b/t/t6001-rev-list-merge-order.sh\n@@ -464,6 +464,32 @@ test_output_expect_success \"linear prune\n = l5\n EOF\n \n+test_output_expect_success \"max-count 10 - merge order\" 'git-rev-list --show-breaks --max-count=10 l5' <<EOF\n+= l5\n+| l4\n+| l3\n+= a4\n+| c3\n+| c2\n+| c1\n+^ b4\n+| b3\n+| b2\n+EOF\n+\n+test_output_expect_success \"max-count 10 - non merge order\" 'git-rev-list --max-count=10 l5 | sort' <<EOF\n+a4\n+b2\n+b3\n+b4\n+c1\n+c2\n+c3\n+l3\n+l4\n+l5\n+EOF\n+\n test_expect_failure \"all heads uninteresting\" 'git-rev-list --show-breaks a3 ^a3'\n #\n #\n------------\n"}]}