{"thread":{"id":"9427","subject":"[PATCH] send-email: don't add sender to Cc: if --suppress-from is given.","startedAt":"2007-08-07T13:12:37Z","lastAt":"2007-08-07T13:12:37Z","messageCount":1,"participants":["Uwe Kleine-König"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"50122","messageId":"1186492357499-git-send-email-ukleinek@informatik.uni-freiburg.de","threadId":"9427","inReplyTo":null,"subject":"[PATCH] send-email: don't add sender to Cc: if --suppress-from is given.","fromName":"Uwe Kleine-König","fromEmail":"ukleinek@informatik.uni-freiburg.de","sentAt":"2007-08-07T13:12:37Z","receivedAt":"2007-08-07T13:12:37Z","isPatch":true,"sender":{"key":"u.kleine-koenig@pengutronix.de","avatar":"https://gravatar.com/avatar/354b5e3ceb2806a2f1e1e382ac29ddbdad18288654da62b61eb13583a857eee7?d=mp&s=160"},"body":"Up to now the sender is added to the Cc: list for Signed-off-by and Cc\nlines even if --suppress-from is requested.\n\nSigned-off-by: Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de>\n---\nHello,\n\nMaybe the address should be added for a Cc: line, but not for\nSigned-off-by?\n\nBest regards\nUwe\n\n git-send-email.perl |    8 +++++---\n 1 files changed, 5 insertions(+), 3 deletions(-)\n\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex 39e433b..9d7f6a8 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -646,9 +646,11 @@ foreach my $t (@files) {\n \t\t\tif (/^(Signed-off-by|Cc): (.*)$/i && $signed_off_cc) {\n \t\t\t\tmy $c = $2;\n \t\t\t\tchomp $c;\n-\t\t\t\tpush @cc, $c;\n-\t\t\t\tprintf(\"(sob) Adding cc: %s from line '%s'\\n\",\n-\t\t\t\t\t$c, $_) unless $quiet;\n+\t\t\t\tif (not $suppress_from or unquote_rfc2047($c) eq $from) {\n+\t\t\t\t\tpush @cc, $c;\n+\t\t\t\t\tprintf(\"(sob) Adding cc: %s from line '%s'\\n\",\n+\t\t\t\t\t\t$c, $_) unless $quiet;\n+\t\t\t\t}\n \t\t\t}\n \t\t}\n \t}\n-- \n1.5.3.rc3.13.g7ab3\n"}]}