{"thread":{"id":"941","subject":"cg-restore - restoring modified files","startedAt":"2005-06-15T01:45:21Z","lastAt":"2005-07-29T08:48:03Z","messageCount":2,"participants":["Pavel Roskin","Petr Baudis"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"4962","messageId":"1118799921.3890.45.camel@dv","threadId":"941","inReplyTo":null,"subject":"cg-restore - restoring modified files","fromName":"Pavel Roskin","fromEmail":"proski@gnu.org","sentAt":"2005-06-15T01:45:21Z","receivedAt":"2005-06-15T01:45:21Z","isPatch":false,"sender":{"key":"proski@gnu.org","avatar":null},"body":"Hello!\n\nI believe the documented behavior of cg-restore is inconsistent.\n\n\"Restore given files to their original state. Without any parameters, it\nrecovers any files removed locally whose removal was not recorded by\n`cg-rm`.\"\n\nI interpret it that cg-restore without arguments restores removed files\nbut not modified ones.\n\n\"If passed a set of file names, it restores those files to their state\nas of the last commit (including bringing files removed with cg-rm back\nto life; FIXME: does not do that part yet).\"\n\nI interpret it that cg-restore with arguments restores both removed and\nmodified files.\n\nMaybe we need an option whether to restore modified files?  Or maybe\nthey should always be restored (I think it would more consistent)?  Then\nthe help text should be more clear about modified files.\n\nThe actual behavior is that modified files are never restored.  We need\n\"-f\" option for git-checkout-cache to overwrite existing files, and it's\nnot used whether the filenames are specified or not.  I wanted to send a\npatch, but after reading help I'm not sure what exactly cg-restore is\nsupposed to do.\n\n-- \nRegards,\nPavel Roskin\n\n"},{"id":"6565","messageId":"20050729084801.GK24895@pasky.ji.cz","threadId":"941","inReplyTo":"1118799921.3890.45.camel@dv","subject":"Re: cg-restore - restoring modified files","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2005-07-29T08:48:03Z","receivedAt":"2005-07-29T08:48:03Z","isPatch":false,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Umm. I just discovered a portion of mailing list I somehow completely\nmissed. :/ Sorry for the delayed replies.\n\nDear diary, on Wed, Jun 15, 2005 at 03:45:21AM CEST, I got a letter\nwhere Pavel Roskin <proski@gnu.org> told me that...\n> Hello!\n\nHi,\n\n> I believe the documented behavior of cg-restore is inconsistent.\n> \n> \"Restore given files to their original state. Without any parameters, it\n> recovers any files removed locally whose removal was not recorded by\n> `cg-rm`.\"\n> \n> I interpret it that cg-restore without arguments restores removed files\n> but not modified ones.\n> \n> \"If passed a set of file names, it restores those files to their state\n> as of the last commit (including bringing files removed with cg-rm back\n> to life; FIXME: does not do that part yet).\"\n> \n> I interpret it that cg-restore with arguments restores both removed and\n> modified files.\n> \n> Maybe we need an option whether to restore modified files?  Or maybe\n> they should always be restored (I think it would more consistent)?  Then\n> the help text should be more clear about modified files.\n> \n> The actual behavior is that modified files are never restored.  We need\n> \"-f\" option for git-checkout-cache to overwrite existing files, and it's\n> not used whether the filenames are specified or not.  I wanted to send a\n> patch, but after reading help I'm not sure what exactly cg-restore is\n> supposed to do.\n\nin the meantime, I actually implemented the -f option. Now I agree that\ncg-rm'd files should indeed be restored only when -f is passed. Not a\nbig deal yet since we don't remove them at all now. :-)\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\nIf you want the holes in your knowledge showing up try teaching\nsomeone.  -- Alan Cox\n"}]}