{"thread":{"id":"9353","subject":"[PATCH] Fix documentation for core.gitproxy to reflect code","startedAt":"2007-08-02T12:23:34Z","lastAt":"2007-08-02T23:07:45Z","messageCount":4,"participants":["David Symonds","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"49418","messageId":"ee77f5c20708020523m1a243bf2g9778994441cd21d5@mail.gmail.com","threadId":"9353","inReplyTo":null,"subject":"[PATCH] Fix documentation for core.gitproxy to reflect code","fromName":"David Symonds","fromEmail":"dsymonds@gmail.com","sentAt":"2007-08-02T12:23:34Z","receivedAt":"2007-08-02T12:23:34Z","isPatch":true,"sender":{"key":"dsymonds@gmail.com","avatar":"https://gravatar.com/avatar/b22f5051cbfc11836e36cf7a690e6cde4e225d835e13295ff98d15c7a9ee3c0f?d=mp&s=160"},"body":"This is with respect to my earlier email about core.gitproxy. I\nfigured since 1.5.3 is looming it would be best to get the\ndocumentation correct, then nag about the feature later!\n\nDave.\n\n---\n Documentation/config.txt     |    2 +-\n Documentation/git-config.txt |    4 +---\n 2 files changed, 2 insertions(+), 4 deletions(-)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex 3135cb7..de9e72b 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -101,7 +101,7 @@ Example\n\n \t# Proxy settings\n \t[core]\n-\t\tgitProxy=\"ssh\" for \"ssh://kernel.org/\"\n+\t\tgitProxy=\"ssh\" for \"kernel.org\"\n \t\tgitProxy=default-proxy ; for the rest\n\n Variables\ndiff --git a/Documentation/git-config.txt b/Documentation/git-config.txt\nindex 8451ccc..c3dffff 100644\n--- a/Documentation/git-config.txt\n+++ b/Documentation/git-config.txt\n@@ -214,9 +214,7 @@ Given a .git/config like this:\n\n \t; Proxy settings\n \t[core]\n-\t\tgitproxy=\"ssh\" for \"ssh://kernel.org/\"\n \t\tgitproxy=\"proxy-command\" for kernel.org\n-\t\tgitproxy=\"myprotocol-command\" for \"my://\"\n \t\tgitproxy=default-proxy ; for all the rest\n\n you can set the filemode to true with\n@@ -291,7 +289,7 @@ To actually match only values with an exclamation\nmark, you have to\n To add a new proxy, without altering any of the existing ones, use\n\n ------------\n-% git config core.gitproxy '\"proxy\" for example.com'\n+% git config core.gitproxy '\"proxy-command\" for example.com'\n ------------\n\n\n-- \n1.5.2.4\n"},{"id":"49463","messageId":"7vtzrhvgpc.fsf@assigned-by-dhcp.cox.net","threadId":"9353","inReplyTo":"ee77f5c20708020523m1a243bf2g9778994441cd21d5@mail.gmail.com","subject":"Re: [PATCH] Fix documentation for core.gitproxy to reflect code","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-08-02T20:12:31Z","receivedAt":"2007-08-02T20:12:31Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"David Symonds\" <dsymonds@gmail.com> writes:\n\n> This is with respect to my earlier email about core.gitproxy. I\n> figured since 1.5.3 is looming it would be best to get the\n> documentation correct, then nag about the feature later!\n>\n> Dave.\n\nThat's not a commit log message.\n\nIf the existing example does not work, then please say that you\nfixed it (i.e. \"The values in the example does not work.  The\naccepted forms are such and such and such, so use them in the\nexample\") in the log message.  \"Your earlier email\" does not\ncount.  People who are reading the \"git log\" output would not\nhave easy access to it.\n\nIf core.gitproxy is not documented (I suspect the parts you\ntouched are not about \"how to use core.gitproxy\" but \"what's the\nsyntax of a configuration file\" example), it needs its own\nproper entry in config.txt.  If it has one, but if you feel it\nneeds more explanation or exmples, that section needs to be\nupdated.\n\nPlease retry.\n"},{"id":"49505","messageId":"ee77f5c20708021545s54bc226ds4c1c4589c6617c00@mail.gmail.com","threadId":"9353","inReplyTo":"7vtzrhvgpc.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] Fix documentation for core.gitproxy to reflect code","fromName":"David Symonds","fromEmail":"dsymonds@gmail.com","sentAt":"2007-08-02T22:45:56Z","receivedAt":"2007-08-02T22:45:56Z","isPatch":true,"sender":{"key":"dsymonds@gmail.com","avatar":"https://gravatar.com/avatar/b22f5051cbfc11836e36cf7a690e6cde4e225d835e13295ff98d15c7a9ee3c0f?d=mp&s=160"},"body":"The current implementation of core.gitproxy only operates on git:// URLs, so\nthe ssh:// examples and custom protocol examples have been removed or edited.\n---\n Documentation/config.txt     |    2 +-\n Documentation/git-config.txt |    4 +---\n 2 files changed, 2 insertions(+), 4 deletions(-)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex 3135cb7..de9e72b 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -101,7 +101,7 @@ Example\n\n        # Proxy settings\n        [core]\n-               gitProxy=\"ssh\" for \"ssh://kernel.org/\"\n+               gitProxy=\"ssh\" for \"kernel.org\"\n                gitProxy=default-proxy ; for the rest\n\n Variables\ndiff --git a/Documentation/git-config.txt b/Documentation/git-config.txt\nindex 8451ccc..c3dffff 100644\n--- a/Documentation/git-config.txt\n+++ b/Documentation/git-config.txt\n@@ -214,9 +214,7 @@ Given a .git/config like this:\n\n        ; Proxy settings\n        [core]\n-               gitproxy=\"ssh\" for \"ssh://kernel.org/\"\n                gitproxy=\"proxy-command\" for kernel.org\n-               gitproxy=\"myprotocol-command\" for \"my://\"\n                gitproxy=default-proxy ; for all the rest\n\n you can set the filemode to true with\n@@ -291,7 +289,7 @@ To actually match only values with an exclamation mark, you\nhave to\n To add a new proxy, without altering any of the existing ones, use\n\n ------------\n-% git config core.gitproxy '\"proxy\" for example.com'\n+% git config core.gitproxy '\"proxy-command\" for example.com'\n ------------\n\n\n-- \n1.5.2.4\n"},{"id":"49509","messageId":"7vsl71sfge.fsf@assigned-by-dhcp.cox.net","threadId":"9353","inReplyTo":"ee77f5c20708021545s54bc226ds4c1c4589c6617c00@mail.gmail.com","subject":"Re: [PATCH] Fix documentation for core.gitproxy to reflect code","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-08-02T23:07:45Z","receivedAt":"2007-08-02T23:07:45Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks.  Much better and to the point.\n\nI really appreciate your extra effort.\n"}]}