{"thread":{"id":"9329","subject":"[PATCH] Mention libiconv as a requirement for git-am","startedAt":"2007-07-31T15:09:48Z","lastAt":"2007-08-01T03:36:31Z","messageCount":4,"participants":["Nguyen Thai Ngoc Duy","Han-Wen Nienhuys"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"49230","messageId":"20070731150948.GA9947@localhost","threadId":"9329","inReplyTo":null,"subject":"[PATCH] Mention libiconv as a requirement for git-am","fromName":"Nguyen Thai Ngoc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2007-07-31T15:09:48Z","receivedAt":"2007-07-31T15:09:48Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"---\n Han-Wen, any chance to include libiconv to the installer? You may need\n to set NEEDS_ICONV, ICONVDIR and NO_ICONV properly to make git-am work.\n\n README.MinGW | 1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/README.MinGW b/README.MinGW\nindex 89b7065..c0b8f66 100644\n--- a/README.MinGW\n+++ b/README.MinGW\n@@ -28,6 +28,7 @@ In order to compile this code you need:\n \tzlib-1.2.3-mingwPORT-1.tar\n \tw32api-3.6.tar.gz\n \ttcltk-8.4.1-1.exe (for gitk, git-gui)\n+\tlibiconv-1.9.2-1-{lib,bin}.zip (for git-am, from http://gnuwin32.sourceforge.net/packages/libiconv.htm)\n \n \n STATUS\n-- \n1.5.0.7\n"},{"id":"49272","messageId":"f329bf540707312003i60e910e9kf97d2f50fdecbed2@mail.gmail.com","threadId":"9329","inReplyTo":"20070731150948.GA9947@localhost","subject":"Re: [PATCH] Mention libiconv as a requirement for git-am","fromName":"Han-Wen Nienhuys","fromEmail":"hanwenn@gmail.com","sentAt":"2007-08-01T03:03:15Z","receivedAt":"2007-08-01T03:03:15Z","isPatch":true,"sender":{"key":"hanwenn@gmail.com","avatar":"https://gravatar.com/avatar/058832acb8d613baeb6ce9d21b009d9772424a309b9a521330423daef909a27a?d=mp&s=160"},"body":"libiconv is already in there, version 1.11,\n\n[lilydev@haring gub]$ grep bin.libiconv\ntarget/mingw/gubfiles/installer-git-master-repo.or.cz-git-mingw.git/files.txt\n\\usr\\bin\\libiconv-2.dll\n\nI don't understand your request: do you want to have some flags added\nto the environment?\n\n2007/7/31, Nguyen Thai Ngoc Duy :\n> ---\n> Han-Wen, any chance to include libiconv to the installer? You may need\n> to set NEEDS_ICONV, ICONVDIR and NO_ICONV properly to make git-am work.\n>\n> README.MinGW | 1 +\n> 1 files changed, 1 insertions(+), 0 deletions(-)\n>\n> diff --git a/README.MinGW b/README.MinGW\n> index 89b7065..c0b8f66 100644\n> --- a/README.MinGW\n> +++ b/README.MinGW\n> @@ -28,6 +28,7 @@ In order to compile this code you need:\n> zlib-1.2.3-mingwPORT-1.tar\n> w32api-3.6.tar.gz\n> tcltk-8.4.1-1.exe (for gitk, git-gui)\n> + libiconv-1.9.2-1-{lib,bin}.zip (for git-am, from http://gnuwin32.sourceforge.net/packages/libiconv.htm)\n>\n>\n> STATUS\n> --\n> 1.5.0.7\n>\n\n\n-- \nHan-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen\n"},{"id":"49273","messageId":"fcaeb9bf0707312018p25297d76g50489fa303856dd6@mail.gmail.com","threadId":"9329","inReplyTo":"f329bf540707312003i60e910e9kf97d2f50fdecbed2@mail.gmail.com","subject":"Re: [PATCH] Mention libiconv as a requirement for git-am","fromName":"Nguyen Thai Ngoc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2007-08-01T03:18:28Z","receivedAt":"2007-08-01T03:18:28Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"I'm sorry I judged by reading Makefile without actually testing your\ninstallation, so I might be wrong. By default Makefile set\nNO_ICONV=YesPlease on MinGW so it won't use libiconv even if it\nexists. You need to unset NO_ICONV and set NEEDS_LIBICONV in\nconfig.mak in order to enable it.\n\nI'm going to test it tomorrow.\n\nOn 7/31/07, Han-Wen Nienhuys wrote:\n> libiconv is already in there, version 1.11,\n>\n> [lilydev@haring gub]$ grep bin.libiconv\n> target/mingw/gubfiles/installer-git-master-repo.or.cz-git-mingw.git/files.txt\n> \\usr\\bin\\libiconv-2.dll\n>\n> I don't understand your request: do you want to have some flags added\n> to the environment?\n>\n> 2007/7/31, Nguyen Thai Ngoc Duy :\n> > ---\n> > Han-Wen, any chance to include libiconv to the installer? You may need\n> > to set NEEDS_ICONV, ICONVDIR and NO_ICONV properly to make git-am work.\n> >\n> > README.MinGW | 1 +\n> > 1 files changed, 1 insertions(+), 0 deletions(-)\n> >\n> > diff --git a/README.MinGW b/README.MinGW\n> > index 89b7065..c0b8f66 100644\n> > --- a/README.MinGW\n> > +++ b/README.MinGW\n> > @@ -28,6 +28,7 @@ In order to compile this code you need:\n> > zlib-1.2.3-mingwPORT-1.tar\n> > w32api-3.6.tar.gz\n> > tcltk-8.4.1-1.exe (for gitk, git-gui)\n> > + libiconv-1.9.2-1-{lib,bin}.zip (for git-am, from http://gnuwin32.sourceforge.net/packages/libiconv.htm)\n> >\n> >\n> > STATUS\n> > --\n> > 1.5.0.7\n> >\n>\n>\n> --\n> Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen\n>\n\n\n-- \nDuy\n"},{"id":"49275","messageId":"f329bf540707312036v26e553d6n2b0f99e53ca0aabb@mail.gmail.com","threadId":"9329","inReplyTo":"fcaeb9bf0707312018p25297d76g50489fa303856dd6@mail.gmail.com","subject":"Re: [PATCH] Mention libiconv as a requirement for git-am","fromName":"Han-Wen Nienhuys","fromEmail":"hanwenn@gmail.com","sentAt":"2007-08-01T03:36:31Z","receivedAt":"2007-08-01T03:36:31Z","isPatch":true,"sender":{"key":"hanwenn@gmail.com","avatar":"https://gravatar.com/avatar/058832acb8d613baeb6ce9d21b009d9772424a309b9a521330423daef909a27a?d=mp&s=160"},"body":"2007/8/1, Nguyen Thai Ngoc Duy :\n> I'm sorry I judged by reading Makefile without actually testing your\n> installation, so I might be wrong. By default Makefile set\n> NO_ICONV=YesPlease on MinGW so it won't use libiconv even if it\n> exists. You need to unset NO_ICONV and set NEEDS_LIBICONV in\n> config.mak in order to enable it.\n\nthis is done automatically when running configure. If you find a\nproblem with the installer please let me know.\n\n> I'm going to test it tomorrow.\n\n\n\n-- \nHan-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen\n"}]}