{"thread":{"id":"9324","subject":"[RFC/PATCH 2/2] gitweb: Add an option to show size of blobs in the tree view","startedAt":"2007-07-31T11:19:49Z","lastAt":"2007-08-02T20:47:27Z","messageCount":11,"participants":["Jakub Narebski","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"49207","messageId":"1185880790812-git-send-email-jnareb@gmail.com","threadId":"9324","inReplyTo":null,"subject":"[PATCH 1/2] gitweb: Allow for multivalued parameters passed to href subroutine","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-07-31T11:19:49Z","receivedAt":"2007-07-31T11:19:49Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Make it possible to generate URLs with multivalued parameters in the\nhref() subroutine, via passing reference to array of values.\n\nExample:\n href(action=>\"log\", extra_options=>[\"--no-merges\", \"--first-parent\"])\n\nThis also allows for easy passing back (replaying) current value\nof, possibly multivalued, extra_options ('opt') parameter, using:\n\n href(..., extra_options=>\\@extra_options)\n\nwhich would be required when we start using extra_options in gitweb,\nand would want to preserve its value. For example when creating links\nto next/previous page of 'log' or 'history' view output, we would want\nto preserve '--no-merges' and/or '-first-parent' extra options.\n\nSigned-off-by: Jakub Narebski \n---\nThis is the same patch as sent earlier, but with more detailed commit\nmessage. As the previous version made it into git.git, this is just\nfor archives.\n\n gitweb/gitweb.perl | 8 +++++++-\n 1 files changed, 7 insertions(+), 1 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 8a32899..498b936 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -629,7 +629,13 @@ sub href(%) {\n \tfor (my $i = 0; $i < @mapping; $i += 2) {\n \t\tmy ($name, $symbol) = ($mapping[$i], $mapping[$i+1]);\n \t\tif (defined $params{$name}) {\n-\t\t\tpush @result, $symbol . \"=\" . esc_param($params{$name});\n+\t\t\tif (ref($params{$name}) eq \"ARRAY\") {\n+\t\t\t\tforeach my $par (@{$params{$name}}) {\n+\t\t\t\t\tpush @result, $symbol . \"=\" . esc_param($par);\n+\t\t\t\t}\n+\t\t\t} else {\n+\t\t\t\tpush @result, $symbol . \"=\" . esc_param($params{$name});\n+\t\t\t}\n \t\t}\n \t}\n \t$href .= \"?\" . join(';', @result) if scalar @result;\n-- \n1.5.2.4\n"},{"id":"49206","messageId":"11858807944170-git-send-email-jnareb@gmail.com","threadId":"9324","inReplyTo":"1185880790812-git-send-email-jnareb@gmail.com","subject":"[RFC/PATCH 2/2] gitweb: Add an option to show size of blobs in the tree view","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-07-31T11:19:50Z","receivedAt":"2007-07-31T11:19:50Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Add support for extra option ('opt' parameter) '-l' for the 'tree'\nview, to show (in separate column, between mode and filename) the size\nof blobs (files). This option is passed through to all the 'tree'\nlinks, so from 'tree' view with size of blobs on go to 'tree' view\nalso with size of blobs.\n\nFor the 'tree' and 'commit' (submodule) entries, '-' is shown in place\nof size.\n\nCurrently you have to add \";opt=-l\" to URL by hand to start.\n\nSigned-off-by: Jakub Narebski \n---\nThis patch is an example of using infrastructure introduced by the\nearlier patch: \n gitweb: Allow for multivalued parameters passed to href subroutine\n\nIt allows to play with 'tree' view with blob size. Currently you\nhave to start browsing by adding \";opt=-l\" to the gitweb URL by\nhand. There is not link which will change view from ordinary 'tree'\nview to 'tree' view with blob sizes.\n\nThe 'tree' with blob size view is slightly more costly than the\nordinary, old 'tree' view, but not much more (0.018s vs 0.012s\nin the hot cache case), so I don't think we need to control it\nas a enabled (or disabled) feature, overrideable or not. It\nprobably should not be default.\n\nWhat do you think about this?\n\n gitweb/gitweb.css | 5 ++++\n gitweb/gitweb.perl | 53 ++++++++++++++++++++++++++++++++++++++-------------\n 2 files changed, 44 insertions(+), 14 deletions(-)\n\ndiff --git a/gitweb/gitweb.css b/gitweb/gitweb.css\nindex 096313b..dd24546 100644\n--- a/gitweb/gitweb.css\n+++ b/gitweb/gitweb.css\n@@ -326,6 +326,11 @@ td.mode {\n \tfont-family: monospace;\n }\n \n+td.size {\n+\tfont-family: monospace;\n+\ttext-align: right;\n+}\n+\n /* styling of diffs (patchsets): commitdiff and blobdiff views */\n div.diff.header,\n div.diff.extended_header {\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 498b936..97ad1da 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -432,6 +432,7 @@ if (defined $hash_base) {\n \n my %allowed_options = (\n \t\"--no-merges\" => [ qw(rss atom log shortlog history) ],\n+\t\"-l\" => [ qw(tree) ],\n );\n \n our @extra_options = $cgi->param('opt');\n@@ -1998,16 +1999,31 @@ sub parse_ls_tree_line ($;%) {\n \tmy %opts = @_;\n \tmy %res;\n \n-\t#'100644 blob 0fa3f3a66fb6a137f6ec2c19351ed4d807070ffa\tpanic.c'\n-\t$line =~ m/^([0-9]+) (.+) ([0-9a-fA-F]{40})\\t(.+)$/s;\n+\tif ($opts{'-l'}) {\n+\t\t#'100644 blob 0fa3f3a66fb6a137f6ec2c19351ed4d807070ffa 16717\tpanic.c'\n+\t\t$line =~ m/^([0-9]+) (.+) ([0-9a-fA-F]{40}) +(-|[0-9]+)\\t(.+)$/s;\n \n-\t$res{'mode'} = $1;\n-\t$res{'type'} = $2;\n-\t$res{'hash'} = $3;\n-\tif ($opts{'-z'}) {\n-\t\t$res{'name'} = $4;\n+\t\t$res{'mode'} = $1;\n+\t\t$res{'type'} = $2;\n+\t\t$res{'hash'} = $3;\n+\t\t$res{'size'} = $4;\n+\t\tif ($opts{'-z'}) {\n+\t\t\t$res{'name'} = $5;\n+\t\t} else {\n+\t\t\t$res{'name'} = unquote($5);\n+\t\t}\n \t} else {\n-\t\t$res{'name'} = unquote($4);\n+\t\t#'100644 blob 0fa3f3a66fb6a137f6ec2c19351ed4d807070ffa\tpanic.c'\n+\t\t$line =~ m/^([0-9]+) (.+) ([0-9a-fA-F]{40})\\t(.+)$/s;\n+\n+\t\t$res{'mode'} = $1;\n+\t\t$res{'type'} = $2;\n+\t\t$res{'hash'} = $3;\n+\t\tif ($opts{'-z'}) {\n+\t\t\t$res{'name'} = $4;\n+\t\t} else {\n+\t\t\t$res{'name'} = unquote($4);\n+\t\t}\n \t}\n \n \treturn wantarray ? %res : \\%res;\n@@ -2679,6 +2695,9 @@ sub git_print_tree_entry {\n \t# and link is the action links of the entry.\n \n \tprint \"\" . mode_str($t->{'mode'}) . \"\\n\";\n+\tif (exists $t->{'size'}) {\n+\t\tprint \"$t->{'size'}\\n\";\n+\t}\n \tif ($t->{'type'} eq \"blob\") {\n \t\tprint \"\" .\n \t\t\t$cgi->a({-href => href(action=>\"blob\", hash=>$t->{'hash'},\n@@ -4268,8 +4287,9 @@ sub git_tree {\n \t\t\t$hash = $hash_base;\n \t\t}\n \t}\n+\n \t$/ = \"\\0\";\n-\topen my $fd, \"-|\", git_cmd(), \"ls-tree\", '-z', $hash\n+\topen my $fd, \"-|\", git_cmd(), \"ls-tree\", '-z', @extra_options, $hash\n \t\tor die_error(undef, \"Open git-ls-tree failed\");\n \tmy @entries = map { chomp; $_ } <$fd>;\n \tclose $fd or die_error(undef, \"Reading tree failed\");\n@@ -4280,6 +4300,7 @@ sub git_tree {\n \tgit_header_html();\n \tmy $basedir = '';\n \tmy ($have_blame) = gitweb_check_feature('blame');\n+\tmy $show_sizes = grep(/^-l$/, @extra_options);\n \tif (defined $hash_base && (my %co = parse_commit($hash_base))) {\n \t\tmy @views_nav = ();\n \t\tif (defined $file_name) {\n@@ -4288,7 +4309,8 @@ sub git_tree {\n \t\t\t\t hash=>$hash, file_name=>$file_name)},\n \t\t\t\t \"history\"),\n \t\t\t\t$cgi->a({-href => href(action=>\"tree\",\n-\t\t\t\t hash_base=>\"HEAD\", file_name=>$file_name)},\n+\t\t\t\t hash_base=>\"HEAD\", file_name=>$file_name,\n+\t\t\t\t extra_options=>\\@extra_options)},\n \t\t\t\t \"HEAD\"),\n \t\t}\n \t\tmy $snapshot_links = format_snapshot_links($hash);\n@@ -4296,7 +4318,8 @@ sub git_tree {\n \t\t\t# FIXME: Should be available when we have no hash base as well.\n \t\t\tpush @views_nav, $snapshot_links;\n \t\t}\n-\t\tgit_print_page_nav('tree','', $hash_base, undef, undef, join(' | ', @views_nav));\n+\t\tgit_print_page_nav('tree','', $hash_base, undef, undef,\n+\t\t join(' | ', @views_nav));\n \t\tgit_print_header_div('commit', esc_html($co{'title'}) . $ref, $hash_base);\n \t} else {\n \t\tundef $hash_base;\n@@ -4330,8 +4353,10 @@ sub git_tree {\n \t\t# based on git_print_tree_entry\n \t\tprint '' . mode_str('040000') . \"\\n\";\n \t\tprint '';\n-\t\tprint $cgi->a({-href => href(action=>\"tree\", hash_base=>$hash_base,\n-\t\t file_name=>$up)},\n+\t\tprint $cgi->a({-href => href(action=>\"tree\",\n+\t\t hash_base=>$hash_base,\n+\t\t file_name=>$up,\n+\t\t extra_options=>\\@extra_options)},\n \t\t \"..\");\n \t\tprint \"\\n\";\n \t\tprint \"\\n\";\n@@ -4339,7 +4364,7 @@ sub git_tree {\n \t\tprint \"\\n\";\n \t}\n \tforeach my $line (@entries) {\n-\t\tmy %t = parse_ls_tree_line($line, -z => 1);\n+\t\tmy %t = parse_ls_tree_line($line, -z => 1, -l => $show_sizes);\n \n \t\tif ($alternate) {\n \t\t\tprint \"\\n\";\n-- \n1.5.2.4\n"},{"id":"49249","messageId":"7vd4y8fcjw.fsf@assigned-by-dhcp.cox.net","threadId":"9324","inReplyTo":"11858807944170-git-send-email-jnareb@gmail.com","subject":"Re: [RFC/PATCH 2/2] gitweb: Add an option to show size of blobs in the tree view","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-07-31T22:12:03Z","receivedAt":"2007-07-31T22:12:03Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jakub Narebski writes:\n\n> It allows to play with 'tree' view with blob size. Currently you\n> have to start browsing by adding \";opt=-l\" to the gitweb URL by\n> hand. There is not link which will change view from ordinary 'tree'\n> view to 'tree' view with blob sizes.\n>\n> The 'tree' with blob size view is slightly more costly than the\n> ordinary, old 'tree' view, but not much more (0.018s vs 0.012s\n> in the hot cache case), so I don't think we need to control it\n> as a enabled (or disabled) feature, overrideable or not. It\n> probably should not be default.\n\nI do not think there is any reason to forbid its use, as the\n\"-l\" to ls-tree was introduced for exactly this purpose,\nHowever, it might make sense to make the use of -l optional via\nthe %feature mechanism. 50% increase even on hot cache case is\nnot a price people who run busy sites would want to pay.\n"},{"id":"49251","messageId":"f8ofc2$o0$1@sea.gmane.org","threadId":"9324","inReplyTo":"11858807944170-git-send-email-jnareb@gmail.com","subject":"Re: [RFC/PATCH 2/2] gitweb: Add an option to show size of blobs in the tree view","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-07-31T23:07:46Z","receivedAt":"2007-07-31T23:07:46Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Gaah, I just find that I forgot in some places to preserve \"-l\"...\nPlease wait for amended patch.\n\n-- \nJakub Narebski\n"},{"id":"49355","messageId":"200708011505.02078.jnareb@gmail.com","threadId":"9324","inReplyTo":"7vd4y8fcjw.fsf@assigned-by-dhcp.cox.net","subject":"Re: [RFC/PATCH 2/2] gitweb: Add an option to show size of blobs in the tree view","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-08-01T13:05:01Z","receivedAt":"2007-08-01T13:05:01Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"On Wed, 1 Aug 2007, Junio C Hamano wrote:\n> Jakub Narebski writes:\n> \n>> It allows to play with 'tree' view with blob size. Currently you\n>> have to start browsing by adding \";opt=-l\" to the gitweb URL by\n>> hand. There is not link which will change view from ordinary 'tree'\n>> view to 'tree' view with blob sizes.\n>>\n>> The 'tree' with blob size view is slightly more costly than the\n>> ordinary, old 'tree' view, but not much more (0.018s vs 0.012s\n>> in the hot cache case), so I don't think we need to control it\n>> as a enabled (or disabled) feature, overrideable or not. It\n>> probably should not be default.\n> \n> I do not think there is any reason to forbid its use, as the\n> \"-l\" to ls-tree was introduced for exactly this purpose,\n> However, it might make sense to make the use of -l optional via\n> the %feature mechanism. 50% increase even on hot cache case is\n> not a price people who run busy sites would want to pay.\n\nIt's 0.014s vs 0.009s - 0.010s on root dir of repacked git.git \nrepository. It is I think caused by the fact that \"git ls-tree -l \n\" has to look up each blob in the tree, and read its\nheader. IIRC header is uncompressed, so it doesn't need deflating;\nif it is compressed, then we have to add deflating to that. The\nblob size (object size) is not present in the tree object structure.\nPerhaps it is something to have in mind when designing and implementing\nnew packv4 with its creating tree objects on demand.\n\nBut I agree that this should be protected by the %feature mechanism.\nTwo questions:\n\n 1. Should we make '-l' default when turned on? Or make 'showsizes'\n %feature tristate: off, on, by default on?\n\n 2. If it is turned off, should we silently (or not so silently)\n ignore this option, or return \"Permission denied\" or perhaps\n \"Invalid extra options parameter\"?\n\nAnd how we should name this feature (key in %feature hash)?\n\n\nP.S. I have received no comments on\n [RFC/PATCH] gitweb: Enable transparent compression for HTTP output\n(trade CPU load for lower bandwidth usage).\n\n-- \nJakub Narebski\nPoland\n"},{"id":"49369","messageId":"7v3az24zo6.fsf@assigned-by-dhcp.cox.net","threadId":"9324","inReplyTo":"200708011505.02078.jnareb@gmail.com","subject":"Re: [RFC/PATCH 2/2] gitweb: Add an option to show size of blobs in the tree view","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-08-01T23:12:41Z","receivedAt":"2007-08-01T23:12:41Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jakub Narebski writes:\n\n> But I agree that this should be protected by the %feature mechanism.\n> Two questions:\n>\n> 1. Should we make '-l' default when turned on? Or make 'showsizes'\n> %feature tristate: off, on, by default on?\n>\n> 2. If it is turned off, should we silently (or not so silently)\n> ignore this option, or return \"Permission denied\" or perhaps\n> \"Invalid extra options parameter\"?\n>\n> And how we should name this feature (key in %feature hash)?\n\nI would say we would not do this by default, only with an\nexplicit override with gitweb-config.perl. I am not sure what\nthe good name would be. \"expensive-ls-tree\" perhaps?\n\n> P.S. I have received no comments on\n> [RFC/PATCH] gitweb: Enable transparent compression for HTTP output\n> (trade CPU load for lower bandwidth usage).\n\nThat's probably nobody was interested in it.\n"},{"id":"49374","messageId":"200708020158.50343.jnareb@gmail.com","threadId":"9324","inReplyTo":"7v3az24zo6.fsf@assigned-by-dhcp.cox.net","subject":"Re: [RFC/PATCH 2/2] gitweb: Add an option to show size of blobs in the tree view","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-08-01T23:58:50Z","receivedAt":"2007-08-01T23:58:50Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Junio C Hamano wrote:\n> Jakub Narebski writes:\n> \n>> But I agree that this should be protected by the %feature mechanism.\n>> Two questions:\n>>\n>> 1. Should we make '-l' default when turned on? Or make 'showsizes'\n>> %feature tristate: off, on, by default on?\n>>\n>> 2. If it is turned off, should we silently (or not so silently)\n>> ignore this option, or return \"Permission denied\" or perhaps\n>> \"Invalid extra options parameter\"?\n>>\n>> And how we should name this feature (key in %feature hash)?\n> \n> I would say we would not do this by default, only with an\n> explicit override with gitweb-config.perl. I am not sure what\n> the good name would be. \"expensive-ls-tree\" perhaps?\n\nSo you think that \";opt=-l\" would be required to have 'tree' view with \nblob (file) sizes, and it would be allowed only if \ngitweb_check_feature('ls-tree-size') is true (or something like that).\nShould we return \"Permission denied\" or simply ignore \"-l\" extra option \nif it is prohivited by the config?\n\nAs to good name: 'showsize'? 'ls-tree-size'? 'ls-tree--long'?\n\n>> P.S. I have received no comments on\n>> [RFC/PATCH] gitweb: Enable transparent compression for HTTP output\n>> (trade CPU load for lower bandwidth usage).\n> \n> That's probably nobody was interested in it.\n\nWell, it was also posted in the middle of old thread... \n\n-- \nJakub Narebski\nPoland\n"},{"id":"49378","messageId":"7vps263gq2.fsf@assigned-by-dhcp.cox.net","threadId":"9324","inReplyTo":"200708020158.50343.jnareb@gmail.com","subject":"Re: [RFC/PATCH 2/2] gitweb: Add an option to show size of blobs in the tree view","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-08-02T00:47:17Z","receivedAt":"2007-08-02T00:47:17Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jakub Narebski writes:\n\n> So you think that \";opt=-l\" would be required to have 'tree' view with \n> blob (file) sizes, and it would be allowed only if \n> gitweb_check_feature('ls-tree-size') is true (or something like that).\n> Should we return \"Permission denied\" or simply ignore \"-l\" extra option \n> if it is prohivited by the config?\n\nI would say we should make config show-tree-entry-size (or\nwhatever name) unconditionally give the object size of the tree\nentry, and drop \";opt=-l in URL\" support from the code. In\nother words, if the site/repo owner wants to show it, it is\nshown to everybody, otherwise nothing is shown.\n\nKeeping the URL clean and without needless variations would help\ncaching; I do not see major advantage of this feature one way or\nthe other, so if we can keep a tree view of the same object from\nthe same repository the same by removing one user preference,\nthat would be better.\n"},{"id":"49386","messageId":"7vtzri1pfi.fsf@assigned-by-dhcp.cox.net","threadId":"9324","inReplyTo":"200708020158.50343.jnareb@gmail.com","subject":"Re: [RFC/PATCH 2/2] gitweb: Add an option to show size of blobs in the tree view","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-08-02T05:22:09Z","receivedAt":"2007-08-02T05:22:09Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jakub Narebski writes:\n\n>>> P.S. I have received no comments on\n>>> [RFC/PATCH] gitweb: Enable transparent compression for HTTP output\n>>> (trade CPU load for lower bandwidth usage).\n>> \n>> That's probably nobody was interested in it.\n>\n> Well, it was also posted in the middle of old thread... \n\nThere probably is some of that as well.\n\nPersonally, this late in the game, I would be more interested in\nresolving the File::Find() stuff, which has been a real issue in\nthe field, than the compressed transfer one.\n"},{"id":"49456","messageId":"200708021247.08612.jnareb@gmail.com","threadId":"9324","inReplyTo":"7vtzri1pfi.fsf@assigned-by-dhcp.cox.net","subject":"Re: [RFC/PATCH 2/2] gitweb: Add an option to show size of blobs in the tree view","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-08-02T10:47:07Z","receivedAt":"2007-08-02T10:47:07Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Junio C Hamano wrote:\n\n> Personally, this late in the game, I would be more interested in\n> resolving the File::Find() stuff, which has been a real issue in\n> the field, than the compressed transfer one.\n\nI posted my tentative Ack, haven't I?\n\nI guess that your solution is good, and doesn't have any drawbacks,\nbesides perhaps a tiny little bit of lost performance. So I think\nthat you should just commit this...\n\n\nAs to the new stuff: I think I postpone large changes, like blob\nsize in tree view, or links to no merges and first parent \nlog/shortlog/history view, or list form of two pipelines we have in \ngitweb, or HTML cleanup, etc. after the v1.5.3 release.\n\n-- \nJakub Narebski\nPoland\n"},{"id":"49477","messageId":"7vhcnhvf34.fsf@assigned-by-dhcp.cox.net","threadId":"9324","inReplyTo":"200708021247.08612.jnareb@gmail.com","subject":"Re: [RFC/PATCH 2/2] gitweb: Add an option to show size of blobs in the tree view","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-08-02T20:47:27Z","receivedAt":"2007-08-02T20:47:27Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jakub Narebski writes:\n\n> Junio C Hamano wrote:\n>\n>> Personally, this late in the game, I would be more interested in\n>> resolving the File::Find() stuff, which has been a real issue in\n>> the field, than the compressed transfer one.\n>\n> I posted my tentative Ack, haven't I?\n>\n> I guess that your solution is good, and doesn't have any drawbacks,\n> besides perhaps a tiny little bit of lost performance. So I think\n> that you should just commit this...\n>\n>\n> As to the new stuff: I think I postpone large changes, like blob\n> size in tree view, or links to no merges and first parent \n> log/shortlog/history view, or list form of two pipelines we have in \n> gitweb, or HTML cleanup, etc. after the v1.5.3 release.\n\nThanks, alright, I am relieved to know that we are on the same\npage.\n"}]}