{"thread":{"id":"9295","subject":"[PATCH] add option to find zlib in custom path","startedAt":"2007-07-29T18:35:45Z","lastAt":"2007-08-01T01:21:38Z","messageCount":4,"participants":["Robert Schiele","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"49003","messageId":"20070729183545.GC29424@schiele.dyndns.org","threadId":"9295","inReplyTo":null,"subject":"[PATCH] add option to find zlib in custom path","fromName":"Robert Schiele","fromEmail":"rschiele@gmail.com","sentAt":"2007-07-29T18:35:45Z","receivedAt":"2007-07-29T18:35:45Z","isPatch":true,"sender":{"key":"rschiele@gmail.com","avatar":"https://gravatar.com/avatar/409473567eb2287d5f0157b51f5b703994b347f24f92172e3a0588741c27a492?d=mp&s=160"},"body":"Some systems do not provide zlib development headers and libraries in\ndefault search path of the compiler.  For these systems we should allow\nspecifying the location by --with-zlib=PATH or by setting ZLIB_PATH in\nthe makefile.\n\nSigned-off-by: Robert Schiele <rschiele@gmail.com>\n---\n\nYou can also fetch this patch as d669d5f17feb3b406862fd83b42998b2353da44f from\ngit://schiele.dyndns.org/git\n\n Makefile     |    8 +++++++-\n configure.ac |    3 +++\n 2 files changed, 10 insertions(+), 1 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 73b487f..21bf5c7 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -372,7 +372,7 @@ BUILTIN_OBJS = \\\n \tbuiltin-pack-refs.o\n \n GITLIBS = $(LIB_FILE) $(XDIFF_LIB)\n-EXTLIBS = -lz\n+EXTLIBS =\n \n #\n # Platform specific tweaks\n@@ -517,6 +517,12 @@ ifndef NO_CURL\n \tendif\n endif\n \n+ifdef ZLIB_PATH\n+\tBASIC_CFLAGS += -I$(ZLIB_PATH)/include\n+\tEXTLIBS += -L$(ZLIB_PATH)/lib $(CC_LD_DYNPATH)$(ZLIB_PATH)/lib\n+endif\n+EXTLIBS += -lz\n+\n ifndef NO_OPENSSL\n \tOPENSSL_LIBSSL = -lssl\n \tifdef OPENSSLDIR\ndiff --git a/configure.ac b/configure.ac\nindex 50d2b85..b2f1965 100644\n--- a/configure.ac\n+++ b/configure.ac\n@@ -75,6 +75,9 @@ GIT_ARG_SET_PATH(shell)\n # Define PERL_PATH to provide path to Perl.\n GIT_ARG_SET_PATH(perl)\n #\n+# Define ZLIB_PATH to provide path to zlib.\n+GIT_ARG_SET_PATH(zlib)\n+#\n # Declare the with-tcltk/without-tcltk options.\n AC_ARG_WITH(tcltk,\n AS_HELP_STRING([--with-tcltk],[use Tcl/Tk GUI (default is YES)])\n-- \n1.5.2.3\n"},{"id":"49263","messageId":"20070801010156.GF29424@schiele.dyndns.org","threadId":"9295","inReplyTo":"20070729183545.GC29424@schiele.dyndns.org","subject":"Re: [PATCH] add option to find zlib in custom path","fromName":"Robert Schiele","fromEmail":"rschiele@gmail.com","sentAt":"2007-08-01T01:01:56Z","receivedAt":"2007-08-01T01:01:56Z","isPatch":true,"sender":{"key":"rschiele@gmail.com","avatar":"https://gravatar.com/avatar/409473567eb2287d5f0157b51f5b703994b347f24f92172e3a0588741c27a492?d=mp&s=160"},"body":"On Sun, Jul 29, 2007 at 08:35:45PM +0200, Robert Schiele wrote:\n> Some systems do not provide zlib development headers and libraries in\n> default search path of the compiler.  For these systems we should allow\n> specifying the location by --with-zlib=PATH or by setting ZLIB_PATH in\n> the makefile.\n\nJust wanted to ping about that patch I sent.  After I did not get any response\non earlier patches I sent I found that they did not comply to the patch\nsubmission policy.  Thus I did this one according to the policy (as far as I\nunderstand it but still don't get any reply.\n\nSo I just wanted to ask what's the cause of that?\n\nDidn't you just have time to look at it?\n\nDid I do something wrong?  In that case it would be useful if I knew what it\nis.\n\nAny other reason?\n\nI mean if it is a timing issue it is not a big issue.  Just wanted to know\nwhether it does make sense to submit more patches or if they all get lost for\nsome reason I am currently not aware of.\n\nRobert\n\n-- \nRobert Schiele\nDipl.-Wirtsch.informatiker\tmailto:rschiele@gmail.com\n\n\"Quidquid latine dictum sit, altum sonatur.\"\n"},{"id":"49264","messageId":"7v7iogdpw5.fsf@assigned-by-dhcp.cox.net","threadId":"9295","inReplyTo":"20070801010156.GF29424@schiele.dyndns.org","subject":"Re: [PATCH] add option to find zlib in custom path","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-08-01T01:06:50Z","receivedAt":"2007-08-01T01:06:50Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Queued already, integration tested last night, been too busy to\npush it out.\n\nPatience, Ok?\n"},{"id":"49266","messageId":"20070801012137.GG29424@schiele.dyndns.org","threadId":"9295","inReplyTo":"7v7iogdpw5.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] add option to find zlib in custom path","fromName":"Robert Schiele","fromEmail":"rschiele@gmail.com","sentAt":"2007-08-01T01:21:38Z","receivedAt":"2007-08-01T01:21:38Z","isPatch":true,"sender":{"key":"rschiele@gmail.com","avatar":"https://gravatar.com/avatar/409473567eb2287d5f0157b51f5b703994b347f24f92172e3a0588741c27a492?d=mp&s=160"},"body":"On Tue, Jul 31, 2007 at 06:06:50PM -0700, Junio C Hamano wrote:\n> Queued already, integration tested last night, been too busy to\n> push it out.\n> \n> Patience, Ok?\n\nSure, that's perferctly ok.  Take the time you need.  Just wanted to know that\nthere is nothing wrong in principle with the patches so that I could do more\nwithout wasting time.\n\nRobert\n\n-- \nRobert Schiele\nDipl.-Wirtsch.informatiker\tmailto:rschiele@gmail.com\n\n\"Quidquid latine dictum sit, altum sonatur.\"\n"}]}