{"thread":{"id":"9243","subject":"git-gui problem with version number.","startedAt":"2007-07-26T11:20:02Z","lastAt":"2007-07-29T09:08:30Z","messageCount":11,"participants":["David Kastrup","Shawn O. Pearce"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"48690","messageId":"86odhzpg2l.fsf@lola.quinscape.zz","threadId":"9243","inReplyTo":null,"subject":"git-gui problem with version number.","fromName":"David Kastrup","fromEmail":"dak@gnu.org","sentAt":"2007-07-26T11:20:02Z","receivedAt":"2007-07-26T11:20:02Z","isPatch":false,"sender":{"key":"dak@gnu.org","avatar":"https://avatars.githubusercontent.com/u/52141349?v=4"},"body":"\nHi, git-gui does not get along with the creativeness in git\nversioning:\n\ngit-gui\nError in startup script: expected version number but got \"1.5.3.rc2.4.g726f9-dirty\"\n while executing\n\"package vcompare $_git_version $vr\"\n (\"2\" arm line 4)\n invoked from within\n\"switch [llength $args] {\n 0 {\n return $_git_version\n }\n\n 2 {\n set op [lindex $args 0]\n set vr [lindex $args 1]\n set cm [package vcompare $_git_ver...\"\n (procedure \"git-version\" line 4)\n invoked from within\n\"git-version < 1.5\"\n (file \"/usr/local/bin/git-gui\" line 1)\n\n\n-- \nDavid Kastrup\n"},{"id":"48756","messageId":"20070727044634.GG20052@spearce.org","threadId":"9243","inReplyTo":"86odhzpg2l.fsf@lola.quinscape.zz","subject":"Re: git-gui problem with version number.","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-07-27T04:46:34Z","receivedAt":"2007-07-27T04:46:34Z","isPatch":false,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"David Kastrup wrote:\n> Hi, git-gui does not get along with the creativeness in git\n> versioning:\n\nWhat version of git-gui? gitgui-0.7.5-67-g91464df and later have\nfixes to handle all of the fun cases in git versioning. Like the\none you have here.\n \n> git-gui\n> Error in startup script: expected version number but got \"1.5.3.rc2.4.g726f9-dirty\"\n> while executing\n> \"package vcompare $_git_version $vr\"\n\n-- \nShawn.\n"},{"id":"48762","messageId":"85y7h25sg6.fsf@lola.goethe.zz","threadId":"9243","inReplyTo":"20070727044634.GG20052@spearce.org","subject":"Re: git-gui problem with version number.","fromName":"David Kastrup","fromEmail":"dak@gnu.org","sentAt":"2007-07-27T05:25:13Z","receivedAt":"2007-07-27T05:25:13Z","isPatch":false,"sender":{"key":"dak@gnu.org","avatar":"https://avatars.githubusercontent.com/u/52141349?v=4"},"body":"\"Shawn O. Pearce\" writes:\n\n> David Kastrup wrote:\n>> Hi, git-gui does not get along with the creativeness in git\n>> versioning:\n>\n> What version of git-gui? gitgui-0.7.5-67-g91464df and later have\n> fixes to handle all of the fun cases in git versioning. Like the\n> one you have here.\n> \n>> git-gui\n>> Error in startup script: expected version number but got \"1.5.3.rc2.4.g726f9-dirty\"\n>> while executing\n>> \"package vcompare $_git_version $vr\"\n\nThe one coming with the mentioned version number. I suspect that this\nmay be a matter of the Perl libraries being used: I experience this on\nan Ubuntu Dapper, but not on other (newer) systems compiled from the\nsame source.\n\n-- \nDavid Kastrup, Kriemhildstr. 15, 44793 Bochum\n"},{"id":"48764","messageId":"20070727053627.GI20052@spearce.org","threadId":"9243","inReplyTo":"85y7h25sg6.fsf@lola.goethe.zz","subject":"Re: git-gui problem with version number.","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-07-27T05:36:27Z","receivedAt":"2007-07-27T05:36:27Z","isPatch":false,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"David Kastrup wrote:\n> \"Shawn O. Pearce\" writes:\n> \n> > David Kastrup wrote:\n> >> Hi, git-gui does not get along with the creativeness in git\n> >> versioning:\n> >\n> > What version of git-gui? gitgui-0.7.5-67-g91464df and later have\n> > fixes to handle all of the fun cases in git versioning. Like the\n> > one you have here.\n> > \n> >> git-gui\n> >> Error in startup script: expected version number but got \"1.5.3.rc2.4.g726f9-dirty\"\n> >> while executing\n> >> \"package vcompare $_git_version $vr\"\n> \n> The one coming with the mentioned version number. I suspect that this\n> may be a matter of the Perl libraries being used: I experience this on\n> an Ubuntu Dapper, but not on other (newer) systems compiled from the\n> same source.\n\nAh. Junio hasn't pulled those version numbering fixes from me yet.\nBecause I haven't asked him to pull in a while. That explains that.\n\nThere's no Perl involved in git-gui, except for the Perl in an\nunderlying Git command it might invoke. So perhaps you were\ntalking about Tcl above?\n\nAnyway, you can setup a build with the most recent 'stable\ndevelopment' version of git-gui:\n\n git checkout -b with-new-gitgui\n git pull -s subtree git://repo.or.cz/git-gui.git\n\nThat's really all Junio does. Although I think he does actually try\nto test it briefly before pushing a final release out to the public.\nJust to make sure Git hasn't broken anything really obvious in\ngit-gui. ;-)\n\n-- \nShawn.\n"},{"id":"48767","messageId":"85odhy5rm6.fsf@lola.goethe.zz","threadId":"9243","inReplyTo":"20070727053627.GI20052@spearce.org","subject":"Re: git-gui problem with version number.","fromName":"David Kastrup","fromEmail":"dak@gnu.org","sentAt":"2007-07-27T05:43:13Z","receivedAt":"2007-07-27T05:43:13Z","isPatch":false,"sender":{"key":"dak@gnu.org","avatar":"https://avatars.githubusercontent.com/u/52141349?v=4"},"body":"\"Shawn O. Pearce\" writes:\n\n> David Kastrup wrote:\n>> \n>> The one coming with the mentioned version number. I suspect that\n>> this may be a matter of the Perl libraries being used: I experience\n>> this on an Ubuntu Dapper, but not on other (newer) systems compiled\n>> from the same source.\n>\n> Ah. Junio hasn't pulled those version numbering fixes from me yet.\n> Because I haven't asked him to pull in a while. That explains that.\n>\n> There's no Perl involved in git-gui, except for the Perl in an\n> underlying Git command it might invoke. So perhaps you were talking\n> about Tcl above?\n\nUh, whatever this backtrace was in... I did not look too closely.\n\n> Anyway, you can setup a build with the most recent 'stable\n> development' version of git-gui:\n>\n> git checkout -b with-new-gitgui\n> git pull -s subtree git://repo.or.cz/git-gui.git\n\nOk. Would the necessity for this depend on the Tcl version?\n\n-- \nDavid Kastrup, Kriemhildstr. 15, 44793 Bochum\n"},{"id":"48768","messageId":"20070727054815.GJ20052@spearce.org","threadId":"9243","inReplyTo":"85odhy5rm6.fsf@lola.goethe.zz","subject":"Re: git-gui problem with version number.","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-07-27T05:48:15Z","receivedAt":"2007-07-27T05:48:15Z","isPatch":false,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"David Kastrup wrote:\n> \"Shawn O. Pearce\" writes:\n> > Anyway, you can setup a build with the most recent 'stable\n> > development' version of git-gui:\n> >\n> > git checkout -b with-new-gitgui\n> > git pull -s subtree git://repo.or.cz/git-gui.git\n> \n> Ok. Would the necessity for this depend on the Tcl version?\n\nI thought all versions of Tcl did not understand the 'creative'\ngit version strings. So I'm surprised to hear it works on one\nsystem but not on another, even though you have the same version\nof git and git-gui.\n\n-- \nShawn.\n"},{"id":"48770","messageId":"85ejiu5r9r.fsf@lola.goethe.zz","threadId":"9243","inReplyTo":"20070727054815.GJ20052@spearce.org","subject":"Re: git-gui problem with version number.","fromName":"David Kastrup","fromEmail":"dak@gnu.org","sentAt":"2007-07-27T05:50:40Z","receivedAt":"2007-07-27T05:50:40Z","isPatch":false,"sender":{"key":"dak@gnu.org","avatar":"https://avatars.githubusercontent.com/u/52141349?v=4"},"body":"\"Shawn O. Pearce\" writes:\n\n> David Kastrup wrote:\n>> \"Shawn O. Pearce\" writes:\n>> > Anyway, you can setup a build with the most recent 'stable\n>> > development' version of git-gui:\n>> >\n>> > git checkout -b with-new-gitgui\n>> > git pull -s subtree git://repo.or.cz/git-gui.git\n>> \n>> Ok. Would the necessity for this depend on the Tcl version?\n>\n> I thought all versions of Tcl did not understand the 'creative'\n> git version strings. So I'm surprised to hear it works on one\n> system but not on another, even though you have the same version\n> of git and git-gui.\n\nI'll check once I am at work, but I am pretty sure that the versions\nare pretty much in synch.\n\n-- \nDavid Kastrup, Kriemhildstr. 15, 44793 Bochum\n"},{"id":"48777","messageId":"86k5smnvhw.fsf@lola.quinscape.zz","threadId":"9243","inReplyTo":"85ejiu5r9r.fsf@lola.goethe.zz","subject":"Re: git-gui problem with version number.","fromName":"David Kastrup","fromEmail":"dak@gnu.org","sentAt":"2007-07-27T07:42:03Z","receivedAt":"2007-07-27T07:42:03Z","isPatch":false,"sender":{"key":"dak@gnu.org","avatar":"https://avatars.githubusercontent.com/u/52141349?v=4"},"body":"David Kastrup writes:\n\n> \"Shawn O. Pearce\" writes:\n>\n>> David Kastrup wrote:\n>>> \"Shawn O. Pearce\" writes:\n>>> > Anyway, you can setup a build with the most recent 'stable\n>>> > development' version of git-gui:\n>>> >\n>>> > git checkout -b with-new-gitgui\n>>> > git pull -s subtree git://repo.or.cz/git-gui.git\n>>> \n>>> Ok. Would the necessity for this depend on the Tcl version?\n>>\n>> I thought all versions of Tcl did not understand the 'creative'\n>> git version strings. So I'm surprised to hear it works on one\n>> system but not on another, even though you have the same version\n>> of git and git-gui.\n>\n> I'll check once I am at work, but I am pretty sure that the versions\n> are pretty much in synch.\n\nNow that is funny. I am pretty sure (or rather _have_ been pretty\nsure) that I cloned the respective repositories with the same command.\nYet now both are up-to-date according to git-pull (and have identical\n.config contents), and the first compiles version git version\n1.5.3.rc2.41.gb47b1 while the second compiles version\n1.5.3.rc3.7.gd58e-dirty. Both have been cloned from git.git, the\nsecond with\n\n* master\n origin/HEAD\n origin/html\n origin/maint\n origin/man\n origin/master\n origin/next\n origin/pu\n origin/todo\n\nand the first with\n* master\n origin/HEAD\n origin/html\n origin/maint\n origin/man\n origin/master\n origin/next\n origin/pu\n origin/todo\n\nOn the one with the problematic version, I get\ngit-rev-list -2 origin/HEAD |git-name-rev --stdin\nd58e8d34b019d435b424811c6f972910dfac6f55 (master)\n1a44be9a0ff6fa623ff6061992f5ad1831dc7cab (master~1)\n\nand on the other one I get\ngit-rev-list -2 origin/HEAD |git-name-rev --stdin\nd58e8d34b019d435b424811c6f972910dfac6f55 (remotes/origin/HEAD)\n1a44be9a0ff6fa623ff6061992f5ad1831dc7cab (remotes/origin/HEAD~1)\n\ngit-rev-list -2 master |git-name-rev --stdin\n0d59d6cfd3ed2510a8e7d8c9fbc54c21133bc3a6 (master)\nd58e8d34b019d435b424811c6f972910dfac6f55 (remotes/origin/HEAD)\n\nSo let me guess: the \"dirty\" in the version number comes about when\none has changes that are not in the upstream version, and it is this\nstring which confuses git-gui?\n\nBut then the version numbers are _so_ different. I probably am\noverlooking something.\n\n-- \nDavid Kastrup\n"},{"id":"48782","messageId":"86lkd2mcsu.fsf@lola.quinscape.zz","threadId":"9243","inReplyTo":"86k5smnvhw.fsf@lola.quinscape.zz","subject":"Re: git-gui problem with version number.","fromName":"David Kastrup","fromEmail":"dak@gnu.org","sentAt":"2007-07-27T09:11:13Z","receivedAt":"2007-07-27T09:11:13Z","isPatch":false,"sender":{"key":"dak@gnu.org","avatar":"https://avatars.githubusercontent.com/u/52141349?v=4"},"body":"David Kastrup writes:\n\n> Now that is funny. I am pretty sure (or rather _have_ been pretty\n> sure) that I cloned the respective repositories with the same command.\n> Yet now both are up-to-date according to git-pull (and have identical\n> .config contents), and the first compiles version git version\n> 1.5.3.rc2.41.gb47b1 while the second compiles version\n> 1.5.3.rc3.7.gd58e-dirty. Both have been cloned from git.git, the\n\nA combination of rebasing and pushing made the difference go away and\nmade git-gui work again. Nevertheless, it would be a good idea not to\nbalk at the dirty version strings.\n\n-- \nDavid Kastrup\n"},{"id":"48958","messageId":"20070729071030.GL20052@spearce.org","threadId":"9243","inReplyTo":"86lkd2mcsu.fsf@lola.quinscape.zz","subject":"Re: git-gui problem with version number.","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-07-29T07:10:30Z","receivedAt":"2007-07-29T07:10:30Z","isPatch":false,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"David Kastrup wrote:\n> David Kastrup writes:\n> \n> > Now that is funny. I am pretty sure (or rather _have_ been pretty\n> > sure) that I cloned the respective repositories with the same command.\n> > Yet now both are up-to-date according to git-pull (and have identical\n> > .config contents), and the first compiles version git version\n> > 1.5.3.rc2.41.gb47b1 while the second compiles version\n> > 1.5.3.rc3.7.gd58e-dirty. Both have been cloned from git.git, the\n> \n> A combination of rebasing and pushing made the difference go away and\n> made git-gui work again. Nevertheless, it would be a good idea not to\n> balk at the dirty version strings.\n\nDid you not see me already state in this thread that its already\nbeen fixed? Latest git-gui already has the problem dealt with,\nand that latest version will be included in git 1.5.3 when it ships.\n\nNevertheless, thanks for the problem report.\n\n-- \nShawn.\n"},{"id":"48970","messageId":"85ejirziep.fsf@lola.goethe.zz","threadId":"9243","inReplyTo":"20070729071030.GL20052@spearce.org","subject":"Re: git-gui problem with version number.","fromName":"David Kastrup","fromEmail":"dak@gnu.org","sentAt":"2007-07-29T09:08:30Z","receivedAt":"2007-07-29T09:08:30Z","isPatch":false,"sender":{"key":"dak@gnu.org","avatar":"https://avatars.githubusercontent.com/u/52141349?v=4"},"body":"\"Shawn O. Pearce\" writes:\n\n> David Kastrup wrote:\n>> David Kastrup writes:\n>> \n>> > Now that is funny. I am pretty sure (or rather _have_ been pretty\n>> > sure) that I cloned the respective repositories with the same command.\n>> > Yet now both are up-to-date according to git-pull (and have identical\n>> > .config contents), and the first compiles version git version\n>> > 1.5.3.rc2.41.gb47b1 while the second compiles version\n>> > 1.5.3.rc3.7.gd58e-dirty. Both have been cloned from git.git, the\n>> \n>> A combination of rebasing and pushing made the difference go away and\n>> made git-gui work again. Nevertheless, it would be a good idea not to\n>> balk at the dirty version strings.\n>\n> Did you not see me already state in this thread that its already\n> been fixed?\n\nI saw you state that the problem was fixed in your local version, but\nthat this had not been pulled into git.git. So I was adding a vote to\nhave this included.\n\n> Latest git-gui already has the problem dealt with, and that latest\n> version will be included in git 1.5.3 when it ships.\n\nThat is good to hear but it was far from obvious when I wrote the\nabove mail.\n\n> Nevertheless, thanks for the problem report.\n\nYou are welcome.\n\n-- \nDavid Kastrup, Kriemhildstr. 15, 44793 Bochum\n"}]}