{"thread":{"id":"9236","subject":"[PATCH] rebase -i: fix overzealous output redirection","startedAt":"2007-07-26T06:35:51Z","lastAt":"2007-07-26T06:48:16Z","messageCount":3,"participants":["Johannes Schindelin","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"48655","messageId":"Pine.LNX.4.64.0707260735150.14781@racer.site","threadId":"9236","inReplyTo":null,"subject":"[PATCH] rebase -i: fix overzealous output redirection","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-07-26T06:35:51Z","receivedAt":"2007-07-26T06:35:51Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"\nWhen squashing, you no longer saw what the editor had to say to you\nafter commit 'Shut \"git rebase -i\" up when no --verbose was given'\n(if you used a console based editor, at least).\n\nSigned-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n---\n\tThis bit me real hard when cleaning up the work-tree patch\n\tseries.\n\n git-rebase--interactive.sh |    4 +++-\n 1 files changed, 3 insertions(+), 1 deletions(-)\n\ndiff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh\nindex 93289c0..9a88335 100755\n--- a/git-rebase--interactive.sh\n+++ b/git-rebase--interactive.sh\n@@ -250,10 +250,12 @@ do_next () {\n \t\tcase \"$(peek_next_command)\" in\n \t\tsquash)\n \t\t\tEDIT_COMMIT=\n+\t\t\tUSE_OUTPUT=output\n \t\t\tcp \"$MSG\" \"$SQUASH_MSG\"\n \t\t;;\n \t\t*)\n \t\t\tEDIT_COMMIT=-e\n+\t\t\tUSE_OUTPUT=\n \t\t\ttest -f \"$SQUASH_MSG\" && rm \"$SQUASH_MSG\"\n \t\tesac\n \n@@ -267,7 +269,7 @@ do_next () {\n \t\t\t# This is like --amend, but with a different message\n \t\t\teval \"$author_script\"\n \t\t\texport GIT_AUTHOR_NAME GIT_AUTHOR_EMAIL GIT_AUTHOR_DATE\n-\t\t\toutput git commit -F \"$MSG\" $EDIT_COMMIT\n+\t\t\t$USE_OUTPUT git commit -F \"$MSG\" $EDIT_COMMIT\n \t\t\t;;\n \t\tt)\n \t\t\tcp \"$MSG\" \"$GIT_DIR\"/MERGE_MSG\n-- \n1.5.3.rc2.42.gda8d-dirty\n"},{"id":"48656","messageId":"7vejivacun.fsf@assigned-by-dhcp.cox.net","threadId":"9236","inReplyTo":"Pine.LNX.4.64.0707260735150.14781@racer.site","subject":"Re: [PATCH] rebase -i: fix overzealous output redirection","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-07-26T06:38:40Z","receivedAt":"2007-07-26T06:38:40Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:\n\n> When squashing, you no longer saw what the editor had to say to you\n> after commit 'Shut \"git rebase -i\" up when no --verbose was given'\n> (if you used a console based editor, at least).\n>\n> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n> ---\n> \tThis bit me real hard when cleaning up the work-tree patch\n> \tseries.\n\nHeh, good catch.\n\nAt least you are eating your own dog food, which is a very\nassuring thing before the feature release.  Thanks.\n"},{"id":"48660","messageId":"Pine.LNX.4.64.0707260746470.14781@racer.site","threadId":"9236","inReplyTo":"7vejivacun.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] rebase -i: fix overzealous output redirection","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-07-26T06:48:16Z","receivedAt":"2007-07-26T06:48:16Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Wed, 25 Jul 2007, Junio C Hamano wrote:\n\n> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:\n> \n> > When squashing, you no longer saw what the editor had to say to you\n> > after commit 'Shut \"git rebase -i\" up when no --verbose was given'\n> > (if you used a console based editor, at least).\n> >\n> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n> > ---\n> > \tThis bit me real hard when cleaning up the work-tree patch\n> > \tseries.\n> \n> Heh, good catch.\n> \n> At least you are eating your own dog food, which is a very\n> assuring thing before the feature release.  Thanks.\n\nI try my very best!  Though I have to go to bed without having had a \nchance to work on the send-pack bug :-(\n\nGood night, and good luck,\nDscho\n"}]}