{"thread":{"id":"9219","subject":"rc3 gitweb is broken, won't deliver snapshots","startedAt":"2007-07-25T13:27:55Z","lastAt":"2007-07-26T09:17:54Z","messageCount":5,"participants":["Mark Levedahl","Jakub Narebski","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"48561","messageId":"30e4a070707250627l29ce4794x97d03b8232352cae@mail.gmail.com","threadId":"9219","inReplyTo":null,"subject":"rc3 gitweb is broken, won't deliver snapshots","fromName":"Mark Levedahl","fromEmail":"mlevedahl@gmail.com","sentAt":"2007-07-25T13:27:55Z","receivedAt":"2007-07-25T13:27:55Z","isPatch":false,"sender":{"key":"mdl123@verizon.net","avatar":"https://avatars.githubusercontent.com/u/5302462?v=4"},"body":"gitweb in 1.5.3-rc3 fails to deliver snapshots in any useable format\n(bzip2, gz, or zip). Clicking on a link seems to work, but the\ndelivered file as stored on my system is empty. No error messages\nappear anywhere I can find. I am hosting gitweb on FC7 using lighttpd,\nif that matters.\n\nThe snapshot service at git.kernel.org also seems broken, I don't know\nwhat gitweb is running there so don't know if the issue is related.\n\nI have fixed this for my use by reverting the following commits\n\n3473e7df5f8c7f8dc3e2c3f2fdc99a1d1a719c16 gitweb: More detailed error\nmessages for snapshot format\na781785d8f1eb7adf05a24b121104716a086a67a gitweb: Fix support for\nlegacy gitweb config for snapshots\na3c8ab30a54c30a6a434760bedf04548425416ef gitweb: snapshot cleanups &\nsupport for offering multiple formats\n\nThe snapshot problem first appears when a3c8ab30a54 is applied.\n\nMark Levedahl\n"},{"id":"48596","messageId":"11854018464134-git-send-email-jnareb@gmail.com","threadId":"9219","inReplyTo":"30e4a070707250627l29ce4794x97d03b8232352cae@mail.gmail.com","subject":"[PATCH] gitweb: Fix error in generating snapshot","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-07-25T22:17:26Z","receivedAt":"2007-07-25T22:17:26Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"There was an error while generating cmmandline to run git-archive:\nthere were no whitespace between two options.\n\nSigned-off-by: Jakub Narebski <jnareb@gmail.com>\n---\n gitweb/gitweb.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 0acd0ca..b381692 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -4343,7 +4343,7 @@ sub git_snapshot {\n \tmy $cmd;\n \t$filename .= \"-$hash$known_snapshot_formats{$format}{'suffix'}\";\n \t$cmd = \"$git_command archive \" .\n-\t\t\"--format=$known_snapshot_formats{$format}{'format'}\" .\n+\t\t\"--format=$known_snapshot_formats{$format}{'format'} \" .\n \t\t\"--prefix=\\'$name\\'/ $hash\";\n \tif (exists $known_snapshot_formats{$format}{'compressor'}) {\n \t\t$cmd .= ' | ' . join ' ', @{$known_snapshot_formats{$format}{'compressor'}};\n-- \n1.5.2.4\n"},{"id":"48602","messageId":"7vwswocd8d.fsf@assigned-by-dhcp.cox.net","threadId":"9219","inReplyTo":"11854018464134-git-send-email-jnareb@gmail.com","subject":"Re: [PATCH] gitweb: Fix error in generating snapshot","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-07-25T22:47:30Z","receivedAt":"2007-07-25T22:47:30Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Heh, I was working on that and had the identical fix committed\n;-).\n\nThanks.\n"},{"id":"48603","messageId":"7vsl7ccd6o.fsf@assigned-by-dhcp.cox.net","threadId":"9219","inReplyTo":"30e4a070707250627l29ce4794x97d03b8232352cae@mail.gmail.com","subject":"Re: rc3 gitweb is broken, won't deliver snapshots","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-07-25T22:48:31Z","receivedAt":"2007-07-25T22:48:31Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Mark Levedahl\" <mlevedahl@gmail.com> writes:\n\n> gitweb in 1.5.3-rc3 fails to deliver snapshots in any useable format\n> (bzip2, gz, or zip). Clicking on a link seems to work, but the\n> delivered file as stored on my system is empty. No error messages\n> appear anywhere I can find. I am hosting gitweb on FC7 using lighttpd,\n> if that matters.\n>\n> The snapshot service at git.kernel.org also seems broken, I don't know\n> what gitweb is running there so don't know if the issue is related.\n>\n> I have fixed this for my use by reverting the following commits\n>\n> 3473e7df5f8c7f8dc3e2c3f2fdc99a1d1a719c16 gitweb: More detailed error\n> messages for snapshot format\n> a781785d8f1eb7adf05a24b121104716a086a67a gitweb: Fix support for\n> legacy gitweb config for snapshots\n> a3c8ab30a54c30a6a434760bedf04548425416ef gitweb: snapshot cleanups &\n> support for offering multiple formats\n>\n> The snapshot problem first appears when a3c8ab30a54 is applied.\n\nTrue.  I wonder if people who submitted patches even tested\nthese things... Sigh.\n\n---\n\n gitweb/gitweb.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 0acd0ca..b381692 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -4343,7 +4343,7 @@ sub git_snapshot {\n \tmy $cmd;\n \t$filename .= \"-$hash$known_snapshot_formats{$format}{'suffix'}\";\n \t$cmd = \"$git_command archive \" .\n-\t\t\"--format=$known_snapshot_formats{$format}{'format'}\" .\n+\t\t\"--format=$known_snapshot_formats{$format}{'format'} \" .\n \t\t\"--prefix=\\'$name\\'/ $hash\";\n \tif (exists $known_snapshot_formats{$format}{'compressor'}) {\n \t\t$cmd .= ' | ' . join ' ', @{$known_snapshot_formats{$format}{'compressor'}};\n"},{"id":"48683","messageId":"f89os3$arg$1@sea.gmane.org","threadId":"9219","inReplyTo":"11854018464134-git-send-email-jnareb@gmail.com","subject":"Re: [PATCH] gitweb: Fix error in generating snapshot","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-07-26T09:17:54Z","receivedAt":"2007-07-26T09:17:54Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Jakub Narebski wrote:\n\n> There was an error while generating cmmandline to run git-archive:\n> there were no whitespace between two options.\n> \n> Signed-off-by: Jakub Narebski <jnareb@gmail.com>\nNoticed-by: Mark Levedahl <mlevedahl@gmail.com>\n\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"}]}