{"thread":{"id":"9193","subject":"[PATCH/RFH] Mark user-manual as UTF-8","startedAt":"2007-07-24T07:46:35Z","lastAt":"2007-07-24T14:50:31Z","messageCount":5,"participants":["Junio C Hamano","Jeff King","Wincent Colaiuta","Thierry Parmentelat","J. Bruce Fields"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"48403","messageId":"7vwswqgs6c.fsf@assigned-by-dhcp.cox.net","threadId":"9193","inReplyTo":null,"subject":"[PATCH/RFH] Mark user-manual as UTF-8","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-07-24T07:46:35Z","receivedAt":"2007-07-24T07:46:35Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"There have been several complaints against k.org's user-manual\npage. The document is generated in ISO-8859-1 by the xsltproc\ntoolchain (I suspect this is because released docbook.xsl we use\nhas xsl:output element that says the output is ISO-8859-1) but\nserver delivers it with \"charset=UTF-8\", and all h*ll breaks\nloose.\n\nThis attempts to force UTF-8 on the generating end.\n\nSigned-off-by: Junio C Hamano \n---\n\n * I have to warn that I do not really think I know what I am\n doing, but this seems to \"work for me\".\n\n Documentation/Makefile | 2 +-\n Documentation/docbook.xsl | 5 +++++\n 2 files changed, 6 insertions(+), 1 deletions(-)\n create mode 100644 Documentation/docbook.xsl\n\ndiff --git a/Documentation/Makefile b/Documentation/Makefile\nindex b062757..3bc5357 100644\n--- a/Documentation/Makefile\n+++ b/Documentation/Makefile\n@@ -131,7 +131,7 @@ clean:\n user-manual.xml: user-manual.txt user-manual.conf\n \t$(ASCIIDOC) -b docbook -d book $<\n \n-XSLT = http://docbook.sourceforge.net/release/xsl/current/html/docbook.xsl\n+XSLT = docbook.xsl\n XSLTOPTS = --xinclude --stringparam html.stylesheet docbook-xsl.css\n \n user-manual.html: user-manual.xml\ndiff --git a/Documentation/docbook.xsl b/Documentation/docbook.xsl\nnew file mode 100644\nindex 0000000..9a6912c\n--- /dev/null\n+++ b/Documentation/docbook.xsl\n@@ -0,0 +1,5 @@\n+\n+ \n+ \n+\n"},{"id":"48409","messageId":"20070724085340.GA10729@coredump.intra.peff.net","threadId":"9193","inReplyTo":"7vwswqgs6c.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH/RFH] Mark user-manual as UTF-8","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2007-07-24T08:53:41Z","receivedAt":"2007-07-24T08:53:41Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Jul 24, 2007 at 12:46:35AM -0700, Junio C Hamano wrote:\n\n> This attempts to force UTF-8 on the generating end.\n> [...]\n> * I have to warn that I do not really think I know what I am\n> doing, but this seems to \"work for me\".\n\nI'm by no means a docbook expert, but I think what you've done is sane.\nSupposedly there is an xsl:param \"chunker.output.encoding\" which would\nlet you do the same thing from the xsltproc command line, but I can't\nseem to get it to work (and I don't know enough about xsl to even begin\nfiguring out why).\n\n-Peff\n"},{"id":"48433","messageId":"4753DAE3-2F1F-49C0-906A-09CBAF240C87@wincent.com","threadId":"9193","inReplyTo":"7vwswqgs6c.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH/RFH] Mark user-manual as UTF-8","fromName":"Wincent Colaiuta","fromEmail":"win@wincent.com","sentAt":"2007-07-24T10:36:31Z","receivedAt":"2007-07-24T10:36:31Z","isPatch":true,"sender":{"key":"greg@hurrell.net","avatar":"https://avatars.githubusercontent.com/u/7074?v=4"},"body":"El 24/7/2007, a las 9:46, Junio C Hamano escribió:\n\n> There have been several complaints against k.org's user-manual\n> page. The document is generated in ISO-8859-1 by the xsltproc\n> toolchain (I suspect this is because released docbook.xsl we use\n> has xsl:output element that says the output is ISO-8859-1) but\n> server delivers it with \"charset=UTF-8\", and all h*ll breaks\n> loose.\n>\n> This attempts to force UTF-8 on the generating end.\n\nThanks for doing this, Junio. I was one of the people who reported \nthis (although never saw my mail get through to the list).\n\nFunnily, enough, about an hour after you posted your patch another \nemail (\"git documentation - user manual html version has wierd [sic] \ncharacters all over the place\") was posted to the list...\n\nCheers,\nWincent\n"},{"id":"48434","messageId":"46A5D831.6090608@sophia.inria.fr","threadId":"9193","inReplyTo":"4753DAE3-2F1F-49C0-906A-09CBAF240C87@wincent.com","subject":"Re: [PATCH/RFH] Mark user-manual as UTF-8","fromName":"Thierry Parmentelat","fromEmail":"thierry.parmentelat@sophia.inria.fr","sentAt":"2007-07-24T10:45:05Z","receivedAt":"2007-07-24T10:45:05Z","isPatch":true,"sender":{"key":"thierry.parmentelat@sophia.inria.fr","avatar":null},"body":"Hi there - I'm the wierd guy :-)\n\nI've just reloaded the page and the weird stuff has gone.\n\n\nWincent Colaiuta wrote:\n> El 24/7/2007, a las 9:46, Junio C Hamano escribió:\n>\n>> There have been several complaints against k.org's user-manual\n>> page. The document is generated in ISO-8859-1 by the xsltproc\n>> toolchain (I suspect this is because released docbook.xsl we use\n>> has xsl:output element that says the output is ISO-8859-1) but\n>> server delivers it with \"charset=UTF-8\", and all h*ll breaks\n>> loose.\n>>\n>> This attempts to force UTF-8 on the generating end.\n>\n> Thanks for doing this, Junio. I was one of the people who reported \n> this (although never saw my mail get through to the list).\n>\n> Funnily, enough, about an hour after you posted your patch another \n> email (\"git documentation - user manual html version has wierd [sic] \n> characters all over the place\") was posted to the list...\n>\n> Cheers,\n> Wincent\n"},{"id":"48474","messageId":"20070724145031.GB24302@fieldses.org","threadId":"9193","inReplyTo":"7vwswqgs6c.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH/RFH] Mark user-manual as UTF-8","fromName":"J. Bruce Fields","fromEmail":"bfields@fieldses.org","sentAt":"2007-07-24T14:50:31Z","receivedAt":"2007-07-24T14:50:31Z","isPatch":true,"sender":{"key":"bfields@citi.umich.edu","avatar":null},"body":"On Tue, Jul 24, 2007 at 12:46:35AM -0700, Junio C Hamano wrote:\n> There have been several complaints against k.org's user-manual\n> page. The document is generated in ISO-8859-1 by the xsltproc\n> toolchain (I suspect this is because released docbook.xsl we use\n> has xsl:output element that says the output is ISO-8859-1) but\n> server delivers it with \"charset=UTF-8\", and all h*ll breaks\n> loose.\n> \n> This attempts to force UTF-8 on the generating end.\n\nThanks for looking into this! I've seen what I assume is the same\nproblem sporadically before and been unsuccesful at finding the\nsource....\n\n--b.\n"}]}