{"thread":{"id":"9176","subject":"git-gui ignores core.excludesFile","startedAt":"2007-07-23T15:07:00Z","lastAt":"2007-07-29T07:22:47Z","messageCount":2,"participants":["Lars Noschinski","Shawn O. Pearce"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"48313","messageId":"20070723150700.GA17167@lars.home.noschinski.de","threadId":"9176","inReplyTo":null,"subject":"git-gui ignores core.excludesFile","fromName":"Lars Noschinski","fromEmail":"lars@public.noschinski.de","sentAt":"2007-07-23T15:07:00Z","receivedAt":"2007-07-23T15:07:00Z","isPatch":false,"sender":{"key":"lars@public.noschinski.de","avatar":"https://gravatar.com/avatar/ca62bd8b265f2e26c89d39a4bfe7e390bfa6b16d6400e186e222d1c2382c66f2?d=mp&s=160"},"body":"Hello!\n\nIt seems git-gui (0.7.5 from git 1.5.2.4 tarball) ignores the global\nignore file configured with the core.excludesfile option. My\n~/.gitconfig contains\n\n[core]\nexcludesFile = /home/noschinski/.gitignore\n\nwhich is honoured by git-status but not by git-gui.\n\n\nGreetings,\n    Lars.\n"},{"id":"48959","messageId":"20070729072247.GM20052@spearce.org","threadId":"9176","inReplyTo":"20070723150700.GA17167@lars.home.noschinski.de","subject":"Re: git-gui ignores core.excludesFile","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-07-29T07:22:47Z","receivedAt":"2007-07-29T07:22:47Z","isPatch":false,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Lars Noschinski <lars@public.noschinski.de> wrote:\n> It seems git-gui (0.7.5 from git 1.5.2.4 tarball) ignores the global\n> ignore file configured with the core.excludesfile option. My\n> ~/.gitconfig contains\n> \n> [core]\n> excludesFile = /home/noschinski/.gitignore\n> \n> which is honoured by git-status but not by git-gui.\n\nWhoops.  Thanks.  git-gui 0.8.0 will include the following patch:\n\n-->8--\nFrom 94a4dd9bfda79a226f8dd57fd20c39c6603ec194 Mon Sep 17 00:00:00 2001\nFrom: Shawn O. Pearce <spearce@spearce.org>\nDate: Sun, 29 Jul 2007 03:22:27 -0400\nSubject: [PATCH] git-gui: Honor core.excludesfile when listing extra files\n\nRecent git versions have a git-status that honors the core.excludesfile\nconfiguration option when it reports on untracked files.  Unfortunately\nI missed the introduction of this configuration option in the core\nporcelain implementation, so it was not reflected here in git-gui.\n\nFound and reported by Lars Noschinski <lars@public.noschinski.de>.\n\nSigned-off-by: Shawn O. Pearce <spearce@spearce.org>\n---\n git-gui.sh |    4 ++++\n 1 files changed, 4 insertions(+), 0 deletions(-)\n\ndiff --git a/git-gui.sh b/git-gui.sh\nindex d7fad46..4e3b58c 100755\n--- a/git-gui.sh\n+++ b/git-gui.sh\n@@ -872,6 +872,10 @@ proc rescan_stage2 {fd after} {\n \tif {[file readable $info_exclude]} {\n \t\tlappend ls_others \"--exclude-from=$info_exclude\"\n \t}\n+\tset user_exclude [get_config core.excludesfile]\n+\tif {$user_exclude ne {} && [file readable $user_exclude]} {\n+\t\tlappend ls_others \"--exclude-from=$user_exclude\"\n+\t}\n \n \tset buf_rdi {}\n \tset buf_rdf {}\n-- \n1.5.3.rc3.843.g25b4\n\n\n-- \nShawn.\n"}]}