{"thread":{"id":"9167","subject":"[PATCH] describe: Add unlisted option","startedAt":"2007-07-23T06:24:37Z","lastAt":"2007-07-23T08:54:13Z","messageCount":5,"participants":["Yasushi SHOJI","Shawn O. Pearce","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"48269","messageId":"87sl7fmyca.wl@mail2.atmark-techno.com","threadId":"9167","inReplyTo":null,"subject":"[PATCH] describe: Add unlisted option","fromName":"Yasushi SHOJI","fromEmail":"yashi@atmark-techno.com","sentAt":"2007-07-23T06:24:37Z","receivedAt":"2007-07-23T06:24:37Z","isPatch":true,"sender":{"key":"yashi@atmark-techno.com","avatar":"https://gravatar.com/avatar/4817e8703ac4379935834d87453faa9d0c94b9dc19d83fcc54c67875eb133e59?d=mp&s=160"},"body":"added unlisted options, --contains, --candidates and --debug, to usage\nline. also, prints some info when --contains and --debug are given.\n---\n Documentation/git-describe.txt | 4 +++-\n builtin-describe.c | 5 ++++-\n 2 files changed, 7 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-describe.txt b/Documentation/git-describe.txt\nindex ac23e28..f0bcb61 100644\n--- a/Documentation/git-describe.txt\n+++ b/Documentation/git-describe.txt\n@@ -8,7 +8,9 @@ git-describe - Show the most recent tag that is reachable from a commit\n \n SYNOPSIS\n --------\n-'git-describe' [--all] [--tags] [--contains] [--abbrev=] ...\n+'git-describe' [--all] [--tags] [--contains] [--abbrev=]\n+ [--candidates=] [--debug]\n+ ...\n \n DESCRIPTION\n -----------\ndiff --git a/builtin-describe.c b/builtin-describe.c\nindex 669110c..e94f867 100644\n--- a/builtin-describe.c\n+++ b/builtin-describe.c\n@@ -9,7 +9,7 @@\n #define MAX_TAGS\t(FLAG_BITS - 1)\n \n static const char describe_usage[] =\n-\"git-describe [--all] [--tags] [--abbrev=] *\";\n+\"git-describe [--all] [--tags] [--contains] [--abbrev=] [--candidates] [--debug] *\";\n \n static int debug;\t/* Display lots of verbose info */\n static int all;\t/* Default to annotated tags only */\n@@ -283,6 +283,9 @@ int cmd_describe(int argc, const char **argv, const char *prefix)\n \t\targs[2] = \"--tags\";\n \t\tmemcpy(args + 3, argv + i, (argc - i) * sizeof(char*));\n \t\targs[3 + argc - i] = NULL;\n+\t\tif (debug)\n+\t\t\tfprintf(stderr, \"redirecting to \\\"git name-rev\\\"; \"\n+\t\t\t\t\"no searching strategy will be printed\\n\");\n \t\treturn cmd_name_rev(3 + argc - i, args, prefix);\n \t}\n \n-- \n1.5.3.rc2.4.g726f9\n"},{"id":"48272","messageId":"20070723070308.GH32566@spearce.org","threadId":"9167","inReplyTo":"87sl7fmyca.wl@mail2.atmark-techno.com","subject":"Re: [PATCH] describe: Add unlisted option","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-07-23T07:03:08Z","receivedAt":"2007-07-23T07:03:08Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Yasushi SHOJI wrote:\n> added unlisted options, --contains, --candidates and --debug, to usage\n> line. also, prints some info when --contains and --debug are given.\n\nThat makes sense. Especially telling the user why --debug --contains\ndoesn't actually print anything. ;-)\n\nOriginally I left out --candidates and --debug when I wrote the code\nfor them as I thought they were a tad too internal for casual use.\nBut maybe it makes sense to include them in the usage string.\n\n\nAcked-by: Shawn O. Pearce \n\n-- \nShawn.\n"},{"id":"48275","messageId":"7vabtnmusm.fsf@assigned-by-dhcp.cox.net","threadId":"9167","inReplyTo":"20070723070308.GH32566@spearce.org","subject":"Re: [PATCH] describe: Add unlisted option","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-07-23T07:41:13Z","receivedAt":"2007-07-23T07:41:13Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Shawn O. Pearce\" writes:\n\n> Yasushi SHOJI wrote:\n>> added unlisted options, --contains, --candidates and --debug, to usage\n>> line. also, prints some info when --contains and --debug are given.\n>\n> That makes sense. Especially telling the user why --debug --contains\n> doesn't actually print anything. ;-)\n>\n> Originally I left out --candidates and --debug when I wrote the code\n> for them as I thought they were a tad too internal for casual use.\n> But maybe it makes sense to include them in the usage string.\n\nI was actually going to suggest removing these options, that\nwere primarily meant for debugging and tweaking while we figure\nout what the optimum default should be. Do you think they are\nworth keeping?\n"},{"id":"48277","messageId":"20070723074736.GJ32566@spearce.org","threadId":"9167","inReplyTo":"7vabtnmusm.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] describe: Add unlisted option","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2007-07-23T07:47:36Z","receivedAt":"2007-07-23T07:47:36Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Junio C Hamano wrote:\n> \"Shawn O. Pearce\" writes:\n> > Originally I left out --candidates and --debug when I wrote the code\n> > for them as I thought they were a tad too internal for casual use.\n> > But maybe it makes sense to include them in the usage string.\n> \n> I was actually going to suggest removing these options, that\n> were primarily meant for debugging and tweaking while we figure\n> out what the optimum default should be. Do you think they are\n> worth keeping?\n\nYea, I do. I'd like to keep them in the code as sometimes I do\nlook at their output. I'll even help maintain them, because they\nchange oh so often. ;-)\n\nBut if you really want them gone, I won't stop you.\n\n-- \nShawn.\n"},{"id":"48285","messageId":"7vwswrlcui.fsf@assigned-by-dhcp.cox.net","threadId":"9167","inReplyTo":"20070723074736.GJ32566@spearce.org","subject":"Re: [PATCH] describe: Add unlisted option","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-07-23T08:54:13Z","receivedAt":"2007-07-23T08:54:13Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Shawn O. Pearce\" writes:\n\n>> I was actually going to suggest removing these options, that\n>> were primarily meant for debugging and tweaking while we figure\n>> out what the optimum default should be. Do you think they are\n>> worth keeping?\n>\n> Yea, I do. I'd like to keep them in the code as sometimes I do\n> look at their output. I'll even help maintain them, because they\n> change oh so often. ;-)\n>\n> But if you really want them gone, I won't stop you.\n\nNah, I already noticed your Ack and inferred that you would want\nto keep them. Haven't applied the patches yet, though.\n"}]}