{"thread":{"id":"912","subject":"Cogito: split Makefile targets of Cogito/git","startedAt":"2005-06-11T19:50:33Z","lastAt":"2005-06-11T22:09:18Z","messageCount":5,"participants":["Kay Sievers","Sven Verdoolaege","Petr Baudis","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"4879","messageId":"20050611195033.GA22713@vrfy.org","threadId":"912","inReplyTo":null,"subject":"Cogito: split Makefile targets of Cogito/git","fromName":"Kay Sievers","fromEmail":"kay.sievers@vrfy.org","sentAt":"2005-06-11T19:50:33Z","receivedAt":"2005-06-11T19:50:33Z","isPatch":false,"sender":{"key":"kay.sievers@vrfy.org","avatar":null},"body":"This splits the targets of Cogito/git to be able to call it\nindependently. This way we can easily make Cogito a separate\npackage, which just requires git.\n\nThanks,\nKay\n\n\ndiff --git a/Makefile b/Makefile\n--- a/Makefile\n+++ b/Makefile\n@@ -112,9 +112,10 @@ endif\n \n CFLAGS += '-DSHA1_HEADER=$(SHA1_HEADER)'\n \n-\n-all: $(PROG) $(GEN_SCRIPT)\n-\n+.PHONY: all it cogito\n+all: git cogito\n+git: $(PROG)\n+cogito: $(GEN_SCRIPT)\n \n test-delta: test-delta.c diff-delta.o patch-delta.o\n \t$(CC) $(CFLAGS) -o $@ $^\n@@ -169,9 +170,16 @@ test: all\n \n sedlibdir=$(shell echo $(libdir) | sed 's/\\//\\\\\\//g')\n \n-install: $(PROG) $(SCRIPTS) $(SCRIPT) $(LIB_SCRIPT) $(GEN_SCRIPT)\n+.PHONY: install install-git install-cogito\n+install: install-git install-cogito\n+\n+install-git: $(PROG) $(SCRIPTS)\n+\t$(INSTALL) -m755 -d $(DESTDIR)$(bindir)\n+\t$(INSTALL) $(PROG) $(SCRIPTS) $(DESTDIR)$(bindir)\n+\n+install-cogito: $(SCRIPT) $(LIB_SCRIPT) $(GEN_SCRIPT)\n \t$(INSTALL) -m755 -d $(DESTDIR)$(bindir)\n-\t$(INSTALL) $(PROG) $(SCRIPTS) $(SCRIPT) $(GEN_SCRIPT) $(DESTDIR)$(bindir)\n+\t$(INSTALL) $(SCRIPT) $(GEN_SCRIPT) $(DESTDIR)$(bindir)\n \t$(INSTALL) -m755 -d $(DESTDIR)$(libdir)\n \t$(INSTALL) $(LIB_SCRIPT) $(DESTDIR)$(libdir)\n \tcd $(DESTDIR)$(bindir); \\\n"},{"id":"4880","messageId":"20050611200651.GA12763MdfPADPa@garage.linux.student.kuleuven.ac.be","threadId":"912","inReplyTo":"20050611195033.GA22713@vrfy.org","subject":"Re: Cogito: split Makefile targets of Cogito/git","fromName":"Sven Verdoolaege","fromEmail":"skimo@kotnet.org","sentAt":"2005-06-11T20:06:51Z","receivedAt":"2005-06-11T20:06:51Z","isPatch":false,"sender":{"key":"skimo@kotnet.org","avatar":null},"body":"On Sat, Jun 11, 2005 at 09:50:33PM +0200, Kay Sievers wrote:\n> +.PHONY: all it cogito\n\nI suppose this should be\n\n+.PHONY: all git cogito\n\nskimo\n"},{"id":"4881","messageId":"20050611201933.GC22991@vrfy.org","threadId":"912","inReplyTo":"20050611195033.GA22713@vrfy.org","subject":"Re: Cogito: split Makefile targets of Cogito/git","fromName":"Kay Sievers","fromEmail":"kay.sievers@vrfy.org","sentAt":"2005-06-11T20:19:33Z","receivedAt":"2005-06-11T20:19:33Z","isPatch":false,"sender":{"key":"kay.sievers@vrfy.org","avatar":null},"body":"On Sat, Jun 11, 2005 at 09:50:33PM +0200, Kay Sievers wrote:\n> This splits the targets of Cogito/git to be able to call it\n> independently. This way we can easily make Cogito a separate\n> package, which just requires git.\n\n> +.PHONY: all it cogito\n\n\"all it cogito\" sounds funny, but is obviously wrong. :)\nNew patch attached.\n\nThanks Dave!\n\nKay\n\n\ndiff --git a/Makefile b/Makefile\n--- a/Makefile\n+++ b/Makefile\n@@ -112,9 +112,10 @@ endif\n \n CFLAGS += '-DSHA1_HEADER=$(SHA1_HEADER)'\n \n-\n-all: $(PROG) $(GEN_SCRIPT)\n-\n+.PHONY: all git cogito\n+all: git cogito\n+git: $(PROG)\n+cogito: $(GEN_SCRIPT)\n \n test-delta: test-delta.c diff-delta.o patch-delta.o\n \t$(CC) $(CFLAGS) -o $@ $^\n@@ -169,9 +170,16 @@ test: all\n \n sedlibdir=$(shell echo $(libdir) | sed 's/\\//\\\\\\//g')\n \n-install: $(PROG) $(SCRIPTS) $(SCRIPT) $(LIB_SCRIPT) $(GEN_SCRIPT)\n+.PHONY: install install-git install-cogito\n+install: install-git install-cogito\n+\n+install-git: $(PROG) $(SCRIPTS)\n+\t$(INSTALL) -m755 -d $(DESTDIR)$(bindir)\n+\t$(INSTALL) $(PROG) $(SCRIPTS) $(DESTDIR)$(bindir)\n+\n+install-cogito: $(SCRIPT) $(LIB_SCRIPT) $(GEN_SCRIPT)\n \t$(INSTALL) -m755 -d $(DESTDIR)$(bindir)\n-\t$(INSTALL) $(PROG) $(SCRIPTS) $(SCRIPT) $(GEN_SCRIPT) $(DESTDIR)$(bindir)\n+\t$(INSTALL) $(SCRIPT) $(GEN_SCRIPT) $(DESTDIR)$(bindir)\n \t$(INSTALL) -m755 -d $(DESTDIR)$(libdir)\n \t$(INSTALL) $(LIB_SCRIPT) $(DESTDIR)$(libdir)\n \tcd $(DESTDIR)$(bindir); \\\n"},{"id":"4882","messageId":"20050611211142.GG3193@pasky.ji.cz","threadId":"912","inReplyTo":"20050611201933.GC22991@vrfy.org","subject":"Re: Cogito: split Makefile targets of Cogito/git","fromName":"Petr Baudis","fromEmail":"pasky@ucw.cz","sentAt":"2005-06-11T21:11:43Z","receivedAt":"2005-06-11T21:11:43Z","isPatch":false,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Dear diary, on Sat, Jun 11, 2005 at 10:19:33PM CEST, I got a letter\nwhere Kay Sievers <kay.sievers@vrfy.org> told me that...\n> On Sat, Jun 11, 2005 at 09:50:33PM +0200, Kay Sievers wrote:\n> > This splits the targets of Cogito/git to be able to call it\n> > independently. This way we can easily make Cogito a separate\n> > package, which just requires git.\n> \n> > +.PHONY: all it cogito\n> \n> \"all it cogito\" sounds funny, but is obviously wrong. :)\n> New patch attached.\n\nCould you please sign off the patch?\n\nThanks,\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\n<Espy> be careful, some twit might quote you out of context..\n"},{"id":"4884","messageId":"7vbr6csfzl.fsf@assigned-by-dhcp.cox.net","threadId":"912","inReplyTo":"20050611195033.GA22713@vrfy.org","subject":"Re: Cogito: split Makefile targets of Cogito/git","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-06-11T22:09:18Z","receivedAt":"2005-06-11T22:09:18Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":">>>>> \"KS\" == Kay Sievers <kay.sievers@vrfy.org> writes:\n\nKS> -\nKS> -all: $(PROG) $(GEN_SCRIPT)\nKS> -\nKS> +.PHONY: all it cogito\nKS> +all: git cogito\nKS> +git: $(PROG)\nKS> +cogito: $(GEN_SCRIPT)\n \n(Tongue in cheek)  How about this instead ;^) \n\n    -\n    -all: $(PROG) $(GEN_SCRIPT)\n    -\n    +.PHONY: all git coo\n    +all: git coo\n    +git: $(PROG)\n    +coo: $(GEN_SCRIPT)\n\n\n"}]}