{"thread":{"id":"9075","subject":"[PATCH] git-svn: Minimalistic patch which allows svn usernames with space(s).","startedAt":"2007-07-17T17:02:57Z","lastAt":"2007-07-18T08:47:59Z","messageCount":4,"participants":["Richard MUSIL","Eric Wong"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"47655","messageId":"469CF641.4020707@st.com","threadId":"9075","inReplyTo":null,"subject":"[PATCH] git-svn: Minimalistic patch which allows svn usernames with space(s).","fromName":"Richard MUSIL","fromEmail":"richard.musil@st.com","sentAt":"2007-07-17T17:02:57Z","receivedAt":"2007-07-17T17:02:57Z","isPatch":true,"sender":{"key":"richard.musil@st.com","avatar":null},"body":"Changed filter for username in svn-authors file, so even 'user name' is accepted.\n---\n git-svn.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-svn.perl b/git-svn.perl\nindex 01c3904..975075e 100755\n--- a/git-svn.perl\n+++ b/git-svn.perl\n@@ -740,7 +740,7 @@ sub load_authors {\n        my $log = $cmd eq 'log';\n        while (<$authors>) {\n                chomp;\n-               next unless /^(\\S+?|\\(no author\\))\\s*=\\s*(.+?)\\s*<(.+)>\\s*$/;\n+               next unless /^(\\.+?|\\(no author\\))\\s*=\\s*(.+?)\\s*<(.+)>\\s*$/;\n                my ($user, $name, $email) = ($1, $2, $3);\n                if ($log) {\n                        $Git::SVN::Log::rusers{\"$name <$email>\"} = $user;\n--\n1.5.1.6\n"},{"id":"47670","messageId":"20070717195559.GA20103@muzzle","threadId":"9075","inReplyTo":"469CF641.4020707@st.com","subject":"Re: [PATCH] git-svn: Minimalistic patch which allows svn usernames with space(s).","fromName":"Eric Wong","fromEmail":"eric@petta-tech.com","sentAt":"2007-07-17T19:55:59Z","receivedAt":"2007-07-17T19:55:59Z","isPatch":true,"sender":{"key":"eric@petta-tech.com","avatar":null},"body":"Richard MUSIL <richard.musil@st.com> wrote:\n> Changed filter for username in svn-authors file, so even 'user name' is accepted.\n> ---\n>  git-svn.perl |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n> \n> diff --git a/git-svn.perl b/git-svn.perl\n> index 01c3904..975075e 100755\n> --- a/git-svn.perl\n> +++ b/git-svn.perl\n> @@ -740,7 +740,7 @@ sub load_authors {\n>         my $log = $cmd eq 'log';\n>         while (<$authors>) {\n>                 chomp;\n> -               next unless /^(\\S+?|\\(no author\\))\\s*=\\s*(.+?)\\s*<(.+)>\\s*$/;\n> +               next unless /^(\\.+?|\\(no author\\))\\s*=\\s*(.+?)\\s*<(.+)>\\s*$/;\n\nSurely you mean the following:\n\n+               next unless /^(.+?|\\(no author\\))\\s*=\\s*(.+?)\\s*<(.+)>\\s*$/;\n\n(No \"\\\" before the \".\")   \"\\.\" matches a dot/period (.), while \".\"\nmatches anything.\n\n-- \nEric Wong\n"},{"id":"47712","messageId":"20070718073629.GB30559@muzzle","threadId":"9075","inReplyTo":"20070717195559.GA20103@muzzle","subject":"Re: [PATCH] git-svn: Minimalistic patch which allows svn usernames with space(s).","fromName":"Eric Wong","fromEmail":"eric@petta-tech.com","sentAt":"2007-07-18T07:36:29Z","receivedAt":"2007-07-18T07:36:29Z","isPatch":true,"sender":{"key":"eric@petta-tech.com","avatar":null},"body":"Eric Wong <eric@petta-tech.com> wrote:\n> Richard MUSIL <richard.musil@st.com> wrote:\n> > Changed filter for username in svn-authors file, so even 'user name' is accepted.\n> > ---\n> >  git-svn.perl |    2 +-\n> >  1 files changed, 1 insertions(+), 1 deletions(-)\n> > \n> > diff --git a/git-svn.perl b/git-svn.perl\n> > index 01c3904..975075e 100755\n> > --- a/git-svn.perl\n> > +++ b/git-svn.perl\n> > @@ -740,7 +740,7 @@ sub load_authors {\n> >         my $log = $cmd eq 'log';\n> >         while (<$authors>) {\n> >                 chomp;\n> > -               next unless /^(\\S+?|\\(no author\\))\\s*=\\s*(.+?)\\s*<(.+)>\\s*$/;\n> > +               next unless /^(\\.+?|\\(no author\\))\\s*=\\s*(.+?)\\s*<(.+)>\\s*$/;\n> \n> Surely you mean the following:\n> \n> +               next unless /^(.+?|\\(no author\\))\\s*=\\s*(.+?)\\s*<(.+)>\\s*$/;\n> \n> (No \"\\\" before the \".\")   \"\\.\" matches a dot/period (.), while \".\"\n> matches anything.\n\nFwiw, with the regexp corrected:\n  Acked-by: Eric Wong <normalperson@yhbt.net>\n\n-- \nEric Wong\n"},{"id":"47714","messageId":"469DD3BF.70709@st.com","threadId":"9075","inReplyTo":"20070717195559.GA20103@muzzle","subject":"Re: [PATCH] git-svn: Minimalistic patch which allows svn usernames with space(s).","fromName":"Richard MUSIL","fromEmail":"richard.musil@st.com","sentAt":"2007-07-18T08:47:59Z","receivedAt":"2007-07-18T08:47:59Z","isPatch":true,"sender":{"key":"richard.musil@st.com","avatar":null},"body":"Eric Wong wrote:\n> Richard MUSIL <richard.musil@st.com> wrote:\n>> Changed filter for username in svn-authors file, so even 'user name' is accepted.\n>> ---\n>>  git-svn.perl |    2 +-\n>>  1 files changed, 1 insertions(+), 1 deletions(-)\n>>\n>> diff --git a/git-svn.perl b/git-svn.perl\n>> index 01c3904..975075e 100755\n>> --- a/git-svn.perl\n>> +++ b/git-svn.perl\n>> @@ -740,7 +740,7 @@ sub load_authors {\n>>         my $log = $cmd eq 'log';\n>>         while (<$authors>) {\n>>                 chomp;\n>> -               next unless /^(\\S+?|\\(no author\\))\\s*=\\s*(.+?)\\s*<(.+)>\\s*$/;\n>> +               next unless /^(\\.+?|\\(no author\\))\\s*=\\s*(.+?)\\s*<(.+)>\\s*$/;\n> \n> Surely you mean the following:\n> \n> +               next unless /^(.+?|\\(no author\\))\\s*=\\s*(.+?)\\s*<(.+)>\\s*$/;\n> \n> (No \"\\\" before the \".\")   \"\\.\" matches a dot/period (.), while \".\"\n> matches anything.\n> \nYes! I am sorry for a confusion, I have tested it on '.' version, but committed the wrong one :(.\n\nRichard\n"}]}